Return-Path: Received: from mail5.wrs.com (mail5.windriver.com [192.103.53.11]) by mail.openembedded.org (Postfix) with ESMTP id 8CAC76C0EA for ; Fri, 17 May 2019 07:44:46 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id x4H7i0cU023382 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Fri, 17 May 2019 00:44:20 -0700 Received: from soho-mhatle-m.local (147.11.117.150) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.439.0; Fri, 17 May 2019 00:44:09 -0700 To: Richard Purdie , References: <20190516104616.154845-1-mark.hatle@windriver.com> From: Mark Hatle Openpgp: preference=signencrypt Autocrypt: addr=mark.hatle@windriver.com; prefer-encrypt=mutual; keydata= mQENBFYKxFgBCACt/pzutBp6p/xVKTFJjHbM3KpQKCblyot/YP+bpTr51Hrc5xDXBQhoG7TC aIRvRIvbhEevEQK9y04gW3JK/5lobq5ORebolcsHlYBUvpNeIPjupLQwGvz/TPtrLRNGLqDC rvsM6OA2XbQ2bwzxWaSQS3ImE2O2iXOZn9HhThMGeDB4Nff3fgUvXOTDIrgWOn9K2DgLL7Yc zkUIlFdj+Nraksd/7BSk8oH6tjeBVhFqSFvKta9QxWgdr58oPaTYaW/xNqUjlLrbJuMw/MSe xzuYfdfDfm6J8kRjMOnwQ0n8svJElzqAk+d83ow38gpGQ+LkjGgnf8ZFJ4rUJFADroX3ABEB AAG0JU1hcmsgSGF0bGUgPG1hcmsuaGF0bGVAd2luZHJpdmVyLmNvbT6JATcEEwEIACEFAlYK xFgCGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQfv796/r0vvlvZAf9Gs+eN320yhRW V/fZCsngKhmOK4v3HrTwFrkSmoD9QHQiE/5IPdNacHwIPwZx07tNBohB8xOeNqCPRYRBwGhA AnxKOPyd0nnm6ZhPzbA57v4x3IGRQr4QzvcBTASJq91l3Ew4lpAslyx5w1DPPqRD7G8ycDKg peKyDwmdkvCunVisSAQI3XIMq2y230biTO98tDPEezg+lg+yTsz9ZT33F5KNuWrpf8VL5fG/ mt+kAv7wtsx/KTRbqhH3iFXF6eBSwMjAfTXFlkLfbM9riJGXrWEl9n2S2R3cDHNHug0lb8f4 whK370KEO4OwRKIYW/VUBmzk5XZUE9DTlDSV8ycsrrkBDQRWCsRYAQgAwK3FuHCE+HW3YWdH PUjeSn5p//xJ57u8g2rng8zm9zNjmYgpPv5UxozaD9i2jf4mlQLHGGOezhHae8K4Nj70oVcv 8AmwcrJa9i9WL1oy/9R3fHMWf/Ctt9VXTO0qlCuq6PDzaUfvsXR61aJIjTKNQTOjCLjY1vXm VSewUgARysmA8WrjTfwGBihMBxAX0+kIjx8nOlam0WvekMBXZ0AbS56oTLRxYao6DI3GeB/N oWPy/5DfuTKaSdM0Pf8al20x9RuNN5/HLMlyDH/k8bIa1xd9aAqW+Feiw5gC107V2E6ULyIy q6em2UrsmIRxrvpHqbNgQKqvTehJ+V/i4g/uOwARAQABiQEfBBgBCAAJBQJWCsRYAhsMAAoJ EH7+/ev69L755XAH/3ZcNhooqd9OBhFkvXm1iWZ8EoC7motWqVn2oEyxoonsg8AD9kFXiN+T dYp7dH99EZu9q4ptj56AXm4uHzOgywL/5/V2TY6twCGAjUGzDjAB5gzoi+JLIBlDiyOip0eL QswIhRk473xy3j8DA4oVamnSPWgyNJ+qsdt37YWDzoDFFvtDoRU7Eb+znfIMDKzlny0XU/8L cW1bNHJlpv/78GPdfP4tjysEd8MuA5jf5o5w4XqcwTqalffEJtQ/s3pbkstEi7qm5uPui5Kt gq6YYLSqcSNe0GWAF9/T+qwyo7burSTxUWCWtMmlXdAQLW9SynLhB3Jbch0nFAh0fCKi6yY= Organization: Wind River Systems Message-ID: <96ea6f7b-e30d-d598-1d68-0b53ed373229@windriver.com> Date: Fri, 17 May 2019 10:44:07 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v2] svn.py: Stop SVN from directly pulling from an external layer w/o fetcher X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussion that advance bitbake development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 07:44:46 -0000 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit On 5/17/19 9:16 AM, Richard Purdie wrote: > On Thu, 2019-05-16 at 06:46 -0400, Mark Hatle wrote: >> Add a new option to the svn fetcher url "externals=allowed". This will allow >> a user to enable svn co w/ externals. However, this does avoid the fetcher, >> network access and mirror systems. >> >> By default we no longer allow externals in the checkout. This ensures a >> deterministic download. The system does attempt to identify SVN repos that >> have externals enabled, and will warn the user. It is up to the user to >> determine if these are necessary for the recipe. They may disable the warning >> by adding "externals=nowarn" to the url. >> >> In the future we would like to parse this list and see if the items are already >> in the SRC_URI for that recipe, but with SVN being in limited use these days >> that extra work is likely not worth the trouble. >> >> Add test cases that generated a local SVN tree, with an external source >> set to github bitbake in svn format. One test case checks that externals are >> ignored, and one checks that they in downloaded. >> >> Signed-off-by: Mark Hatle >> --- >> v2: >> Refactored the test case to use --non-interactive option to try to avoid >> the controlling terminal failure. > > I think this is working better but it leaves us with a second issue, > not all our autobuilder workers have subversion installed: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/177 > https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/176 > https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/175 > > (a pass: > https://autobuilder.yoctoproject.org/typhoon/#/builders/79/builds/180) > > I did specifically test on debian 9 where we saw the problem last time > and that issue is resolved and passes now. > > The question now is whether we want to install subversion on all our > workers, whether we download and install some kind of standalone test > tarball for this test or whether we disable the test by default... Is there a concept of a skipped test within bitbake-selftest? It would be easy enough for me to check if 'svn' and 'svnadmin' were available in the environment and simply skip them. Then it's up to you guys to figure out if this is a test you want to run on all of the builders by installing svn or a standalone test tarball as you suggested. --Mark > Cheers, > > Richard > > >