From: David Howells Subject: Re: [PATCH] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check Date: Tue, 15 Jan 2013 10:39:23 +0000 Message-ID: <9706.1358246363@warthog.procyon.org.uk> References: <1358210328-16726-1-git-send-email-dinggnu@gmail.com> Return-path: In-Reply-To: <1358210328-16726-1-git-send-email-dinggnu@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Cong Ding Cc: dhowells@redhat.com, David Airlie , Ben Skeggs , Dave Airlie , "Paul E. McKenney" , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Cong Ding wrote: > the variable sender is dereferenced in line 190, so it is no reason to check > null again in line 198. Did you mean "The variable 'chan'"? David