From: "MaxF (Code Review)" Date: Mon, 15 Dec 2025 16:42:18 +0000 In-Reply-To: References: Reply-To: max@...2606..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, steffan@...1856... Message-ID: <975886739af658761eb882b5f4a46a5d569bd3b2-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="uCrGnMETwPI="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: syzzer , plaisthos , openvpn-devel --uCrGnMETwPI= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos, syzzer. MaxF has posted comments on this change by MaxF. ( http://gerrit.openvpn.ne= t/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 3: (3 comments) File src/openvpn/crypto_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/1441/comment/31ee5c24_5c1a094c?usp=3D= email : PS3, Line 88: /* TODO: Complete the table. */ > Consider copying the table from the private mbedtls header file, might sa= ve you some work. [=E2=80=A6] I looked at it and I'm not sure how much it helps. The new PSA_KEY_TYPE and= PSA_ALG magic numbers don't seem to be in that table. I also don't know if= legacy crypto defines like MBEDTLS_AES_C are externally visible. http://gerrit.openvpn.net/c/openvpn/+/1441/comment/26d91568_0d8c32b2?usp=3D= email : PS3, Line 204: return (int)cipher_info->key_bytes; > key_bytes is already int, right? Right http://gerrit.openvpn.net/c/openvpn/+/1441/comment/50b21610_ae2e0509?usp=3D= email : PS3, Line 299: /* TODO: Log warning on errors? */ > We can't handle the error here. If this errors out, looks to me like we a= re in an invalid state. [=E2=80=A6] I added ASSERTs to this and similar functions. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 3 Gerrit-Owner: MaxF Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: plaisthos Gerrit-Comment-Date: Mon, 15 Dec 2025 16:42:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: syzzer --uCrGnMETwPI= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: plaisthos, syzzer.

View = Change

3 comments:

  • File src/openvpn/crypto_mbedtls.c:=

    • Patch= Set #3, Line 88: /* TO= DO: Complete the table. */

      Consider copying the table= from the private mbedtls header file, might save you some work. [=E2=80=A6= ]

      I looked at it and I'm not sure how much it helps. T= he new PSA_KEY_TYPE and PSA_ALG magic numbers don't seem to be in that = table. I also don't know if legacy crypto defines like MBEDTLS_AES_C ar= e externally visible.

    • Patch Set #3, Line 204:= return (int)cipher= _info->key_bytes;

      key_bytes is already int, right?=

      Right

    • Patch Set #3, Line 29= 9: /* TODO: Log war= ning on errors? */

      We can't handle the error here= . If this errors out, looks to me like we are in an invalid state. [=E2=80= =A6]

      I added ASSERTs to this and similar functions.

To view, visit change 1441. To unsubscribe, or for help wri= ting mail filters, visit settings.

=
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 3
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Comment-Date: Mon, 15 Dec 2025 16:42:18= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: syzzer <steffan@...1852...= 6...>
= --uCrGnMETwPI=--