From: Akio Takebe Subject: Re: [PATCH] fbfront: Improve diagnostics when kthread_run()fails Date: Tue, 03 Feb 2009 08:48:51 +0900 Message-ID: <97C98590CD0C9Ftakebe_akio@jp.fujitsu.com> References: <497E784B.7060003@jp.fujitsu.com> <497ED10A.76E4.0078.0@novell.com> <498009CC.1000101@jp.fujitsu.com> <87bptlp599.fsf_-_@pike.pond.sub.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87bptlp599.fsf_-_@pike.pond.sub.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Markus Armbruster Cc: xen-devel , Akio Takebe List-Id: xen-devel@lists.xenproject.org Hi, Markus Thanks. I agree with you. Best Regards, Akio Takebe >Failure is reported with xenbus_dev_fatal(..."register_framebuffer"), >which was already suboptimal before it got moved away from >register_framebuffer(), and is outright misleading now. > >Signed-off-by: Markus Armbruster > >diff -r 26ddc59c674d drivers/xen/fbfront/xenfb.c >--- a/drivers/xen/fbfront/xenfb.c Fri Jan 30 10:54:10 2009 +0000 >+++ b/drivers/xen/fbfront/xenfb.c Mon Feb 02 10:12:54 2009 +0100 >@@ -211,7 +211,7 @@ > return; > > mutex_lock(&info->mm_lock); >- >+ > spin_lock_irqsave(&info->dirty_lock, flags); > if (info->dirty){ > info->dirty = 0; >@@ -837,7 +837,7 @@ > if (IS_ERR(info->kthread)) { > info->kthread = NULL; > xenbus_dev_fatal(dev, PTR_ERR(info->kthread), >- "register_framebuffer"); >+ "xenfb_thread"); > } > } > break; > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel