Message-ID: <97bd8269-172d-4dcd-49a5-aee3c9c19b01@...1227...> Date: Fri, 24 Jun 2022 12:25:54 +0200 MIME-Version: 1.0 Content-Language: en-GB References: <20220621161649.2872985-1-arne@...1227...> <20220621161649.2872985-5-arne@...1227...> From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 5/6] Change default MTU in server mode to 1420 and push it to client List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Frank Lichtenheld Cc: openvpn-devel@lists.sourceforge.net Am 24.06.22 um 10:38 schrieb Frank Lichtenheld: > On Fri, Jun 24, 2022 at 10:35:24AM +0200, Frank Lichtenheld wrote: >> Code changes look fine to me, but several documentation suggestions. > > Hmm, after reading the next patch might I suggest to move the > change to push.c actually to the next patch? Both references > to IV_MTU and tun-max-mtu only make sense then, right? Well basically this implements the server side functionality while the next patch implements the client side. And the changes to push.c are server side. I could also reorder these two to first introduce the client side support and then make use of it. Arne