From: "stipa (Code Review)"
Date: Thu, 17 Apr 2025 11:36:32 +0000
In-Reply-To:
References:
Reply-To: lstipakov@...277..., arne-openvpn@...1227...,
openvpn-devel@lists.sourceforge.net, frank@...2641...,
antonio@...2726...
Message-ID: <97e067a3913c7d3b1b5e37e349a4d0e3bf77407a-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="IxjsTPo7fXk="; charset=UTF-8
Subject: [Openvpn-devel] [XS] Change in openvpn[master]: ssl_openssl.c:
Prevent potential double-free
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: plaisthos , flichtenheld , openvpn-devel
--IxjsTPo7fXk=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope=
nvpn/+/942?usp=3Demail )
Change subject: ssl_openssl.c: Prevent potential double-free
......................................................................
Patch Set 1:
(1 comment)
File src/openvpn/ssl_openssl.c:
http://gerrit.openvpn.net/c/openvpn/+/942/comment/765fe0e2_13dcd7b5 :
PS1, Line 1158: while (!OSSL_STORE_eof(store_ctx))
> what you describe if possible only if this check if false immediately, ri=
ght? [=E2=80=A6]
Yes, this is what happened with mattock's certs.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/942?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 1
Gerrit-Owner: stipa
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-CC: ordex
Gerrit-Attention: plaisthos
Gerrit-Attention: flichtenheld
Gerrit-Attention: ordex
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:36:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex
Gerrit-MessageType: comment
--IxjsTPo7fXk=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: flichtenheld, ordex, plaisthos. <=
/p>
View C=
hange
1 comment:
<=
li style=3D"margin: 0; padding: 0;">File src/openvpn/ssl_openssl.c:
<=
ul style=3D"list-style: none; padding: 0;">Patch Set #1, Line 1158=
: while (!OSSL_STOR=
E_eof(store_ctx))
what you describe if possible only =
if this check if false immediately, right? [=E2=80=A6]
Yes, this is what ha=
ppened with mattock's certs.
To view, visit <=
a href=3D"http://gerrit.openvpn.net/c/openvpn/+/942?usp=3Demail">change 942=
. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4507be07cd5573b2117e837ef03=
187535a38a4b1
Gerrit-Change-Number: 942
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>=
;
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-CC: ordex <antonio@...2726...> =
div>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...=
41...>
Gerrit-Attention: ordex <antonio@...2726...=
>
Gerrit-Comment-Date: Thu, 17 Apr 2025 11:36:32=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <antonio@...2787...=
...>
Gerrit-MessageType: comment
--IxjsTPo7fXk=--