References: <20190818111811.8853-1-matthias.andree@...68...> <20190818111811.8853-2-matthias.andree@...68...> From: Arne Schwabe Message-ID: <985961be-8e2e-573d-7aa9-95884dcc847a@...1227...> Date: Sun, 18 Aug 2019 14:11:03 +0200 MIME-Version: 1.0 In-Reply-To: <20190818111811.8853-2-matthias.andree@...68...> Content-Language: de-DE Subject: Re: [Openvpn-devel] [PATCH] Fix regression, reinstate LibreSSL support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit To: Matthias Andree , openvpn-devel@lists.sourceforge.net Cc: pizzamig@...1249... Am 18.08.19 um 13:18 schrieb Matthias Andree: > OpenVPN 2.4.6 could be compiled with LibreSSL, 2.4.7 cannot. This was broken > since 9de7fe0a "Add support for tls-ciphersuites for TLS 1.3". > > This patch avoids using TLS 1.3 directly, be it that OpenSSL was compiled > without TLS 1.3 support, or LibreSSL was used. Test looks good. I don't like the additonal ifdefs but yeah seem no way around them. The ifdefs don't break OpenSSL. But I have not tested LibreSSL. Acked-By: Arne Schwabe