Return-Path: Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=linux.intel.com (client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=jae.hyun.yoo@linux.intel.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.intel.com Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 45Ywr45CjVzDqLT for ; Thu, 27 Jun 2019 07:18:42 +1000 (AEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2019 14:18:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,421,1557212400"; d="scan'208";a="337346232" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.251.14.48]) ([10.251.14.48]) by orsmga005.jf.intel.com with ESMTP; 26 Jun 2019 14:18:39 -0700 Subject: Re: [RFC PATCH dev-5.1 3/6] irqchip/aspeed-i2c-ic: add I2C SRAM enabling control To: Ryan Chen , Brendan Higgins , Benjamin Herrenschmidt , C?ric Le Goater , Joel Stanley , Andrew Jeffery Cc: "openbmc@lists.ozlabs.org" References: <20190620194922.15093-1-jae.hyun.yoo@linux.intel.com> <20190620194922.15093-4-jae.hyun.yoo@linux.intel.com> <2539f657-1966-c00d-dace-fa382bd1b85f@linux.intel.com> From: Jae Hyun Yoo Message-ID: <9859b980-df9f-2c98-3656-c65dbeb734fe@linux.intel.com> Date: Wed, 26 Jun 2019 14:18:39 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Jun 2019 21:18:45 -0000 On 6/25/2019 10:10 PM, Ryan Chen wrote: > Hello Jae, > Actually, my recommend is following. > 1. Move i2c scu reset to irq-aspeed-i2c-ic.c and also keep SRAM buffer enable. > 2. remove i2c each bus reset. Hello Ryan, My thought is, irq-aspeed-i2c-ic module should do things only irqchip drivers do. i2c-aspeed module has been doing the I2C SCU reset control correctly so far without making any problem. Regards, Jae > Ryan > > -----Original Message----- > From: Jae Hyun Yoo [mailto:jae.hyun.yoo@linux.intel.com] > Sent: Wednesday, June 26, 2019 1:23 AM > To: Ryan Chen ; Brendan Higgins ; Benjamin Herrenschmidt ; C?ric Le Goater ; Joel Stanley ; Andrew Jeffery > Cc: openbmc@lists.ozlabs.org > Subject: Re: [RFC PATCH dev-5.1 3/6] irqchip/aspeed-i2c-ic: add I2C SRAM enabling control > > On 6/21/2019 11:41 AM, Jae Hyun Yoo wrote: >> On 6/20/2019 5:33 PM, Ryan Chen wrote: >>> Hello Jae, >>>     The i2c register setting must after scu reset. - >>> APEED_I2C_SRAM_BUFFER_EN >>>     My recommend aspeed-i2c-ic.c need be probe after scu reset. And >>> all others i2c bus is no needed for scu reset. >> >> Hello Ryan, >> >> This module is registered after the SCU reset. >> Thank you for the information. >> >> Regards, >> Jae > > Hello Ryan, > > I got your point now. You meant the I2C H/W reset through SCU04 register, right? I'll move the SRAM buffer enable control from irq-aspeed-i2c-ic module to i2c-aspeed module so that the SRAM can be enabled correctly. > > Thanks for your pointing it out. > > Jae > >>> >>> Ryan >>> >>> -----Original Message----- >>> From: openbmc >>> [mailto:openbmc-bounces+ryan_chen=aspeedtech.com@lists.ozlabs.org] On >>> Behalf Of Jae Hyun Yoo >>> Sent: Friday, June 21, 2019 3:49 AM >>> To: Brendan Higgins ; Benjamin >>> Herrenschmidt ; C?ric Le Goater >>> ; Joel Stanley ; Andrew Jeffery >>> >>> Cc: openbmc@lists.ozlabs.org; Jae Hyun Yoo >>> >>> Subject: [RFC PATCH dev-5.1 3/6] irqchip/aspeed-i2c-ic: add I2C SRAM >>> enabling control >>> >>> This commit adds I2C SRAM enabling control for AST2500 SoC to support >>> buffer mode and DMA mode transfer. The SRAM is enabled by default in >>> AST2400 SoC. >>> >>> Signed-off-by: Jae Hyun Yoo >>> --- >>>   drivers/irqchip/irq-aspeed-i2c-ic.c | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> >>> diff --git a/drivers/irqchip/irq-aspeed-i2c-ic.c >>> b/drivers/irqchip/irq-aspeed-i2c-ic.c >>> index f20200af0992..99985b22a9fa 100644 >>> --- a/drivers/irqchip/irq-aspeed-i2c-ic.c >>> +++ b/drivers/irqchip/irq-aspeed-i2c-ic.c >>> @@ -18,6 +18,9 @@ >>>   #include >>>   #include >>> +/* I2C Global Control Register (AST2500) */ #define >>> +ASPEED_I2C_GLOBAL_CTRL_REG    0xc #define  ASPEED_I2C_SRAM_BUFFER_EN >>> +BIT(0) >>>   #define ASPEED_I2C_IC_NUM_BUS 14 >>> @@ -100,6 +103,11 @@ static int __init aspeed_i2c_ic_of_init(struct >>> device_node *node, >>>       irq_set_chained_handler_and_data(i2c_ic->parent_irq, >>>                        aspeed_i2c_ic_irq_handler, i2c_ic); >>> +    /* Enable I2C SRAM buffer in case of AST2500 */ >>> +    if (of_device_is_compatible(node, "aspeed,ast2500-i2c-ic")) >>> +        writel(ASPEED_I2C_SRAM_BUFFER_EN, >>> +               i2c_ic->base + ASPEED_I2C_GLOBAL_CTRL_REG); >>> + >>>       pr_info("i2c controller registered, irq %d\n", >>> i2c_ic->parent_irq); >>>       return 0; >>> -- >>> 2.22.0 >>>