From: "stipa (Code Review)" Date: Thu, 30 Jan 2025 09:01:25 +0000 In-Reply-To: References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., a@...2181... Message-ID: <98b77425c8ac3d1e256643af58d659d130ce9552-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="73UVVtI2PRQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: mudp.c: keep offset value when resetting buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: flichtenheld , plaisthos , openvpn-devel --73UVVtI2PRQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: ordex, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/814?usp=3Demail ) Change subject: mudp.c: keep offset value when resetting buffer ...................................................................... Patch Set 12: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/814/comment/5d94cc70_a4b520cc : PS12, Line 58: ASSERT(buf_init(&c->c2.buffers->aux_buf, buf.offset)); > under what circumstance do we expect this ASSERT to be triggered? [=E2=80= =A6] buf_init() can in fail if there is not enough capacity, but it should not b= e the case. In fact, all buf_init() calls except one are wrapped into ASSER= T. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/814?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I145573555aaace5e94774b5f977d032d3747ed72 Gerrit-Change-Number: 814 Gerrit-PatchSet: 12 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: ordex Gerrit-Attention: plaisthos Gerrit-Attention: ordex Gerrit-Comment-Date: Thu, 30 Jan 2025 09:01:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex Gerrit-MessageType: comment --73UVVtI2PRQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: ordex, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpn/mudp.c:

    • Patch Set #12, Line 58: ASSERT(buf_init(&c-&g= t;c2.buffers->aux_buf, buf.offset));

      under what ci= rcumstance do we expect this ASSERT to be triggered? [=E2=80=A6]

      buf_init()= can in fail if there is not enough capacity, but it should not be the case= . In fact, all buf_init() calls except one are wrapped into ASSERT.

To view, visit change 814. To unsubscribe, or for help writin= g mail filters, visit settin= gs.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I145573555aaace5e94774b5f977= d032d3747ed72
Gerrit-Change-Number: 814
Gerrit-PatchSet: 12
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: ordex <a@...2181...>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: ordex <a@...2181...> <= /div>
Gerrit-Comment-Date: Thu, 30 Jan 2025 09:01:25= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ordex <a@...2181...>= ;
Gerrit-MessageType: comment
--73UVVtI2PRQ=--