From: Maarten Lankhorst Subject: Re: [Intel-gfx] [PATCH] drm/atomic-helper: Fix leak in disable_all Date: Mon, 17 Jul 2017 11:39:56 +0200 Message-ID: <99354236-94a5-4e04-79b2-ce7593e69e0d@linux.intel.com> References: <20170714224656.6431-1-daniel.vetter@ffwll.ch> <20170715093106.19873-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170715093106.19873-1-daniel.vetter@ffwll.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Intel Graphics Development List-Id: dri-devel@lists.freedesktop.org T3AgMTUtMDctMTcgb20gMTE6MzEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IFRoZSBsZWdhY3kg cGxhbmUtPmZiIHBvaW50ZXIgaXMgcmVmY291bnRlZCBieSBjYWxsaW5nCj4gZHJtX2F0b21pY19j bGVhbl9vbGRfZmIoKS4KPgo+IEluIHByYWN0aWNlIHRoaXMgaXNuJ3QgYSByZWFsIHByb2JsZW0g YmVjYXVzZToKPiAtIFRoZSBjYWxsZXIgaW4gdGhlIGk5MTUgZ3B1IHJlc2V0IGNvZGUgcmVzdG9y ZXMgdGhlIG9yaWdpbmFsIHN0YXRlCj4gICBhZ2Fpbiwgd2hpY2ggbWVhbnMgdGhlIHBsYW5lLT5m YiBwb2ludGVyIHdvbid0IGNoYW5nZSwgaGVuY2UgY2FuJ3QKPiAgIGxlYWsuCj4gLSBEcml2ZXJz IHVzaW5nIGRybV9hdG9taWNfaGVscGVyX3NodXRkb3duIGNhbGwgdGhlIGZiZGV2IGNsZWFudXAK PiAgIGZpcnN0LCBhbmQgdGhhdCB1c3VhbGx5IGNsZWFucyB1cCB0aGUgZmIgdGhyb3VnaAo+ICAg ZHJtX3JlbW92ZV9mcmFtZWJ1ZmZlciwgd2hpY2ggZG9lcyB0aGlzIGNvcnJlY3RseS4KPiAtIFdp dGhvdXQgZmJkZXYgdGhlIG9ubHkgZnJhbWVidWZmZXJzIGFyZSBmcm9tIHVzZXJzcGFjZSwgYW5k IHRob3NlCj4gICBnZXQgY2xlYW5lZCB1cCAoYWdhaW4gdXNpbmcgZHJtX3JlbW92ZV9mcmFtZWJ1 ZmZlcikgYmVmb3IgdGhlIGRyaXZlcgo+ICAgY2FuIGV2ZW4gYmUgdW5sb2FkZWQuCj4KPiBCdXQg aW4gaTkxNSBJJ3ZlIHN3aXRjaGVkIHRoZSBjbGVhbnVwIHNlcXVlbmNlIGFyb3VuZCBzbyB0aGF0 IHRoZQo+IF9zaHV0ZG93bigpIGNhbGxzIGhhcHBlbnMgYWZ0ZXIgdGhlIGRybV9yZW1vdmVfZnJh bWVidWZmZXIoKSwgd2hpY2ggaXMKPiBob3cgSSBkaXNjb3ZlcmVkIHRoaXMgaXNzdWUuCj4KPiB2 MjogTXkgYW5hbHlzaXMgd2h5IHRoZSBjdXJyZW50IGNvZGUgd2FzIG9rIGZvciBncHUgcmVzZXQg YW5kCj4gc3VzcGVuZC9yZXN1bWUgd2FzIGNvcnJlY3QsIGJ1dCB0aGVuIEkgdG90YWxseSBmYWls ZWQgdG8gcmVhbGl6ZSB0aGF0Cj4gd2UgYmV0dGVyIGtlZXAgdGhpcyBzeW1tZXRyaWMuIFRoYW5r c2Z1bGx5IENJIG5vdGljZWQgdGhhdCBmb3IKPiBiYWxhbmNlLCBhIHJlZmNvdW50aW5nIGJ1ZyBt dXN0IGV4aXN0IGF0IDIgcGxhY2VzIGlmIHByZXZpb3VzbHkgdGhlcmUKPiB3YXMgbm8gaXNzdWUg Li4uCj4KPiB2MzogRG9uJ3QgYmUgbGF6eSBhbmQgY29tcHV0ZSB0aGUgcGxhbmVfbWFzayBpbgo+ IGNvbW1pdF9kdXBsaWNhdGVkX3N0YXRlIHByb3Blcmx5IHRvbywgaW5zdGVhZCBvZiBqdXN0IHVz aW5nIH4wVS4KPgo+IENjOiBtYXJ0aW4ucGVyZXNAZnJlZS5mcgo+IENjOiBjaHJpc0BjaHJpcy13 aWxzb24uY28udWsKPiBBY2tlZC1ieTogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiAo djEpCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIHwgMTggKysr KysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAyIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hl bHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBpbmRleCBiMDdm YzMwMzcyZDMuLjU0NTMyOGE5YTc2OSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jCj4gQEAgLTI3MjYsNiArMjcyNiw3IEBAIGludCBkcm1fYXRvbWljX2hlbHBlcl9kaXNhYmxl X2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJc3RydWN0IGRybV9wbGFuZSAqcGxhbmU7 Cj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gIAlzdHJ1Y3QgZHJtX2Ny dGMgKmNydGM7Cj4gKwl1bnNpZ25lZCBwbGFuZV9tYXNrID0gMDsKPiAgCWludCByZXQsIGk7Cj4g IAo+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKGRldik7Cj4gQEAgLTI3NjgsMTAg KzI3NjksMTQgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfYWxsKHN0cnVjdCBkcm1f ZGV2aWNlICpkZXYsCj4gIAkJCWdvdG8gZnJlZTsKPiAgCj4gIAkJZHJtX2F0b21pY19zZXRfZmJf Zm9yX3BsYW5lKHBsYW5lX3N0YXRlLCBOVUxMKTsKPiArCQlwbGFuZV9tYXNrIHw9IEJJVChkcm1f cGxhbmVfaW5kZXgocGxhbmUpKTsKPiArCQlwbGFuZS0+b2xkX2ZiID0gcGxhbmUtPmZiOwo+ICAJ fQo+ICAKPiAgCXJldCA9IGRybV9hdG9taWNfY29tbWl0KHN0YXRlKTsKPiAgZnJlZToKPiArCWlm IChwbGFuZV9tYXNrKQo+ICsJCWRybV9hdG9taWNfY2xlYW5fb2xkX2ZiKGRldiwgcGxhbmVfbWFz aywgcmV0KTsKPiAgCWRybV9hdG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiAgCXJldHVybiByZXQ7 Cj4gIH0KPiBAQCAtMjkwMiwxMSArMjkwNywxNiBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfY29t bWl0X2R1cGxpY2F0ZWRfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJ c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKm5ld19jb25uX3N0YXRlOwo+ICAJc3RydWN0IGRy bV9jcnRjICpjcnRjOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsK PiArCXVuc2lnbmVkIHBsYW5lX21hc2sgPSAwOwo+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9 IHN0YXRlLT5kZXY7Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGN0 eDsKPiAgCj4gLQlmb3JfZWFjaF9uZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBsYW5lLCBuZXdf cGxhbmVfc3RhdGUsIGkpCj4gKwlmb3JfZWFjaF9uZXdfcGxhbmVfaW5fc3RhdGUoc3RhdGUsIHBs YW5lLCBuZXdfcGxhbmVfc3RhdGUsIGkpIHsKPiArCQlwbGFuZV9tYXNrIHw9IEJJVChkcm1fcGxh bmVfaW5kZXgocGxhbmUpKTsKV2Ugc2hvdWxkIHJlYWxseSBhZGQgYSBkcm1fcGxhbmVfbWFzay9k cm1fY29ubmVjdG9yX21hc2sgYXQgc29tZSBwb2ludCwgdG8gY29tcGxlbWVudCBkcm1fY3J0Y19t YXNrLgo+ICAJCXN0YXRlLT5wbGFuZXNbaV0ub2xkX3N0YXRlID0gcGxhbmUtPnN0YXRlOwo+ICsJ fQo+ICAKPiAgCWZvcl9lYWNoX25ld19jcnRjX2luX3N0YXRlKHN0YXRlLCBjcnRjLCBuZXdfY3J0 Y19zdGF0ZSwgaSkKPiAgCQlzdGF0ZS0+Y3J0Y3NbaV0ub2xkX3N0YXRlID0gY3J0Yy0+c3RhdGU7 Cj4gQEAgLTI5MTQsNyArMjkyNCwxMSBAQCBpbnQgZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X2R1 cGxpY2F0ZWRfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ICAJZm9yX2Vh Y2hfbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yLCBuZXdfY29ubl9zdGF0 ZSwgaSkKPiAgCQlzdGF0ZS0+Y29ubmVjdG9yc1tpXS5vbGRfc3RhdGUgPSBjb25uZWN0b3ItPnN0 YXRlOwo+ICAKPiAtCXJldHVybiBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gKwlyZXQgPSBk cm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gKwlpZiAocGxhbmVfbWFzaykKPiArCQlkcm1fYXRv bWljX2NsZWFuX29sZF9mYihkZXYsIHBsYW5lX21hc2ssIHJldCk7CktpbGwgdGhlIGlmICgpIHBh cnQsIGFuZCBtYWtlIGl0IHVuY29uZGl0aW9uYWw/IE9uIHNlY29uZCB0aG91Z2h0LCBJIHNob3Vs ZCBoYXZlIGRvbmUgdGhlIHNhbWUgaW4gZHJtX2ZyYW1lYnVmZmVyLmMKPiArCXJldHVybiByZXQ7 Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfZHVwbGljYXRl ZF9zdGF0ZSk7Cj4gIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=