From: "plaisthos (Code Review)"
Date: Tue, 2 Jan 2024 11:35:14 +0000
In-Reply-To:
References:
Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net,
frank@...2641..., gert@...1296...
Message-ID: <993b1dc159d510f5d2856540c755788b22e23584-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="WRmBWhaOWDg="; charset=UTF-8
Subject: [Openvpn-devel] [L] Change in openvpn[master]: Add test_ssl unit
test and test export of PEM to file
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Cc: cron2 , flichtenheld , openvpn-devel
--WRmBWhaOWDg=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: cron2.
plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c=
/openvpn/+/471?usp=3Demail )
Change subject: Add test_ssl unit test and test export of PEM to file
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> this fails the GHA mingw builds with [=E2=80=A6]
That is really strange. test_ssl.c includes ssl_verify_backend.h that defin=
es that function. I need to see if I can reproduce this.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/471?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ie248d35d063bb6878f3dd42840c77ba0d6fa3381
Gerrit-Change-Number: 471
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld
Gerrit-CC: openvpn-devel
Gerrit-Attention: cron2
Gerrit-Comment-Date: Tue, 02 Jan 2024 11:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2
Gerrit-MessageType: comment
--WRmBWhaOWDg=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable