From: David Heidelberger Subject: Re: [PATCH RFC] =?UTF-8?Q?fs/binfmt=5Felf=3A=20fix=20memory=20map?= =?UTF-8?Q?=20for=20PIE=20applications?= Date: Sat, 08 Mar 2014 23:44:16 +0100 Message-ID: <995e798d77277927e7c8b0a0dff42b44@ixit.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: linux-fsdevel@vger.kernel.org Return-path: Received: from 124-84-246-161.wendulka.net ([84.246.161.124]:47533 "EHLO ixit.cz" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751130AbaCHVvq (ORCPT ); Sat, 8 Mar 2014 16:51:46 -0500 Received: from localhost (localhost [127.0.0.1]) by ixit.cz (Postfix) with ESMTP id 42E06126EA2 for ; Sat, 8 Mar 2014 23:44:17 +0100 (CET) Received: from ixit.cz ([127.0.0.1]) by localhost (ixit.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fjpj232Felyr for ; Sat, 8 Mar 2014 23:44:16 +0100 (CET) Received: from iXit?Group (localhost [127.0.0.1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ixit.cz (Postfix) with ESMTPSA id 1EC5A126E9D for ; Sat, 8 Mar 2014 23:44:16 +0100 (CET) Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > Hmm, that's really unfortunate. Applications really should be prepared > for > failing brk(), as there is no guarantee provided by anyobody whatsoever > about the space allocated for the program break. > > Heck, even my manpage tells me: > > "Avoid using brk() and sbrk(): the malloc(3) memory allocation package > is > the portable and comfortable way of allocating memory." > > -- > Jiri Kosina > SUSE Labs Hello Jiri, I slightly looked at patch, does it have any drawbacks? If I understand correctly, this simply fix could avoid bloat from musl-libc and should be better way than actual status. Is there any reason to not include this patch? Thank you David