Message-ID: <9963b338-ae7c-b786-babc-4f1d005dfff6@...1227...> Date: Mon, 22 May 2023 12:11:07 +0200 MIME-Version: 1.0 References: <20230517110230.2234266-1-arne@...1227...> <20230517110230.2234266-2-arne@...1227...> Content-Language: en-GB From: Arne Schwabe In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH 2/2] Fix CR_RESPONSE mangaement message using wrong key_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Selva Nair Cc: openvpn-devel@lists.sourceforge.net Am 19.05.23 um 15:45 schrieb Selva Nair: > Hi, > > While this bugfix should be merged, I'm a conflicted about the way these > two patches are split up. It just makes reviewing harder than it should > be. They actually form two independent changes but with one half > intersecting with the other for no reason. Yeah. I moved the logging to 1/2. It seems to fit much better in that patch. Arne