From: Alexander Zubkov Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Date: Tue, 27 Mar 2018 19:33:28 +0200 Message-ID: <998171522172008@web36j.yandex.ru> References: <20180312210301.12757-1-stephen@networkplumber.org> <1520890670.31389.1.camel@debian.org> <3677951520930804@web6j.yandex.ru> <1084221520939138@web32g.yandex.ru> <1520942521.12414.1.camel@debian.org> <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru> <135881521017992@web3o.yandex.ru> <2ee0179a-79c8-8504-afe1-6310ed4e858b@msu.ru> <20180327090135.7d60b796@xeon-e3> <606551522168171@web35g.yandex.ru> <20180327100014.466e3f8b@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Serhey Popovych , Luca Boccassi , "netdev@vger.kernel.org" To: Stephen Hemminger Return-path: Received: from forward3j.cmail.yandex.net ([5.255.227.21]:44458 "EHLO forward3j.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752123AbeC0RlY (ORCPT ); Tue, 27 Mar 2018 13:41:24 -0400 In-Reply-To: <20180327100014.466e3f8b@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: master before merging revert + my recent patch (1) should work. Or you mean to prepare patch to change new master to desired state? I can do it. 1) https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/patch/?id=7696f1097f79be2ce5984a8a16103fd17391cac2 27.03.2018, 19:00, "Stephen Hemminger" : > On Tue, 27 Mar 2018 18:29:31 +0200 > Alexander Zubkov wrote: > >>  Hi Stephen, >> >>  Looks like the new patch was applied after the revert of original patch and fix patch for 4.15 branch. Which is not correct and I did not test it. This is how patches were designed: >>  1) your revert patch - rolls back 4.15 branch to old behaviour by reverting the original patch >>  2) my patch for 4.15 - fixes problem is 4.15 branch, it does not require revert patch, it is an alternative solution for the problem, it is designed solely for version 4.15 >>  3) my patch for master - fixes problem, it requires neither revert patch nor my patch for 4.15, it is standalone patch designed to do things right in master branch >> >>  27.03.2018, 18:01, "Stephen Hemminger" : >>  > On Wed, 14 Mar 2018 21:26:40 +0100 >>  > Alexander Zubkov wrote: >>  > >>  >>  Hello, >>  >> >>  >>  For example, it can be fixed in such way (patch is below): >>  >>  - split handling of default and all/any >>  >>  - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default >>  >>  - and AF_UNSPEC for all/any >>  >>  In this case "ip route show default" shows only default route and "ip >>  >>  route show all" shows all routes. And both also work when family (-4 or >>  >>  -6) is specified. >>  >>  Serhey, does it goes in line with what you wanted to achieve? Because I >>  >>  do not know - may be there are reasons why all/any should be provided >>  >>  with specific family. If you think this solution is suitable, I'll do >>  >>  some additional tests and package the patch in a proper way for this >>  >>  mailing list. >>  >>  And I'm unsure if check for AF_DECnet and AF_MPLS should be kept in both >>  >>  branches. May be someone have some additional thoughts on that? >>  > >>  > I applied this to master. >>  > >>  > We can work on the other cases after that. > > Please send the update back to what works.