From: Simon Rozman Date: Wed, 20 Nov 2019 10:35:32 +0000 Message-ID: <99D61A626FDA8A4B90A270669121BE10C9AF9896@...2294...> References: <1573148729-27339-1-git-send-email-lstipakov@...277...> <1573148729-27339-4-git-send-email-lstipakov@...277...> In-Reply-To: Content-Language: en-US Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=2.16.840.1.101.3.4.2.1; boundary="----=_NextPart_000_001D_01D59F96.9D45DD50" MIME-Version: 1.0 Subject: Re: [Openvpn-devel] [PATCH v2 3/7] wintun: implement opening wintun device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Selva Nair , Lev Stipakov Cc: Lev Stipakov , openvpn-devel ------=_NextPart_000_001D_01D59F96.9D45DD50 Content-Type: multipart/alternative; boundary="----=_NextPart_001_001E_01D59F96.9D45DD50" ------=_NextPart_001_001E_01D59F96.9D45DD50 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, =20 The Wintun doesn't create its own communication I/O device. Running a separ= ate NdisRegisterDeviceEx() device came with a big can of worms, so we decid= ed not to run our own, but rather piggy-back on the existing NDIS one from = the NdisMRegisterMiniportDriver() that we tap on. Technically, we could lim= it it to a single client handle, but this device is primarily used by Windo= ws to manage the adapter, therefore we must not tweak it in this direction. =20 As Lev said: Wintun adds an IOCTL call to register ring buffers and it is t= his IOCTL that has a refcounting implemented to deny secondary connection a= ttempts. Unfortunately for OpenVPN, this IOCTL is restricted to privileged = processes only. You cannot use it to detect which Wintun adapters are in us= e by an unprivileged openvpn.exe process. WireGuard is very strict about wh= ich TUN adapter it will use =E2=80=93 it will never ever use a lottery to p= ick one. =20 We have more options here: =20 A. Wintun adapter can be explicitly chosen by configuration only (by name o= r GUID). With tapctl.exe utility users can make an adapter with predefined = name and put this name into .ovpn. If the Wintun adapter is not specified e= xplicitly =3D> configuration error. Less lottery; predictable tunnel-adapte= r mapping when running multiple tunnels; disturbed users because there is a= n inconsistency between TAP-Windows6 and Wintun adapter selection logic. B. The tapctl.exe code is in OpenVPN repo already and could be integrated i= n openvpn.exe and interactive service to create Wintun adapter on demand. B= ut, you have to take responsibility to clean what you have created. Pretty = much the same as A), but nicer for user. In the long term, I'd suggest this= "create adapter if doesn't exist" approach even for TAP-Windows6 adapters. C. Use adapter media state to see if particular Wintun adapter is already i= n use or not. Mind that registering buffer also sets MediaConnectStateConne= cted, and stays connected until its client closes handle or dies. This allo= ws OpenVPN to extend its "use first available adapter" approach to Wintun a= dapters. =20 Best regards, Simon =20 From: Selva Nair =20 Sent: Tuesday, November 19, 2019 7:03 PM To: Lev Stipakov Cc: Lev Stipakov ; openvpn-devel Subject: Re: [Openvpn-devel] [PATCH v2 3/7] wintun: implement opening wintu= n device =20 Hi Lev, =20 On Tue, Nov 19, 2019 at 12:23 PM Lev Stipakov > wrote: Hi, =20 Apart from the error message, there is a larger issue especially when we us= e iservice. In that case, we have to preserve privilege separation and allo= wing a user to open a device handle in use by another has to be avoided. =20 Do you see it as a security issue when handle can be opened by another proc= ess? =20 I don't know the internals of wintun to know that for sure.=20 =20=20 =20 To read / write to tunnel one needs to register ring buffers, and this call= will fail for any other process. Am I missing something here? =20 Hopefully, Simon can confirm whether that provides a sufficient safety net. =20 Selva ------=_NextPart_001_001E_01D59F96.9D45DD50 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable

Hi,

 = ;

The Wintun doesn't create its own communication I/O dev= ice. Running a separate NdisRegisterDeviceEx() device came with a big can o= f worms, so we decided not to run our own, but rather piggy-back on the exi= sting NDIS one from the NdisMRegisterMiniportDriver() that we tap on. Techn= ically, we could limit it to a single client handle, but this device is pri= marily used by Windows to manage the adapter, therefore we must not tweak i= t in this direction.

 

<= p class=3DMsoNormal>As Lev said: Wintun adds an IOCTL call to register ring buffers and it is = this IOCTL that has a refcounting implemented to deny secondary connection = attempts. Unfortunately for OpenVPN, this IOCTL is restricted to privileged= processes only. You cannot use it to detect which Wintun adapters are in u= se by an unprivileged openvpn.exe process. WireGuard is very strict about w= hich TUN adapter it will use =E2=80=93 it will never ever use a lottery to = pick one.

 

We have more= options here:

 

  1. Wintun adapter can be explicitly chosen by config= uration only (by name or GUID). With tapctl.exe utility users can make an a= dapter with predefined name and put this name into .ovpn. If the Wintun ada= pter is not specified explicitly =3D> configuration error. Less lottery;= predictable tunnel-adapter mapping when running multiple tunnels; disturbe= d users because there is an inconsistency between TAP-Windows6 and Wintun a= dapter selection logic.
  2. The tapctl.exe code is in OpenVPN repo alre= ady and could be integrated in openvpn.exe and interactive service to creat= e Wintun adapter on demand. But, you have to take responsibility to clean w= hat you have created. Pretty much the same as A), but nicer for user. In th= e long term, I'd suggest this "create adapter if doesn't exist" a= pproach even for TAP-Windows6 adapters.
  3. Use adapter media state to s= ee if particular Wintun adapter is already in use or not. Mind that registe= ring buffer also sets MediaConnectStateConnected, and stays connected until= its client closes handle or dies. This allows OpenVPN to extend its "= use first available adapter" approach to Wintun adapters.

 

Best regards,

Simon

 

=

From: Selva Nair <selva.nair@...277...>
Sent: Tuesday, Novem= ber 19, 2019 7:03 PM
To: Lev Stipakov <lstipakov@...277...>=
Cc: Lev Stipakov <lev@...515...>; openvpn-devel <openvp= n-devel@lists.sourceforge.net>
Subject: Re: [Openvpn-devel] [P= ATCH v2 3/7] wintun: implement opening wintun device

<= /div>

 

Hi Lev,

 =

On Tue, Nov 19, 2019 at 12:23 PM Lev Sti= pakov <lstipako= v@...277...> wrote:

Hi,<= /p>

 

Apart from the error message, there is a larger issue especially when = we use iservice. In that case, we have to preserve privilege separation and= allowing a user to open a device handle in use by another has to be avoide= d.

<= o:p> 

Do you see it as a secu= rity issue when handle can be opened by another process?

 

I don't know the internals of wintun t= o know that for sure.

 =

<= div>

 

To read / write to tunnel one needs to register ring buff= ers, and this call will fail for any other process. Am I missing somet= hing here?

 

Hopefully= , Simon can confirm whether that provides a sufficient safety net.

 

Selva

= ------=_NextPart_001_001E_01D59F96.9D45DD50-- ------=_NextPart_000_001D_01D59F96.9D45DD50 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCCD9Qw ggSKMIIC8qADAgECAg0AkK53dgAAAABXHdBvMA0GCSqGSIb3DQEBCwUAMFwxCzAJBgNVBAYTAlNJ MRwwGgYDVQQKExNSZXB1Ymxpa2EgU2xvdmVuaWphMRcwFQYDVQRhEw5WQVRTSS0xNzY1OTk1NzEW MBQGA1UEAxMNU0ktVFJVU1QgUm9vdDAeFw0xNjA0MjUwNzM4MTdaFw0zNzEyMjUwODA4MTdaMFwx CzAJBgNVBAYTAlNJMRwwGgYDVQQKExNSZXB1Ymxpa2EgU2xvdmVuaWphMRcwFQYDVQRhEw5WQVRT SS0xNzY1OTk1NzEWMBQGA1UEAxMNU0ktVFJVU1QgUm9vdDCCAaIwDQYJKoZIhvcNAQEBBQADggGP ADCCAYoCggGBANPLnC3C4DBDZTEk/0uwONmpU9c10du3S5O0co3xy5XSUyt0mzKapC8+Agbdr3AV oarPEYeKZnvLzB1wRFyPrMrmw1sntI2jjhC/blR0CHCKI+jKx3TEZpEg3UvopYR1pZiVgosb4SAk B0arDGU2QGeLde6p2ZEpG+1vLUXC1uJgAbHzTjkrO28/hb4I9lMre6LJRaFEgYBmmmA6G8S+DMww EH8RNjhK5puhllOclMwRxgRMolVL/4Dhr4wcNfy5kzff+V093OsNJ2xEyVlmK1Zv/wQb9/Vpw13D GP69p9lkL6KfYNlybD08dfIlJ5guOrjJ3U11vauwImFYATcopiCdLmBc+5C8RkO4/m3YwGYiJGs0 eCLlueJY6Ug47ky9AXtuPkDq0cIKQpNnwyYvPwdbz6/jHeg64mXhhJE/9WYA/aozRkLsFj7SE2Uv DglT9uQqdRScGTMWmkXh21fPzzjUp/ftWEPkDphcxOAxP5Skb0tKotVKjSapHWQlCDUN5wIDAQAB o0swSTAPBgNVHRMBAf8EBTADAQH/MA4GA1UdDwEB/wQEAwIBBjATBgNVHSMEDDAKgAhMo8NoXggC YzARBgNVHQ4ECgQITKPDaF4IAmMwDQYJKoZIhvcNAQELBQADggGBACYjhbtdQRlukoOK7gGLBDUZ f6uP3NYzwfl5ll4j9fDO3erbYTtar91Y6UKJQO/52WcRf03x7ekRe7FBD+2k0ha278H9i/YRKyzv /AcGRgzPAgvtO96PCbkzqyaAVERCZdfnr81QDsrIiKESnCqVOz5UPEhz9nx41Jv/k/dF5CmEY/z6 fhrnXOByV7AveB0wxhP9iF+xZYjaXpcTgXv+Hs97v1cwwXCSQ6aZ8FWfmMUjQr10HDGOEqXZRWoq WshYzb3W3T41Cxl/AxzOBw+HRZMVoWu9NBzg3vXUuOWRHEsFtScmvM/RCZgWxuHxVUs6e23exme2 wTctn6iOWce3psXv3xbi7d6yt/OiNqQoMjoKlMs/Xv5uWe26NrKT1sbDGf71mXjrR0flrUJ67Lx7 yS5BTk0PBA6KSzOH3PF2fFoYjJwKEteis8KFh65tMVBiMiGgaBZflDV0VSnScYEISuHXXapUAbMb fFmuvqwMyrhAZGdbneoGBhHW0DBzHuO8KzCCBVkwggRBoAMCAQICBDtKDS4wDQYJKoZIhvcNAQEF BQAwPTELMAkGA1UEBhMCc2kxGzAZBgNVBAoTEnN0YXRlLWluc3RpdHV0aW9uczERMA8GA1UECxMI c2lnZW4tY2EwHhcNMTYwMjE5MTc1NDQxWhcNMjEwMjE5MjEzODE1WjCBgDELMAkGA1UEBhMCU0kx GzAZBgNVBAoTEnN0YXRlLWluc3RpdHV0aW9uczERMA8GA1UECxMIc2lnZW4tY2ExFDASBgNVBAsT C2luZGl2aWR1YWxzMSswEwYDVQQDEwxTaW1vbiBSb3ptYW4wFAYDVQQFEw0yMzQ1Njc5NTEyMDQy MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA/ixFbpZjenz5GnanvNlfDNca0OdgWBg5 GsalcP7RMGpaShIjEegzvFXwqZI49SmuSRKFNtUq5tTBYOk5KLfW/MpBwBhFhmpAUQUoCRgQUAKo jvJJ47ULqIV0gBXlFoyzHwN5jmRvKyWxqwsoN/RZptY3ns1mLgf+7Nsa6iu0rXPxsyIXqrGBND8N RYarRAgOdibs6CLTl9+vHd9bTfztcp5B+xdE18uPBhZ3JquWInd3d0FTpNakAuvJaCC8EkpCwOcT leph8/15QAG/43zS37CMsU9UTuPqz5TrpU2FXsf238ZWyhlzeKnyv6POExal1tXWw1Cu40vT8zMb YVqU3wIDAQABo4ICGzCCAhcwDgYDVR0PAQH/BAQDAgWgMEsGA1UdIAREMEIwNgYLKwYBBAGvWQIC AwMwJzAlBggrBgEFBQcCARYZaHR0cDovL3d3dy5jYS5nb3Yuc2kvY3BzLzAIBgYEAIswAQIwGAYI KwYBBQUHAQMEDDAKMAgGBgQAjkYBATAaBgNVHREEEzARgQ9zaW1vbkByb3ptYW4uc2kwge4GA1Ud HwSB5jCB4zBWoFSgUqRQME4xCzAJBgNVBAYTAnNpMRswGQYDVQQKExJzdGF0ZS1pbnN0aXR1dGlv bnMxETAPBgNVBAsTCHNpZ2VuLWNhMQ8wDQYDVQQDEwZDUkw0NTUwgYiggYWggYKGV2xkYXA6Ly94 NTAwLmdvdi5zaS9vdT1zaWdlbi1jYSxvPXN0YXRlLWluc3RpdHV0aW9ucyxjPXNpP2NlcnRpZmlj YXRlUmV2b2NhdGlvbkxpc3Q/YmFzZYYnaHR0cDovL3d3dy5zaWdlbi1jYS5zaS9jcmwvc2lnZW4t Y2EuY3JsMCsGA1UdEAQkMCKADzIwMTYwMjE5MTc1NDQxWoEPMjAyMTAyMTkyMTM4MTVaMB8GA1Ud IwQYMBaAFHF7igYfMQVVq2ASd0cgHgOIGOyJMB0GA1UdDgQWBBS7/7AHyQYI0e8GOPmwTc1ZTNw5 lzAJBgNVHRMEAjAAMBkGCSqGSIb2fQdBAAQMMAobBFY4LjEDAgOoMA0GCSqGSIb3DQEBBQUAA4IB AQBBUL4KG1Z1oBIIdKIZs9yJxnJg/LfEPVvzNH8+CCqegq0D6k48Doo72oVEiskjqggdbUGj30uA H8PjCD5kLGVoDwh5a2atQ3qQzaYA/lj2Js2f4fdXNn60vRp7XzbGsQdwYYecIrKzO5x6XVAIRb+T HZNjXL3VX6vOozwBQv/+dx1P9H/rMUn7d8ci7v4PeqShbWbWwi6ez19cZvSKSkz/lWf4tj8QbA0n WeUBlk3Bx6/TRda7kwXzcFExt+ROGt0YJjbZCN3kd7swcRvRT6gEi9L6n1XLghwPSYhzZjaL5fXv I11JuSoQCy13XWBkq35Moo4iY19wanS1W6UM8Yq0MIIF5TCCBE2gAwIBAgINAKZovVEAAAAAVx3Q 6DANBgkqhkiG9w0BAQsFADBcMQswCQYDVQQGEwJTSTEcMBoGA1UEChMTUmVwdWJsaWthIFNsb3Zl bmlqYTEXMBUGA1UEYRMOVkFUU0ktMTc2NTk5NTcxFjAUBgNVBAMTDVNJLVRSVVNUIFJvb3QwHhcN MTYwNTI0MTE1ODI3WhcNMjEwNjI3MjIwMDAwWjA9MQswCQYDVQQGEwJzaTEbMBkGA1UEChMSc3Rh dGUtaW5zdGl0dXRpb25zMREwDwYDVQQLEwhzaWdlbi1jYTCCASIwDQYJKoZIhvcNAQEBBQADggEP ADCCAQoCggEBALDlZbLArGSW8ogbs+2e5ALGTyuIzi6KUYB1rxBb8ss4ZpuiDm00R5alkhGv9jVH onciDM4WiGKq00luGLwuRNi+xp7CGhmsQY78MAcC8sZq1FsjAO9BNNikc2PfIpIzhAGljfODXPq4 1Ho13+z4bQ/gTO2tnDp9htalCJS+fXoRH/6FP1RaiGOHnKWxp07Nt0Rzr8+KSWsf483XSU1aKxfm XHazu3K5byfSm4kViN8QX3YhAWrHFTEK0ZxY+CgWBW3ZTtmh1wcgy0smiU2Ssqe6lujjWI8inAGW WsT3MU0LSbXheGHiVBgGu55UNH4MPuvutYAf3RaEHWg4Zmdz+JECAwEAAaOCAkMwggI/MBIGA1Ud EwEB/wQIMAYBAf8CAQAwDgYDVR0PAQH/BAQDAgEGMDoGA1UdIAQzMDEwLwYEVR0gADAnMCUGCCsG AQUFBwIBFhlodHRwOi8vd3d3LmNhLmdvdi5zaS9jcHMvMGkGCCsGAQUFBwEBBF0wWzA2BggrBgEF BQcwAoYqaHR0cDovL3d3dy5jYS5nb3Yuc2kvY3J0L3NpLXRydXN0LXJvb3QuY3J0MCEGCCsGAQUF BzABhhVodHRwOi8vb2NzcC5jYS5nb3Yuc2kwHQYDVR0OBBYEFHF7igYfMQVVq2ASd0cgHgOIGOyJ MIIBPAYDVR0fBIIBMzCCAS8wgbeggbSggbGGKmh0dHA6Ly93d3cuY2EuZ292LnNpL2NybC9zaS10 cnVzdC1yb290LmNybIaBgmxkYXA6Ly94NTAwLmdvdi5zaS9jbj1TSS1UUlVTVCUyMFJvb3Qsb3Jn YW5pemF0aW9uSWRlbnRpZmllcj1WQVRTSS0xNzY1OTk1NyxvPVJlcHVibGlrYSUyMFNsb3Zlbmlq YSxjPVNJP2NlcnRpZmljYXRlUmV2b2NhdGlvbkxpc3Qwc6BxoG+kbTBrMQswCQYDVQQGEwJTSTEc MBoGA1UEChMTUmVwdWJsaWthIFNsb3ZlbmlqYTEXMBUGA1UEYRMOVkFUU0ktMTc2NTk5NTcxFjAU BgNVBAMTDVNJLVRSVVNUIFJvb3QxDTALBgNVBAMTBENSTDEwEwYDVR0jBAwwCoAITKPDaF4IAmMw DQYJKoZIhvcNAQELBQADggGBAHuvNSPhY4qcirWJkTwkqaOPqOSV06J/ZepFQfUEJ87TlrGjp4XR 5FLktTAEY/7R4Sgeb2K8OWEl/Koc1BbH6+uyZYvfa+WnnJEWeWOmyPy/vooO7eZyOVvaORxurWOL CCVDW2wBkbtUoKZaUyzgP+ZPPGRV8GFlbZLCzGmArMGXJXe8t/XNiJDLehGqSWT49NYjyYQdIgI+ qi9W+A6BSUQ9jsMdYJqKhXQcosfH51sc6gZVxTKMr3PsItsa8XFiNazECAAFr0ms7HB6zb8QvHRF eBGk/CLrW4VkZEBN/JtuyhvgktQ2BvuGtauEvHZQAYpMSh35D7pwtavRMpmhaAsQb4yPqhIMcztw RqsKPBhWoaFEVZ+Vn3wxap5h/oAhocifNzkWJTNWjxnoPM2eNz2uWFJsgsNhlwteUvnq7+bKTNte SKWKr6pI+GUsZhmCh5URpUnqUanp0Uie0MD9f3tiOLOp711sNb0xwi+VdDuDB37IddOIsfhPBood wpoFrTGCAyEwggMdAgEBMEUwPTELMAkGA1UEBhMCc2kxGzAZBgNVBAoTEnN0YXRlLWluc3RpdHV0 aW9uczERMA8GA1UECxMIc2lnZW4tY2ECBDtKDS4wDQYJYIZIAWUDBAIBBQCgggGtMBgGCSqGSIb3 DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE5MTEyMDEwMzUzMFowLwYJKoZIhvcN AQkEMSIEINSIQqhY2ep6+CVSgBJ/BBbkO9ANTOJowtyMu8NxspQcMFQGCSsGAQQBgjcQBDFHMEUw PTELMAkGA1UEBhMCc2kxGzAZBgNVBAoTEnN0YXRlLWluc3RpdHV0aW9uczERMA8GA1UECxMIc2ln ZW4tY2ECBDtKDS4wVgYLKoZIhvcNAQkQAgsxR6BFMD0xCzAJBgNVBAYTAnNpMRswGQYDVQQKExJz dGF0ZS1pbnN0aXR1dGlvbnMxETAPBgNVBAsTCHNpZ2VuLWNhAgQ7Sg0uMIGTBgkqhkiG9w0BCQ8x gYUwgYIwCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBFjAKBggqhkiG9w0DBzALBglghkgBZQMEAQIw DgYIKoZIhvcNAwICAgCAMA0GCCqGSIb3DQMCAgFAMAsGCWCGSAFlAwQCATALBglghkgBZQMEAgMw CwYJYIZIAWUDBAICMAcGBSsOAwIaMA0GCSqGSIb3DQEBAQUABIIBALF26U0LeTpfjTSeh7uv95/1 ThXAGGJQ22A9MPFQo07EcB3QmmTCdvjVY2xTLfVM+Mefix4AJxHePjIp1OoYLzd1bCRvgGfdsxSa t7o3MSUTTFtrNX8+6b16mIO2Q89KD/UrE3KplGGsI8QEqqy+emYBcrCUfGbwHJRi59EAiLksXzrO ExM0/MKKCLkmycPxwxBK/ZtEV2xIOaBsYR8AJeYbM7yyYFiYW+jQTBioQMNj0ZBKtfptIXsbSZM9 lC8jjtkODd+8YUSq2zJQmE8CrHOaBBirmweWxwweijm2I2uC8mqfjFU2DxE94HvPAeSSDDvnrkbC m8/w506wES4kRuUAAAAAAAA= ------=_NextPart_000_001D_01D59F96.9D45DD50--