From: "plaisthos (Code Review)" Date: Tue, 26 Aug 2025 11:59:57 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., max@...2606..., gert@...1296... Message-ID: <99c8e0da13b34693834e0784c665907f009b87aa-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="JXiClLQCFpg="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check message id/acked ids too when doing sessionid cookie checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: MaxF , flichtenheld , openvpn-devel --JXiClLQCFpg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/1067?usp=3Demail ) Change subject: Check message id/acked ids too when doing sessionid cookie = checks ...................................................................... Patch Set 7: (1 comment) File src/openvpn/mudp.c: http://gerrit.openvpn.net/c/openvpn/+/1067/comment/3a04bad5_1d964253 : PS5, Line 163: msg(D_MULTI_MEDIUM, "Packet (%s) with invalid or= missing SID from %s", : packet_opcode_name(op), peer); > This debug message may now be incorrect. The packet might have a valid SI= D, but a wrong packet ID. Acknowledged --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/1067?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I6752dcd5aff3e5cea2b439366479e86751a1c403 Gerrit-Change-Number: 1067 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos Gerrit-Reviewer: MaxF Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Comment-Date: Tue, 26 Aug 2025 11:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF Gerrit-MessageType: comment --JXiClLQCFpg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

View = Change

1 comment:

    =
  • File src/openvpn/mudp.c:

    • Patch Set #5, Line 163: =

                  msg(D_MULTI_MEDIUM, "Packet (%s) with invalid=
       or missing SID from %s",
      packet_opcode_name(op), p= eer);

      This debug message may now be i= ncorrect. The packet might have a valid SID, but a wrong packet ID.

      Acknowl= edged

To view, visit change 1067. To unsubscribe, or = for help writing mail filters, visit settings.

<= /div>
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6752dcd5aff3e5cea2b43936647= 9e86751a1c403
Gerrit-Change-Number: 1067
Gerrit-PatchSet: 7
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: MaxF <max@...2606...> <= /div>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Comment-Date: Tue, 26 Aug 2025 11:59:57= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: MaxF <max@...2606...&g= t;
Gerrit-MessageType: comment
--JXiClLQCFpg=--