Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80071C48BCD for ; Wed, 9 Jun 2021 14:36:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0792613B1 for ; Wed, 9 Jun 2021 14:36:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0792613B1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5892D6E043; Wed, 9 Jun 2021 14:36:03 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53D0F6E043; Wed, 9 Jun 2021 14:36:02 +0000 (UTC) IronPort-SDR: JahA67szNhEQhI7mLBJRQ711S4sv7VXg9IuE6+1OAAs2I8fuCEvLwr4FvHeTtUf3QwioXPV7PV xeDp/LMBDQIg== X-IronPort-AV: E=McAfee;i="6200,9189,10010"; a="192398689" X-IronPort-AV: E=Sophos;i="5.83,261,1616482800"; d="scan'208";a="192398689" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 07:36:01 -0700 IronPort-SDR: 0R4U09SPxWPlXMVSH+bECe2FMUnv0ojQFK4TD46vTKCwiv8DjByCB47VZSYJmdechvGLIMbaJq xuYBPbyehItA== X-IronPort-AV: E=Sophos;i="5.83,261,1616482800"; d="scan'208";a="635437702" Received: from agilev-mobl1.ccr.corp.intel.com (HELO [10.249.254.250]) ([10.249.254.250]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2021 07:35:59 -0700 Subject: Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= To: Matthew Auld , Daniel Vetter References: <20210609063436.284332-1-thomas.hellstrom@linux.intel.com> <9f38fc28-15fb-2736-ba01-503821fdbe54@linux.intel.com> <4d570a5b-0ea7-71ab-5082-e67f0cd668a7@intel.com> <1cd6b04d-8928-14b3-a63d-c9ac2e81fcca@linux.intel.com> Message-ID: <99ff0d9f-9bd4-c27d-45a5-a66d2ad9064f@linux.intel.com> Date: Wed, 9 Jun 2021 16:35:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1cd6b04d-8928-14b3-a63d-c9ac2e81fcca@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 6/9/21 3:08 PM, Thomas Hellström wrote: > > On 6/9/21 2:20 PM, Matthew Auld wrote: >> On 09/06/2021 13:16, Thomas Hellström wrote: >>> >>> On 6/9/21 1:48 PM, Daniel Vetter wrote: >>>> On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote: >>>>> A couple of patches from Chris which implement pipelined migration >>>>> and >>>>> clears by atomically writing the PTEs in place before performing the >>>>> actual blit. >>>>> >>>>> Some ww utilities mainly for the accompanying selftests added by >>>>> Thomas, >>>>> as well as modified the above patches for ww locking- and lmem >>>>> support. >>>>> >>>>> The actual hook up to the i915 ttm backend is being worked on and not >>>>> included yet, so this is considered to be an early review >>>>> opportunity. >>>>> >>>>> v2: >>>>> - A couple of minor style fixes pointed out by Matthew Auld >>>>> - Export and use intel_engine_destroy_pinned_context() to address a >>>>> ls   CI warning / failure. >>>> Just to check my understanding of the plan: These are the new windowed >>>> clear/blt functions which we plan to use everywhere, because less >>>> nasty >>>> locking implications? And the clear/blt we currently have in >>>> upstream will >>>> be replaced? >>> >>> Yes. These are for LMEM clearing and migration. It looks to me like >>> the other ones we have in upstream are actually unused except for >>> selftests. We're actually using CPU clearing for now. >>> >>>> >>>> If so would be nice if this patch set includes that replacement >>>> work (I >>>> think right now all we have is the clear for lmem), including >>>> updating of >>>> selftests and stuff like that. Just to avoid having two ways to do the >>>> same thing in the driver. >>> >>> OK, I'll have a look at stripping the existing code. If we need it >>> moving forward, we can always re-add. >> >> Some low hanging fruit would be all the client_blt stuff which can >> for sure be deleted now. > > What has the client_blt stuff been used for? > > In any case, I need 25 commits for commit access to be granted. > > /Thomas > > Series on trybot now. It's the dg1 live memory_region selftest that changes sligthly to use the new migration fill blt. /Thomas