From: Sagar Arun Kamble Subject: Re: [CI 1/2] drm/i915/guc: Fix null pointer dereference when GuC FW is not available Date: Fri, 23 Mar 2018 17:37:15 +0530 Message-ID: <9a45a8d4-0279-8cdb-ec28-7eb5dc167dff@intel.com> References: <20180323112319.16293-1-piotr.piorkowski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 904266E358 for ; Fri, 23 Mar 2018 12:07:20 +0000 (UTC) In-Reply-To: <20180323112319.16293-1-piotr.piorkowski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Piotr_Pi=c3=b3rkowski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAzLzIzLzIwMTggNDo1MyBQTSwgUGlvdHIgUGnDs3Jrb3dza2kgd3JvdGU6Cj4gSWYgR3VD IGZpcm13YXJlIGlzIG5vdCBhdmFpbGFibGUgb24gdGhlIHN5c3RlbSBhbmQgd2UgbG9hZCBpOTE1 IHdpdGggZW5hYmxlCj4gR3VDLCB0aGVuIHdlIGhpdCB0aGlzIG51bGwgcG9pbnRlciBkZXJlZmVy ZW5jZSBpc3N1ZToKUGF0Y2ggbG9va3MgZ29vZCBidXQgSSBoYXZlIHF1ZXJ5IG9uIHVzYWdlIG9m IGVuYWJsZV9ndWMgbW9kcGFyYW0uCmVuYWJsZV9ndWMgbW9kcGFyYW0gd2lsbCBlbmFibGUgR3VD L0h1QyBvbmx5IGlmIGZpcm13YXJlIGlzIGF2YWlsYWJsZS4KSWYgdXNlciBzZXRzIHRvIGZvcmNl ZnVsbHkgZW5hYmxlIEd1Qy9IdUMgb24gc3lzdGVtcyB0aGF0IGRvbid0IGhhdmUgCmZpcm13YXJl IHRoZW4gaXQgaXMgdXNlcidzIGZhdWx0LgpNaWNoYWwsIGNvdWxkIHlvdSBwbGVhc2UgY2xhcmlm eS4KClRoYW5rcywKU2FnYXIKPgo+IFsgICA3MS4wOTg4NzNdIEJVRzogdW5hYmxlIHRvIGhhbmRs ZSBrZXJuZWwgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIGF0IDAwMDAwMDAwMDAwMDAwMDgKPiBb ICAgNzEuMDk4OTM4XSBJUDogaW50ZWxfdWNfZndfdXBsb2FkKzB4MWYvMHgzNjAgW2k5MTVdCj4g WyAgIDcxLjA5ODk0N10gUEdEIDAgUDREIDAKPiBbICAgNzEuMDk4OTU2XSBPb3BzOiAwMDAwIFsj MV0gUFJFRU1QVCBTTVAgUFRJCj4gWyAgIDcxLjA5ODk2NV0gTW9kdWxlcyBsaW5rZWQgaW46IGk5 MTUoTyspIG5ldGNvbnNvbGUgeDg2X3BrZ190ZW1wX3RoZXJtYWwgaW50ZWxfcG93ZXJjbGFtcCBj b3JldGVtcCBjcmN0MTBkaWZfcGNsbXVsIGNyYzMyX3BjbG11bCBnaGFzaF9jbG11bG5pX2ludGVs IG1laV9tZSBpMmNfaTgwMSBwcmltZV9udW1iZXJzIG1laSBbbGFzdCB1bmxvYWRlZDogaTkxNV0K PiBbICAgNzEuMDk5MDA1XSBDUFU6IDIgUElEOiAxMTY3IENvbW06IGluc21vZCBUYWludGVkOiBH ICAgICBVICBXICBPICAgICA0LjE2LjAtcmMxKyAjMzM3Cj4gWyAgIDcxLjA5OTAxOF0gSGFyZHdh cmUgbmFtZTogL05VQzZpNVNZQiwgQklPUyBTWVNLTGkzNS44NkEuMDA2NS4yMDE4LjAxMDMuMTAw MCAwMS8wMy8yMDE4Cj4gWyAgIDcxLjA5OTA3N10gUklQOiAwMDEwOmludGVsX3VjX2Z3X3VwbG9h ZCsweDFmLzB4MzYwIFtpOTE1XQo+IFsgICA3MS4wOTkwODddIFJTUDogMDAxODpmZmZmYzkwMDAw NDE3YWEwIEVGTEFHUzogMDAwMTAyODIKPiBbICAgNzEuMDk5MDk3XSBSQVg6IDAwMDAwMDAwMDAw MDAwMDAgUkJYOiBmZmZmODgwODRjYWQxMmY4IFJDWDogZmZmZmZmZmZhMDNlOTM1Nwo+IFsgICA3 MS4wOTkxMDhdIFJEWDogMDAwMDAwMDAwMDAwMDAwMiBSU0k6IGZmZmZmZmZmYTAzNGRiYTAgUkRJ OiBmZmZmODgwODRjYWQxMmY4Cj4gWyAgIDcxLjA5OTExOF0gUkJQOiAwMDAwMDAwMDAwMDAwMDAy IFIwODogZmZmZjg4MDg1MzQ0Y2E5MCBSMDk6IDAwMDAwMDAwMDAwMDAwMDEKPiBbICAgNzEuMDk5 MTI4XSBSMTA6IDAwMDAwMDAwMDAwMDAwMDAgUjExOiAwMDAwMDAwMDAwMDAwMDAwIFIxMjogZmZm Zjg4MDg0Y2FkMDAwMAo+IFsgICA3MS4wOTkxMzldIFIxMzogZmZmZmZmZmZhMDM0ZGJhMCBSMTQ6 IDAwMDAwMDAwZmZmZmZmZjUgUjE1OiBmZmZmODgwODRjYWQxMmIwCj4gWyAgIDcxLjA5OTE1MV0g RlM6ICAwMDAwN2Y3ZjI0YWUyNzQwKDAwMDApIEdTOmZmZmY4ODA4NWUyMDAwMDAoMDAwMCkga25s R1M6MDAwMDAwMDAwMDAwMDAwMAo+IFsgICA3MS4wOTkxNjJdIENTOiAgMDAxMCBEUzogMDAwMCBF UzogMDAwMCBDUjA6IDAwMDAwMDAwODAwNTAwMzMKPiBbICAgNzEuMDk5MTcxXSBDUjI6IDAwMDAw MDAwMDAwMDAwMDggQ1IzOiAwMDAwMDAwODU1ZjQ4MDAxIENSNDogMDAwMDAwMDAwMDM2MDZlMAo+ IFsgICA3MS4wOTkxODJdIENhbGwgVHJhY2U6Cj4gWyAgIDcxLjA5OTI0Nl0gIGludGVsX3VjX2lu aXRfaHcrMHhjOC8weDUyMCBbaTkxNV0KPiBbICAgNzEuMDk5MzAzXSAgaTkxNV9nZW1faW5pdF9o dysweDExZi8weDJkMCBbaTkxNV0KPiBbICAgNzEuMDk5MzY0XSAgaTkxNV9nZW1faW5pdCsweDJi OS8weDY0MCBbaTkxNV0KPiBbICAgNzEuMDk5NDEzXSAgaTkxNV9kcml2ZXJfbG9hZCsweGI3NC8w eDExMTAgW2k5MTVdCj4gWyAgIDcxLjA5OTQ2Ml0gIGk5MTVfcGNpX3Byb2JlKzB4MmUvMHg5MCBb aTkxNV0KPiBbICAgNzEuMDk5NDc2XSAgcGNpX2RldmljZV9wcm9iZSsweGExLzB4MTMwCj4gWyAg IDcxLjA5OTQ4OF0gIGRyaXZlcl9wcm9iZV9kZXZpY2UrMHgzMDIvMHg0NzAKPiBbICAgNzEuMDk5 NTAyXSAgX19kcml2ZXJfYXR0YWNoKzB4YjkvMHhlMAo+IFsgICA3MS4wOTk1MTNdICA/IGRyaXZl cl9wcm9iZV9kZXZpY2UrMHg0NzAvMHg0NzAKPiBbICAgNzEuMDk5NTI1XSAgPyBkcml2ZXJfcHJv YmVfZGV2aWNlKzB4NDcwLzB4NDcwCj4gWyAgIDcxLjA5OTUzOF0gIGJ1c19mb3JfZWFjaF9kZXYr MHg2NC8weDkwCj4gWyAgIDcxLjA5OTU1MF0gIGJ1c19hZGRfZHJpdmVyKzB4MTY0LzB4MjYwCj4g WyAgIDcxLjA5OTU2MV0gID8gMHhmZmZmZmZmZmEwNGQ2MDAwCj4gWyAgIDcxLjA5OTU3Ml0gIGRy aXZlcl9yZWdpc3RlcisweDU3LzB4YzAKPiBbICAgNzEuMDk5NTgyXSAgPyAweGZmZmZmZmZmYTA0 ZDYwMDAKPiBbICAgNzEuMDk5NTkzXSAgZG9fb25lX2luaXRjYWxsKzB4M2IvMHgxNjAKPiBbICAg NzEuMDk5NjA2XSAgPyBrbWVtX2NhY2hlX2FsbG9jX3RyYWNlKzB4MWMzLzB4MmEwCj4gWyAgIDcx LjA5OTYyMV0gIGRvX2luaXRfbW9kdWxlKzB4NWIvMHgxZjkKPiBbICAgNzEuMDk5NjM1XSAgbG9h ZF9tb2R1bGUrMHgyNDY3LzB4MmE3MAo+IFsgICA3MS4wOTk2NTRdICA/IFN5U19maW5pdF9tb2R1 bGUrMHhiZC8weGUwCj4gWyAgIDcxLjA5OTY2OF0gIFN5U19maW5pdF9tb2R1bGUrMHhiZC8weGUw Cj4gWyAgIDcxLjA5OTY4Ml0gIGRvX3N5c2NhbGxfNjQrMHg3My8weDFjMAo+IFsgICA3MS4wOTk2 OTRdICBlbnRyeV9TWVNDQUxMXzY0X2FmdGVyX2h3ZnJhbWUrMHgyNi8weDliCj4gWyAgIDcxLjA5 OTcwNl0gUklQOiAwMDMzOjB4N2Y3ZjIzZmI0MGQ5Cj4gWyAgIDcxLjA5OTcxN10gUlNQOiAwMDJi OjAwMDA3ZmZkYTdkNjdlZDggRUZMQUdTOiAwMDAwMDI0NiBPUklHX1JBWDogMDAwMDAwMDAwMDAw MDEzOQo+IFsgICA3MS4wOTk3MzRdIFJBWDogZmZmZmZmZmZmZmZmZmZkYSBSQlg6IDAwMDA1NWY5 NmUyYTg4NzAgUkNYOiAwMDAwN2Y3ZjIzZmI0MGQ5Cj4gWyAgIDcxLjA5OTc0OF0gUkRYOiAwMDAw MDAwMDAwMDAwMDAwIFJTSTogMDAwMDU1Zjk2ZTJhODI2MCBSREk6IDAwMDAwMDAwMDAwMDAwMDMK PiBbICAgNzEuMDk5NzYzXSBSQlA6IDAwMDA1NWY5NmUyYTgyNjAgUjA4OiAwMDAwMDAwMDAwMDAw MDAwIFIwOTogMDAwMDdmZmRhN2Q2ODA4OAo+IFsgICA3MS4wOTk3NzddIFIxMDogMDAwMDAwMDAw MDAwMDAwMyBSMTE6IDAwMDAwMDAwMDAwMDAyNDYgUjEyOiAwMDAwMDAwMDAwMDAwMDAwCj4gWyAg IDcxLjA5OTc5MV0gUjEzOiAwMDAwNTVmOTZlMmE4ODMwIFIxNDogMDAwMDAwMDAwMDAwMDAwMCBS MTU6IDAwMDA1NWY5NmUyYTgyNjAKPiBbICAgNzEuMDk5ODEwXSBDb2RlOiAwMCAwMCA2NiAyZSAw ZiAxZiA4NCAwMCAwMCAwMCAwMCAwMCAwZiAxZiA0NCAwMCAwMCA0MSA1NSA0MSA1NCA0OSA4OSBm NSA1NSA1MyA0OCBjNyBjMSA1NyA5MyAzZSBhMCA0OCA4YiA0NyAxMCA0OCA4OSBmYiA0YyA4YiAw NyA8NDg+IDhiIDY4IDA4IDhiIDQ3IDI4IDg1IGMwIDc0IDE1IDgzIGY4IDAxIDQ4IGM3IGMxIDVi IDkzIDNlIGEwCj4gWyAgIDcxLjEwMDAwNF0gUklQOiBpbnRlbF91Y19md191cGxvYWQrMHgxZi8w eDM2MCBbaTkxNV0gUlNQOiBmZmZmYzkwMDAwNDE3YWEwCj4gWyAgIDcxLjEwMDAyMF0gQ1IyOiAw MDAwMDAwMDAwMDAwMDA4Cj4gWyAgIDcxLjEwMDAzMV0gLS0tWyBlbmQgdHJhY2UgZDhhYzkzYzMw Y2VmZjViMiBdLS0KPgo+IEZpeGVzOiA2YjA0NzhmYjcyMmEgKCJkcm0vaTkxNTogSW1wbGVtZW50 IGR5bmFtaWMgR3VDIFdPUENNIG9mZnNldCBhbmQgc2l6ZSBjYWxjdWxhdGlvbiIpCj4KPiB2Mjog ZG9uJ3QgYXNzdW1lIGl0IGlzIGFsd2F5cyBHdUMgRlcgKE1pY2hhbCkKPiB2MzogYWRkZWQgYSBu ZXcgdmFyaWFibGUgdG8gYXZvaWQgZXhjZWVkaW5nIHRoZSBudW1iZXIgb2YgY2hhcmFjdGVycyBp biB0aGUKPiBsaW5lIChNaWNoYWwpCj4KPiBTaWduZWQtb2ZmLWJ5OiBQaW90ciBQacOzcmtvd3Nr aSA8cGlvdHIucGlvcmtvd3NraUBpbnRlbC5jb20+Cj4gUmVwb3J0ZWQtYnk6IFJhZG9zbGF3IFN6 d2ljaHRlbmJlcmcgPHJhZG9zbGF3LnN6d2ljaHRlbmJlcmdAaW50ZWwuY29tPgo+IENjOiBNaWNo YcWCIFdpbmlhcnNraSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBX YWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBTYWdhciBBcnVuIEth bWJsZSA8c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpv b25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEphY2tpZSBMaSA8eWFvZG9uZy5s aUBpbnRlbC5jb20+Cj4gQ2M6IFJhZG9zbGF3IFN6d2ljaHRlbmJlcmcgPHJhZG9zbGF3LnN6d2lj aHRlbmJlcmdAaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBNaWNoYWwgV2FqZGVjemtvIDxtaWNo YWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogSmFja2llIExpIDx5YW9kb25n LmxpQGludGVsLmNvbT4KPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNf ZncuYyB8IDYgKysrLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRl bGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vj X2Z3LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5jCj4gaW5kZXggMzBjNzMy NDNmNTRkLi45M2IwZmM2NjFiM2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdWNfZncuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMK PiBAQCAtMTk5LDkgKzE5OSw5IEBAIGludCBpbnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVs X3VjX2Z3ICp1Y19mdywKPiAgIAkJICAgICAgIGludCAoKnhmZXIpKHN0cnVjdCBpbnRlbF91Y19m dyAqdWNfZncsCj4gICAJCQkJICAgc3RydWN0IGk5MTVfdm1hICp2bWEpKQo+ICAgewo+IC0Jc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSB0b19pOTE1KHVjX2Z3LT5vYmotPmJhc2UuZGV2 KTsKPiAgIAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiAgIAlpbnQgZXJyOwo+ICsJdTMyIGdndHRf cGluX2JpYXM7Cj4gICAKPiAgIAlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBsb2FkICVzXG4iLAo+ ICAgCQkJIGludGVsX3VjX2Z3X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksIHVjX2Z3LT5wYXRoKTsK PiBAQCAtMjIyLDkgKzIyMiw5IEBAIGludCBpbnRlbF91Y19md191cGxvYWQoc3RydWN0IGludGVs X3VjX2Z3ICp1Y19mdywKPiAgIAkJZ290byBmYWlsOwo+ICAgCX0KPiAgIAo+ICsJZ2d0dF9waW5f YmlhcyA9IHRvX2k5MTUodWNfZnctPm9iai0+YmFzZS5kZXYpLT5ndWMuZ2d0dF9waW5fYmlhczsK PiAgIAl2bWEgPSBpOTE1X2dlbV9vYmplY3RfZ2d0dF9waW4odWNfZnctPm9iaiwgTlVMTCwgMCwg MCwKPiAtCQkJCSAgICAgICBQSU5fT0ZGU0VUX0JJQVMgfAo+IC0JCQkJICAgICAgIGk5MTUtPmd1 Yy5nZ3R0X3Bpbl9iaWFzKTsKPiArCQkJCSAgICAgICBQSU5fT0ZGU0VUX0JJQVMgfCBnZ3R0X3Bp bl9iaWFzKTsKPiAgIAlpZiAoSVNfRVJSKHZtYSkpIHsKPiAgIAkJZXJyID0gUFRSX0VSUih2bWEp Owo+ICAgCQlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBnZ3R0LXBpbiBlcnI9JWRcbiIsCgotLSAK VGhhbmtzLApTYWdhcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==