Received: from fout-b8-smtp.messagingengine.com (fout-b8-smtp.messagingengine.com [202.12.124.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EF9420766B for ; Thu, 13 Feb 2025 07:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739431331; cv=none; b=ss9PV3qV4Dz6iJuLH3PnUpahTS/Q/XxNXK2j1d1vpl2tjJ6eJ2iiM/b3lJhoXRn3aB+HlQMx+QpDGWePjDaLPYWe7zI+y3VNGz3j3Dnns80a1MMyneWjiUQ0w9YA9Vrlrr0z40xN8MwnKUKzQ5xFfZa/sClv4RAcI/aNk/FzOf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739431331; c=relaxed/simple; bh=KelfrUEDKn1STr/uyl6Wn/gXFShtj7LS2NXx40teaXU=; h=Date:Message-ID:From:To:Cc:Subject; b=aLB8QSwiBc4sMzS3CCKEGNA0TUqzCSuuoGegZLGTDLz/GdUCYWj588DoI56Y5MlbRrmroUxjxoUt0t4p9IYgO2Xg6nDhFSjlUxp3amL0Etzy8npIE/nAbffSpwmQMZ5wZhMj4u5K+zR5pyeYLqjLsiQzMU86piNwVyI4G9b9olc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org; spf=none smtp.mailfrom=linux-m68k.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=NCnPkeyW; arc=none smtp.client-ip=202.12.124.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux-m68k.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="NCnPkeyW" Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfout.stl.internal (Postfix) with ESMTP id 50DA81140117; Thu, 13 Feb 2025 02:22:07 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 13 Feb 2025 02:22:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:reply-to:subject :subject:to:to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1739431327; x=1739517727; bh=2pmDU7e3MlYtu8haZn4roILPX83I 3ITd6BRmfCF1ljE=; b=NCnPkeyWuYqnLUVRRM/2BjjO/aut3wdSYbvmE/bmQayy 37FdRgRAigoARZJ7xuAsS62jXaSBezF08C7lg1BzXU1pnlW+fzGqVV7XZP9FGI0d f96YrvtplKc1v0u1OlvS2v/KhHLcxwFHtPjJnxyfazy7maYDMxBI/d3N+nI3Stry wNCB+OBBLIj7tFmvXhAcBKCYJr0BkDiQ6wbG2G8oOIdZhJ6HpTZBMdrstTh2TItE B0Uzmany2dUSvAmv46dLWfhbheutJnnLy8eHpDtmOwoQQMBtlBMn+E1d+zs2/fsZ YhEfa7vW1kDPncNuov1rYsRB5onE7nr8TqUC/KBojw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdegieduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpeffkffhvfevufestddtjhdttddttdenucfhrhho mhephfhinhhnucfvhhgrihhnuceofhhthhgrihhnsehlihhnuhigqdhmieekkhdrohhrgh eqnecuggftrfgrthhtvghrnhepiedugfduhffgheekjeekffduueejudevffehiedtledt tdekveekuefhvdfftedunecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehfthhhrghinheslhhi nhhugidqmheikehkrdhorhhgpdhnsggprhgtphhtthhopeehpdhmohguvgepshhmthhpoh huthdprhgtphhtthhopehulhhisehkvghrnhgvlhdrohhrghdprhgtphhtthhopehlihgr mhdrhhhofihlvghtthesohhrrggtlhgvrdgtohhmpdhrtghpthhtohepshgthhhmihhtii hmihgtsehgmhgrihhlrdgtohhmpdhrtghpthhtoheptghiphdquggvvheslhhishhtshdr tghiphdqphhrohhjvggtthdrohhrghdprhgtphhtthhopehlihhnuhigqdhmieekkheslh hishhtshdrlhhinhhugidqmheikehkrdhorhhg X-ME-Proxy: Feedback-ID: i58a146ae:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 13 Feb 2025 02:22:03 -0500 (EST) Date: Thu, 13 Feb 2025 18:21:56 +1100 Message-ID: <9a7bb5ad805dbb1c8a67186f04500474@linux-m68k.org> From: Finn Thain To: Ulrich Hecht Cc: Liam Howlett , Michael Schmitz , cip-dev@lists.cip-project.org, linux-m68k@lists.linux-m68k.org Subject: [PATCH 4.4.y-cip] m68k: Add missing mmap_read_lock() to sys_cacheflush() Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Liam Howlett [ Upstream commit f829b4b212a315b912cb23fd10aaf30534bb5ce9 ] When the superuser flushes the entire cache, the mmap_read_lock() is not taken, but mmap_read_unlock() is called. Add the missing mmap_read_lock() call. Fixes: cd2567b6850b1648 ("m68k: call find_vma with the mmap_sem held in sys_cacheflush()") Signed-off-by: Liam R. Howlett Reviewed-by: Matthew Wilcox (Oracle) Link: https://lore.kernel.org/r/20210407200032.764445-1-Liam.Howlett@Oracle.com Signed-off-by: Geert Uytterhoeven [ mmap_read_lock() open-coded using down_read() as was done prior to v5.8 ] Signed-off-by: Finn Thain --- arch/m68k/kernel/sys_m68k.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/m68k/kernel/sys_m68k.c b/arch/m68k/kernel/sys_m68k.c index 6363ec83a290..38dcc1a2097d 100644 --- a/arch/m68k/kernel/sys_m68k.c +++ b/arch/m68k/kernel/sys_m68k.c @@ -388,6 +388,8 @@ sys_cacheflush (unsigned long addr, int scope, int cache, unsigned long len) ret = -EPERM; if (!capable(CAP_SYS_ADMIN)) goto out; + + down_read(¤t->mm->mmap_sem); } else { struct vm_area_struct *vma;