Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF12EB64DC for ; Fri, 14 Jul 2023 23:14:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCCB46B0071; Fri, 14 Jul 2023 19:14:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B601E6B0072; Fri, 14 Jul 2023 19:14:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CE726B0074; Fri, 14 Jul 2023 19:14:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8890A6B0071 for ; Fri, 14 Jul 2023 19:14:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54DBB1603ED for ; Fri, 14 Jul 2023 23:14:30 +0000 (UTC) X-FDA: 81011773500.13.71A106C Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2076.outbound.protection.outlook.com [40.107.237.76]) by imf24.hostedemail.com (Postfix) with ESMTP id 251C5180003 for ; Fri, 14 Jul 2023 23:14:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=MyogqPdF; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.76 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689376467; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S+RaUFJ9WjY6mE7U0k2uCbCH1PRt63Mv/VsQEbl+Lxw=; b=Vg5P7u+s336QDR47kJ+WIlD0aIc9SdxFx7787PvkqFUrk3/cumnOLw1kboxUJGlXw3whY1 CsO8k642KwDxWSYL5nGKXQcFM3tMd3ZM9ubT1uDeo7BuAEfgW/aMm6InhutH6C3zi8Fbdc 8hdHsFHWj1TO0JCx24iGECKJGzT0d54= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=MyogqPdF; dmarc=pass (policy=reject) header.from=nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf24.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.237.76 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1689376467; a=rsa-sha256; cv=pass; b=lq2muHaUytIueyZUD0UzrR5RF/NyFBXxmsL10MrHjHTbP2SPvm1A/Xj1n2P/3lmg8WPQM7 IC4vZjk1uZsg57CEuZ9w65qh/boImzWee2oLxBbEIQ34j53X9vzRRFHZzlRHJkEVgnK2xD AeCynZQkt2eeUbdVN8k6Ug4Y3917qao= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oy+uJwisrettaHWGnT3/8Uu2eP/YL2eg5lKf0+w0ufZBgwjt7HNw4Hheu2e6CEMD1IaQMv1jRtWOnMXkDx59PC50M8uRrDWYvOc1ICd7hYFwbgpfpBjjgjuFwoFyyA2N/tnWHnaG0JXJhUhQQg5pBpmnc0vtiHuDci4K52Rz1in2rH0G3aUnWLxRHMLyFtF05RLF6FXsrOb0NuqoIzQm7KXqplKFk+1DlpVHKHKsfdqpuR6WPqTuBgIEzJoNkRP7qSnSC1ueOBnznsAzJQMyBtIPBMXT3FxmVYUMHrN/G+0YPcw6l9HLigRD+lb08RiwMntwgLmdusiU7T120tHwXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S+RaUFJ9WjY6mE7U0k2uCbCH1PRt63Mv/VsQEbl+Lxw=; b=Gsl49Q/ehqct5H4FmCd8oMaNTBxeahQY6XKDiwW3eYVhEd0YNvuLHAQUThI1xJkhXt6iRfsFQh5mipOgugvsu8/+S4aIsLLACohrjISBgbk0yXBWiJ+GR8MEzgTLA/ytMlTS//f+8M5Vv7YANUK+D3j2tf4mFeZonfvxf/ASmgj6WSAU1ndutQKhhq05Myx3rey/xrxpu2YkG+CovY6s8u3u0oNtjQ05AQXl9X8o4A3GPqiSEazMA3EKBkBX2erteSCRXM8/YGIpt4mlBDPRi40abonT+sYS6oLjY9fkrhw5eiE3IzE71xuFB9UKEUXo/fiXC/HPT0JsB93kGwubOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S+RaUFJ9WjY6mE7U0k2uCbCH1PRt63Mv/VsQEbl+Lxw=; b=MyogqPdFR4uadNWUuUtk9C+iKEebY3eNNAdZ4DAbf6kf7SNiCC2FTI820C/dQfUg+iMZ+MwFlARG8iBnnuuv14nMP8aUY+lkPJr7MoZuQIZi0r9rq/qrmj11UFq3we/u5qeaL3p4GJXjr4yCDre4/6pfMamz6fHSqBCsMtrTcpO1ikTfWMCEy8sycJApWsbWejgqyQxva2wn5zE116nJu4hAn/iv9uhhGSOuPMwaFBw1MreCJuyBOlOMQByQcwLL4jVk6cF4l8e35fsA/8OTPxWSCdq5pHn3hMZiwjG4Bo25VXSP33H78u5ViSb+V4rFMumAZjcO5wOp6/aqv/Ka1A== Received: from DS7PR03CA0326.namprd03.prod.outlook.com (2603:10b6:8:2b::28) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.28; Fri, 14 Jul 2023 23:14:24 +0000 Received: from DM6NAM11FT072.eop-nam11.prod.protection.outlook.com (2603:10b6:8:2b:cafe::28) by DS7PR03CA0326.outlook.office365.com (2603:10b6:8:2b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27 via Frontend Transport; Fri, 14 Jul 2023 23:14:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT072.mail.protection.outlook.com (10.13.173.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.28 via Frontend Transport; Fri, 14 Jul 2023 23:14:24 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 14 Jul 2023 16:14:13 -0700 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 14 Jul 2023 16:14:12 -0700 Message-ID: <9abc97e9-1dbc-7944-6232-070cd1cba5ea@nvidia.com> Date: Fri, 14 Jul 2023 16:14:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v3 3/7] mm/hotplug: Allow architecture to override memmap on memory support check Content-Language: en-US To: David Hildenbrand , Aneesh Kumar K V , , , , , , CC: Oscar Salvador , Michal Hocko , "Vishal Verma" References: <20230711044834.72809-1-aneesh.kumar@linux.ibm.com> <20230711044834.72809-4-aneesh.kumar@linux.ibm.com> <6f6764f6-4b5a-dfa8-c409-ba4f2828891f@redhat.com> <176cee16-f926-ab3b-92fe-98bebf79d43d@linux.ibm.com> <641a4276-cfb9-bd1b-36a8-cb4bcae408f6@redhat.com> <89d500a4-b639-bf00-ea65-6f2690c74867@nvidia.com> <5801c81e-cae4-2ba1-ec93-562fd8255423@redhat.com> From: John Hubbard In-Reply-To: <5801c81e-cae4-2ba1-ec93-562fd8255423@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT072:EE_|DM6PR12MB4108:EE_ X-MS-Office365-Filtering-Correlation-Id: ef56436c-ef60-4d72-00df-08db84c0107b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nGhIy2TuE4VM3UrEx7xAuunyrDeyaV7oM3I9vuqQKD6RUXTH1UnWyvY896d/+ffkpE/EViaeciYAp55NWG2dF5g9uoJO9iOZW6VnnWJsUUbAtmRXardnrF7eDIFYitvIFxZye3XzKTr6siiE6C8+pnbH6eoFRfN+V8xPrfAFeUSktJyc9oNj4j29+aqzxIbQquK4JcfP1GRrxpQ+KclPYt33uSNmtk6FLbwij4kKC5YBbCIYchzmFGwximey2tUD43VCrwj6F0IT3flio6ZJaTkYEvxhWL0NIhMyMG5n/xSh55WBpqt38nCn39WfQMRsoskxrmt3JngdCS6aIMlvEBaexm6lUdosrafqZH+Jj0lLwdfnFPPdYArVyHCsdl3MBvyDHt+bYfsBNFe98ISzTgAacoXCb4gekjkH5cy4u5FczYyvxLtGFg3i0seipI2iWEtVdEJPm/ZwSHfx+Kx0OE6PrYAs4ucpCgkOIi/GDBI8Gdc1Rt/laIc8htoaiQ4gD42OGs1WhRLFX0DvkkT2L/l0r1+rhyyf+KW508/fH2daq4NcvElakA8qmRJ+h+Qt67RHB9gY4tbVEfPly7lgxuHORkpNMj95hiJUf2QzYJ07TBOSHQb/U/SJv6qLlZ4QpCz/pYOt8d+thdm47IEaTvw2Ce2+MdWGQhTqEuCVjaPkmItgAFamq/tpVHiJkizZBXGvn/SjwKGQQmpb2jPbGLDm9Jpr4CrCOKpaGH8djP5BpG6L4FICwTyj8I3Opz2zX43s2iPvTSDd2YA2x1D7grRkVBiJFNmBT7sRI1V/oJ6CYqyad7XdaA5HLdCIeEel X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(396003)(136003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(31686004)(53546011)(356005)(7636003)(26005)(40460700003)(31696002)(478600001)(110136005)(54906003)(16576012)(7416002)(5660300002)(8936002)(8676002)(40480700001)(4326008)(70586007)(70206006)(966005)(86362001)(82310400005)(41300700001)(316002)(336012)(426003)(2616005)(16526019)(186003)(82740400003)(47076005)(36756003)(2906002)(83380400001)(36860700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 23:14:24.6578 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef56436c-ef60-4d72-00df-08db84c0107b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT072.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 251C5180003 X-Stat-Signature: g8gmu65ktwgpmmxayoiyp68s799bbzbk X-Rspam-User: X-HE-Tag: 1689376466-343032 X-HE-Meta: U2FsdGVkX18umqFqEaEbAJdNNahS4E/XzXEsFZDa79jLEGftml2AdEB9NuO5nUu55Qi3uw865j5lYMS/fsAuTIvul1FMLCI1Db8RVr7aSdMWVhmKamwOfktMxbbdJQt3gH9gP7WrcPPT1RlTCy0z+2F5mHnZeG6CkrnHzWpuzvbI+Uq78fe0wHUZWhrYWIrUvK/RfDNyctaK2I60BX5neRkVvwtDi4FY1TnV9NgvGoUm2xKBE9eE788PD7Pnw6J/2C2uN/oi0a6f2Gndaqg7xBf4WXKnOBp0yPl2ww6QbLd2kV5ZlAqciuzi+X+9HgVzCa5lhutdXwQ1ctntUFxSFkD94dbIry0C0ChxQPCOGlQ2GugKJIADJjAV2s8zeMvQzqaxJ1/dZ0zQcOOc1nQnNUiMfHhfZdvzVmDxHUtseCsUpOgaMZqHNo6Qoc9koBK/IlzwPP5e0p5NB6jtTLQWNzU/kxoIlJOpgIIOWumQMa8hJmfkGLoLiFYdNs1qAjaP+AJZrl1y2SBVyW9zogJzCZdyhM3YscugdMfqcc8oMNKX6UDfs3NhhcpxgBgwZ9e1SrVz2OqLKQJn67oxGgpTDDc7RrjBFnpGLqIQsSG6EK3rPtyMjx17x6JoduK48SQSovca7MF9VZ6lNHZulqee+DgQMBLF9bplzw1eGIMLLMGR/TBAfd6/cUN5h5IVCTbBDa2v/OdeX7iVAUm/2AECzx+ry7zZ3aeHRxiEy2ol8ErtPE8SFDQ4lys2Xlt43yJHHvsDSRHKBMlq86R8VNJ9OZKxB4FMDWEslFOyM0R9+EXfUqODFO48QrsNCYL8s9hOjui1BU8OGCHsN/b2jMjFG0PBvpT0A6kxsv1d5PwNf+SHPLDwoblumsfsevYjms4YkbC3ciprPxrwNpVD/+/LSO2l/T13UnGz7tv3CUIR/4a7YxguK2sI3sBwt8mUqiBPi7EnlmOL1g6K6/RDvyJ q5ox4zTX kQnLKhFF9XSJ6eAA7WBZ5GtzrwQaOAo1bs4fS6/hLeIrJQNgjLh/5SJJFfKKHoHWFNJAFusdMQPccnty3lH5RfRImgFpYYHgJR3kTVBMErEDW/BOeey/mDyAF9ud9alV4GC8YsmfqPTNqJwEiUnJcysw8Gn7ov+89136MXykbfaPI7RfzALIiWH3a232MJSO5eMa+dQZN6lxhavO4pf22TME2Owt+yXPQCwmyWbNAecs1+pdgIR9D62DvV90qtqkEvpShzJvGOmhhzZF8tmIMHKRlil+Qy5EPWfi7W2fxHn/vXm/rqtqTuAE0Qsz/vNSVUJERNf3K9XB5T3z6vj+EgnAMcggaTxOb7e4SP/XHWPDA3Dhq7UYtPSC2sLHEert8pSLH/3QfKpk7kYwbwhr5upnaGPJuY3PK0Lu+Y/4HkkXUACfRtidHh8dMHuoieLwoHn/pxizH3ibcJS+lKxNloj0FdgRG0aVZomg8+PJtEsnM2gwuSSevKGNpijxSdn6e8PxMoaj4fXDR75Vci+tsdc96Ad59FGDvsoP6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/13/23 02:08, David Hildenbrand wrote: ... >>     **WEAK_DECLARATION** >>       Using weak declarations like __attribute__((weak)) or __weak >>       can have unintended link defects.  Avoid using them. >> >> ...which seems deeply out of touch with how arch layers work these days, >> doesn't it? (This is not rhetorical; I'm asking in order to get an >> opinion or two on the topic.) > > Did some digging: > > commit 65d9a9a60fd71be964effb2e94747a6acb6e7015 > Author: Naveen N. Rao > Date:   Fri Jul 1 13:04:04 2022 +0530 > >     kexec_file: drop weak attribute from functions >     As requested >     (http://lkml.kernel.org/r/87ee0q7b92.fsf@email.froward.int.ebiederm.org), >     this series converts weak functions in kexec to use the #ifdef approach. >     Quoting the 3e35142ef99fe ("kexec_file: drop weak attribute from >     arch_kexec_apply_relocations[_add]") changelog: >     : Since commit d1bcae833b32f1 ("ELF: Don't generate unused section symbols") >     : [1], binutils (v2.36+) started dropping section symbols that it thought >     : were unused.  This isn't an issue in general, but with kexec_file.c, gcc >     : is placing kexec_arch_apply_relocations[_add] into a separate >     : .text.unlikely section and the section symbol ".text.unlikely" is being >     : dropped.  Due to this, recordmcount is unable to find a non-weak symbol in >     : .text.unlikely to generate a relocation record against. >     This patch (of 2); >     Drop __weak attribute from functions in kexec_file.c: >     - arch_kexec_kernel_image_probe() >     - arch_kimage_file_post_load_cleanup() >     - arch_kexec_kernel_image_load() >     - arch_kexec_locate_mem_hole() >     - arch_kexec_kernel_verify_sig() >     arch_kexec_kernel_image_load() calls into kexec_image_load_default(), so >     drop the static attribute for the latter. >     arch_kexec_kernel_verify_sig() is not overridden by any architecture, so >     drop the __weak attribute. >     Link: https://lkml.kernel.org/r/cover.1656659357.git.naveen.n.rao@linux.vnet.ibm.com >     Link: https://lkml.kernel.org/r/2cd7ca1fe4d6bb6ca38e3283c717878388ed6788.1656659357.git.naveen.n.rao@linux.vnet.ibm.com >     Signed-off-by: Naveen N. Rao >     Suggested-by: Eric Biederman >     Signed-off-by: Andrew Morton >     Signed-off-by: Mimi Zohar > > > So, in general, it's use seems to be fine (unless some tool actually bails out). > > https://lore.kernel.org/all/87ee0q7b92.fsf@email.froward.int.ebiederm.org/T/#u > > Also mentions that__weak and non __weak variants ending up in the vmlinux. Did not > check if that's actually (still) the case. > OK, I looked at that commit and the associated discussion, and now have a pretty clear picture of the preferred ways to do arch overrides. Thanks for taking the time to look into it, and also to explain it. Much appreciated! thanks, -- John Hubbard NVIDIA