From: Maarten Lankhorst Subject: Re: [PATCH 3/8] drm/i915/gen10: Calculate and enable transition WM Date: Wed, 9 Aug 2017 10:39:34 +0200 Message-ID: <9ac91376-2c8b-a7eb-3b53-20f268f2263e@linux.intel.com> References: <20170718124950.26675-1-mahesh1.kumar@intel.com> <20170718124950.26675-4-mahesh1.kumar@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 73A6D6E112 for ; Wed, 9 Aug 2017 08:39:37 +0000 (UTC) In-Reply-To: <20170718124950.26675-4-mahesh1.kumar@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Mahesh Kumar , intel-gfx@lists.freedesktop.org Cc: jani.nikula@intel.com, paulo.r.zanoni@intel.com, maarten.lankhorst@intel.com List-Id: intel-gfx@lists.freedesktop.org T3AgMTgtMDctMTcgb20gMTQ6NDkgc2NocmVlZiBNYWhlc2ggS3VtYXI6Cj4gRnJvbTogIkt1bWFy LCBNYWhlc2giIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPgo+IEdFTiA+IDkgcmVxdWlyZSB0 cmFuc2l0aW9uIFdNIHRvIGJlIHByb2dyYW1tZWQgaWYgSVBDIGlzIGVuYWJsZWQuCj4gVGhpcyBw YXRjaCBjYWxjdWxhdGVzICYgZW5hYmxlIHRyYW5zaXRpb24gV00gZm9yIHN1cHBvcnRlZCBwbGF0 Zm9ybXMuCj4gSWYgdHJhbnNpdGlvbiBXTSBpcyBlbmFibGVkLCBQbGFuZSByZWFkIHJlcXVlc3Rz IGFyZSBzZW50IGF0IGhpZ2gKPiBwcmlvcml0eSB1bnRpbCBmaWxsaW5nIGFib3ZlIHRoZSB0cmFu c2l0aW9uIHdhdGVybWFyaywgdGhlbiB0aGUKPiByZXF1ZXN0cyBhcmUgc2VudCBhdCBsb3dlciBw cmlvcml0eSB1bnRpbCBkcm9wcGluZyBiZWxvdyB0aGUgbGV2ZWwtMCBXTS4KPiBUaGUgbG93ZXIg cHJpb3JpdHkgcmVxdWVzdHMgYWxsb3cgb3RoZXIgbWVtb3J5IGNsaWVudHMgdG8gaGF2ZSBiZXR0 ZXIKPiBtZW1vcnkgYWNjZXNzLgo+Cj4gdHJhbnNpdGlvbiBtaW5pbXVtIGlzIHRoZSBtaW5pbXVt IGFtb3VudCBuZWVkZWQgZm9yIHRyYW5zX3dtIHRvIHdvcmsgdG8KPiBlbnN1cmUgIHRoZSBkZW1v dGUgZG9lcyBub3QgaGFwcGVuIGJlZm9yZSBlbm91Z2ggZGF0YSBoYXMgYmVlbiByZWFkIHRvCj4g bWVldCB0aGUgbGV2ZWwgMCB3YXRlcm1hcmsgcmVxdWlyZW1lbnRzLgo+Cj4gdHJhbnNpdGlvbiBh bW91bnQgaXMgY29uZmlndXJhYmxlIHZhbHVlLiBIaWdoZXIgdmFsdWVzIHdpbGwKPiB0ZW5kIHRv IGNhdXNlIGxvbmdlciBwZXJpb2RzIG9mIGhpZ2ggcHJpb3JpdHkgcmVhZHMgZm9sbG93ZWQgYnkg bG9uZ2VyCj4gcGVyaW9kcyBvZiBsb3dlciBwcmlvcml0eSByZWFkcy4gVHVuaW5nIHRvIGxvd2Vy IHZhbHVlcyB3aWxsIHRlbmQgdG8KPiBjYXVzZSBzaG9ydGVyIHBlcmlvZHMgb2YgaGlnaCBhbmQg bG93ZXIgcHJpb3JpdHkgcmVhZHMuCj4KPiBLZWVwaW5nIHRyYW5zaXRpb24gYW1vdW50IHRvIDEw IGluIHRoaXMgcGF0Y2gsIGFzIHN1Z2dlc3RlZCBieSBIVyB0ZWFtLgo+Cj4gU2lnbmVkLW9mZi1i eTogTWFoZXNoIEt1bWFyIDxtYWhlc2gxLmt1bWFyQGludGVsLmNvbT4KPiBBY2tlZC1ieTogTWFh cnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyB8IDUxICsrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKy0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0OSBpbnNlcnRpb25z KCspLCAyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXggYjJi ZDY1ODQ3ZDliLi45YTJlZDFiNzM0ZDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBA QCAtNDU3OSwxMiArNDU3OSw1NSBAQCBza2xfY29tcHV0ZV9saW5ldGltZV93bShzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlKQo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBza2xfY29tcHV0 ZV90cmFuc2l0aW9uX3dtKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gKwkJCQkg ICAgICBzdHJ1Y3Qgc2tsX3dtX3BhcmFtcyAqd3AsCj4gKwkJCQkgICAgICBzdHJ1Y3Qgc2tsX3dt X2xldmVsICp3bV9sMCwKPiArCQkJCSAgICAgIHVpbnQxNl90IGRkYl9hbGxvY2F0aW9uLAo+ICAJ CQkJICAgICAgc3RydWN0IHNrbF93bV9sZXZlbCAqdHJhbnNfd20gLyogb3V0ICovKQo+ICB7Cj4g KwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3N0YXRlLT5iYXNlLmNydGMtPmRldjsKPiArCWNv bnN0IHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAr CXVpbnQxNl90IHRyYW5zX21pbiwgdHJhbnNfeV90aWxlX21pbjsKPiArCXVpbnQxNl90IHRyYW5z X2Ftb3VudCA9IDEwOyAvKiBUaGlzIGlzIGNvbmZpZ3VyYWJsZSBhbW91bnQgKi8Kc2hvdWxkIHBy b2JhYmx5IGJlIGEgY29uc3Qgc2luY2UgaXQncyBhIHR3ZWFrYWJsZS4KPiArCXVpbnQxNl90IHRy YW5zX29mZnNldF9iLCByZXNfYmxvY2tzOwo+ICsKPiAgCWlmICghY3N0YXRlLT5iYXNlLmFjdGl2 ZSkKPiArCQlnb3RvIGV4aXQ7Cj4gKwo+ICsJLyogVHJhbnNpdGlvbiBXTSBhcmUgbm90IHJlY29t bWVuZGVkIGJ5IEhXIHRlYW0gZm9yIEdFTjkgKi8KPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYp IDw9IDkpCj4gKwkJZ290byBleGl0Owo+ICsKPiArCS8qIFRyYW5zaXRpb24gV00gZG9uJ3QgbWFr ZSBhbnkgc2Vuc2UgaWYgaXBjIGlzIGRpc2FibGVkICovCj4gKwlpZiAoIWRldl9wcml2LT5pcGNf ZW5hYmxlZCkKPiArCQlnb3RvIGV4aXQ7Cj4gKwo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikg Pj0gMTApCj4gKwkJdHJhbnNfbWluID0gNDsKPiArCj4gKwl0cmFuc19vZmZzZXRfYiA9IHRyYW5z X21pbiArIHRyYW5zX2Ftb3VudDsKPiArCXRyYW5zX3lfdGlsZV9taW4gPSAodWludDE2X3QpIG11 bF9yb3VuZF91cF91MzJfZml4ZWQxNigyLAo+ICsJCQkJCQkJd3AtPnlfdGlsZV9taW5pbXVtKTsK PiArCj4gKwlpZiAod3AtPnlfdGlsZWQpIHsKPiArCQlyZXNfYmxvY2tzID0gbWF4KHdtX2wwLT5w bGFuZV9yZXNfYiwgdHJhbnNfeV90aWxlX21pbikgKwo+ICsJCQkJdHJhbnNfb2Zmc2V0X2I7ClBl cmhhcHMgb25seSBjYWxjdWxhdGUgdHJhbnNfeV90aWxlX21pbiBpZiB5LXRpbGVkPwo+ICsJfSBl bHNlIHsKPiArCQlyZXNfYmxvY2tzID0gd21fbDAtPnBsYW5lX3Jlc19iICsgdHJhbnNfb2Zmc2V0 X2I7Cj4gKwl9Cj4gKwo+ICsJcmVzX2Jsb2NrcyArPSAxOwo+ICsKPiArCS8qIFdBIEJVRzoxOTM4 NDY2IGFkZCBvbmUgYmxvY2sgZm9yIG5vbiB5LXRpbGUgcGxhbmVzICovCj4gKwlpZiAoIXdwLT55 X3RpbGVkICYmIElTX0NOTF9SRVZJRChkZXZfcHJpdiwgQ05MX1JFVklEX0EwLCBDTkxfUkVWSURf QTApKQo+ICsJCXJlc19ibG9ja3MgKz0gMTsKQ291bGQgYmUgYWRkZWQgdG8gdGhlICF5X3RpbGVk IGJyYW5jaD8KClBhdGNoIGxvb2tzIHNhbmUgdGhvdWdoLCBhbmQgc2VlbXMgdG8gbWF0Y2ggYnNw ZWMgZXhhY3RseS4gSSBjb3VsZG4ndCBmaW5kIHRoZSB2YWx1ZSBmb3IgdHJhbnNfYW1vdW50LCBi dXQgSSdsbCB0YWtlIHlvdXIgd29yZCBpdCdzIHRoZSByaWdodCBvbmUuIDopCgpXaXRoIHRoZSBt aW5vciBmaXhlczoKClJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5r aG9yc3RAbGludXguaW50ZWwuY29tPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK