Content-Type: multipart/mixed; boundary="===============0844360744526703181==" MIME-Version: 1.0 From: Hans de Goede To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 3/4] input/i8042: Add debug output for quirks Date: Mon, 28 Mar 2022 18:30:16 +0200 Message-ID: <9b30f546-308c-ef7b-e59e-740851592275@redhat.com> In-Reply-To: List-Id: --===============0844360744526703181== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, On 3/28/22 18:28, Werner Sembach wrote: > = > Am 28.03.22 um 14:08 schrieb Hans de Goede: >> Hi, >> >> On 3/22/22 21:50, kernel test robot wrote: >>> Hi Werner, >>> >>> Thank you for the patch! Yet something to improve: >>> >>> [auto build test ERROR on dtor-input/next] >>> [also build test ERROR on v5.17 next-20220322] >>> [If your patch is applied to the wrong git tree, kindly drop us a note. >>> And when submitting patch, we suggest to use '--base' as documented in >>> https://git-scm.com/docs/git-format-patch] >>> >>> url: https://github.com/0day-ci/linux/commits/Werner-Sembach/input-i= 8042-Move-__initconst-to-fix-code-styling-warning/20220323-012205 >>> base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git = next >>> config: ia64-defconfig (https://download.01.org/0day-ci/archive/2022032= 3/202203230435.z5FH2fWa-lkp(a)intel.com/config) >>> compiler: ia64-linux-gcc (GCC) 11.2.0 >>> reproduce (this is a W=3D1 build): >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/s= bin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # https://github.com/0day-ci/linux/commit/d92be72641d5753be3aa9= 4fe5961e2dbe2b5bdc9 >>> git remote add linux-review https://github.com/0day-ci/linux >>> git fetch --no-tags linux-review Werner-Sembach/input-i8042-Mov= e-__initconst-to-fix-code-styling-warning/20220323-012205 >>> git checkout d92be72641d5753be3aa94fe5961e2dbe2b5bdc9 >>> # save the config file to linux build tree >>> mkdir build_dir >>> COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make.c= ross O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >> i8042_dritek is only defined when building on x86, I would solve this >> by moving the new pr_debug to inside i8042_check_quirks(); > = > Thanks I missed that. But moving the debug function in i8042_check_quirks= would make the output x86 exclusive, while the > quirks in general are not (on non x86 they must be set via command line b= ut still have effects on the code if i see that > correctly) True. >> The i8042_nopnp not being defined order is slightly tricker, you >> can more or less cleanly fix this by doing this at the end of >> i8042_check_quirks() and then put the new pr_debug after this: >> >> #ifdef CONFIG_PNP >> if (quirks & SERIO_QUIRK_NOPNP) >> i8042_nopnp =3D true; >> #else >> #define i8042_nopnp 0 >> #endif > = > As an alternative i would suggest putting defines in the pr_debug call. O= therwise it might not be immediately that the > #define i8042_nopnp 0 is there specifically for this one statement only. > = > =C2=A0=C2=A0=C2=A0 pr_debug("Active quirks (empty means none):%s%s%s%s%s%= s%s%s%s%s%s%s%s\n", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_nokbd ? " nokbd" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_noaux ? " noaux" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_nomux ? " nomux" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_unlock ? " unlock" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_probe_defer ? "probe_defer" := "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_reset =3D=3D I8042_RESET_DEFA= ULT ? > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 "" : i8042_reset= =3D=3D I8042_RESET_ALWAYS ? > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2= =A0 " reset_always" : " reset_never", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_direct ? " direct" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_dumbkbd ? " dumbkbd" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_noloop ? " noloop" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_notimeout ? " notimeout" : "", > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_kbdreset ? " kbdreset" : "", > #ifdef CONFIG_X86 > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_dritek ? " dritek" : "", > #else > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 "", > #endif > #ifdef CONFIG_PNP > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 i8042_nopnp ? " nopnp" : ""); > #else > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 ""); > #endif > = > As a side effect: like this the code snipped also stays completely positi= on independed. Ok, the above solution is fine by me. It also has the advantage of not defining i8042_nopnp which may lead to accidentally getting used when not set later. Regards, Hans >>> All errors (new ones prefixed by >>): >>> >>> In file included from include/asm-generic/bug.h:22, >>> from arch/ia64/include/asm/bug.h:17, >>> from include/linux/bug.h:5, >>> from include/linux/thread_info.h:13, >>> from include/asm-generic/preempt.h:5, >>> from ./arch/ia64/include/generated/asm/preempt.h:1, >>> from include/linux/preempt.h:78, >>> from include/linux/rcupdate.h:27, >>> from include/linux/rculist.h:11, >>> from include/linux/pid.h:5, >>> from include/linux/sched.h:14, >>> from include/linux/delay.h:23, >>> from drivers/input/serio/i8042.c:12: >>> drivers/input/serio/i8042-x86ia64io.h: In function 'i8042_platform_i= nit': >>>>> drivers/input/serio/i8042-x86ia64io.h:1511:17: error: 'i8042_dritek' = undeclared (first use in this function); did you mean 'i8042_direct'? >>> 1511 | i8042_dritek ? " dritek" : "", >>> | ^~~~~~~~~~~~ >>> include/linux/printk.h:418:33: note: in definition of macro 'printk_= index_wrap' >>> 418 | _p_func(_fmt, ##__VA_ARGS__); = \ >>> | ^~~~~~~~~~~ >>> include/linux/printk.h:132:17: note: in expansion of macro 'printk' >>> 132 | printk(fmt, ##__VA_ARGS__); \ >>> | ^~~~~~ >>> include/linux/printk.h:576:9: note: in expansion of macro 'no_printk' >>> 576 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) >>> | ^~~~~~~~~ >>> drivers/input/serio/i8042-x86ia64io.h:1497:9: note: in expansion of = macro 'pr_debug' >>> 1497 | pr_debug("Active quirks (empty means none):%s%s%s%s%= s%s%s%s%s%s%s%s%s\n", >>> | ^~~~~~~~ >>> drivers/input/serio/i8042-x86ia64io.h:1511:17: note: each undeclared= identifier is reported only once for each function it appears in >>> 1511 | i8042_dritek ? " dritek" : "", >>> | ^~~~~~~~~~~~ >>> include/linux/printk.h:418:33: note: in definition of macro 'printk_= index_wrap' >>> 418 | _p_func(_fmt, ##__VA_ARGS__); = \ >>> | ^~~~~~~~~~~ >>> include/linux/printk.h:132:17: note: in expansion of macro 'printk' >>> 132 | printk(fmt, ##__VA_ARGS__); \ >>> | ^~~~~~ >>> include/linux/printk.h:576:9: note: in expansion of macro 'no_printk' >>> 576 | no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__) >>> | ^~~~~~~~~ >>> drivers/input/serio/i8042-x86ia64io.h:1497:9: note: in expansion of = macro 'pr_debug' >>> 1497 | pr_debug("Active quirks (empty means none):%s%s%s%s%= s%s%s%s%s%s%s%s%s\n", >>> | ^~~~~~~~ >>> >>> >>> vim +1511 drivers/input/serio/i8042-x86ia64io.h >>> >>> 1494 = >>> 1495 i8042_check_quirks(); >>> 1496 = >>> 1497 pr_debug("Active quirks (empty means none):%s%s%s%s%s%s%s%s%s%s= %s%s%s\n", >>> 1498 i8042_nokbd ? " nokbd" : "", >>> 1499 i8042_noaux ? " noaux" : "", >>> 1500 i8042_nomux ? " nomux" : "", >>> 1501 i8042_unlock ? " unlock" : "", >>> 1502 i8042_probe_defer ? "probe_defer" : "", >>> 1503 i8042_reset =3D=3D I8042_RESET_DEFAULT ? >>> 1504 "" : i8042_reset =3D=3D I8042_RESET_ALWAYS ? >>> 1505 " reset_always" : " reset_never", >>> 1506 i8042_direct ? " direct" : "", >>> 1507 i8042_dumbkbd ? " dumbkbd" : "", >>> 1508 i8042_noloop ? " noloop" : "", >>> 1509 i8042_notimeout ? " notimeout" : "", >>> 1510 i8042_kbdreset ? " kbdreset" : "", >>>> 1511 i8042_dritek ? " dritek" : "", >>> 1512 i8042_nopnp ? " nopnp" : ""); >>> 1513 = >>> 1514 retval =3D i8042_pnp_init(); >>> 1515 if (retval) >>> 1516 return retval; >>> 1517 = >>> >=20 --===============0844360744526703181==--