From: Stefan Roese Date: Wed, 3 Apr 2019 13:21:08 +0200 Subject: [U-Boot] [PATCH 10/13 v3] Makefile: Add Kconfig option CONFIG_SPL_IMAGE to select the SPL binary In-Reply-To: <26a6b0c3-3a23-b572-7f21-ce719b3137d9@microchip.com> References: <20190402085727.14552-1-sr@denx.de> <20190402085727.14552-10-sr@denx.de> <26a6b0c3-3a23-b572-7f21-ce719b3137d9@microchip.com> Message-ID: <9b89ce68-e72d-cfdb-fd89-97341d6be4a9@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de On 03.04.19 13:11, Eugen.Hristev at microchip.com wrote: > > > On 03.04.2019 14:03, Eugen Hristev wrote: >> >> >> On 02.04.2019 11:57, Stefan Roese wrote: >> >>> >>> This patch adds the CONFIG_SPL_IMAGE option to select the SPL image that >>> shall be used to generate the combined SPL + U-Boot image. The default >>> value is the current value "spl/u-boot-spl.bin". >>> >>> This patch also sets CONFIG_SPL_IMAGE to "spl/boot.bin" for AT91 targets >>> which use SPL NAND support (boot from NAND). For these build targets the >>> combined image "u-boot-with-spl.bin" is now automatically generated and >>> can be programmed into NAND as one single image (vs. SPL image and U-Boot >>> as 2 separate images). >>> >>> Signed-off-by: Stefan Roese >>> Cc: Heiko Schocher >>> Cc: Andreas Bießmann >>> Cc: Eugen Hristev >>> Reviewed-by: Heiko Schocher >>> Tested on the taurus board: >>> Tested-by: Heiko Schocher >>> --- >>> v3: >>> - No change >>> >>> v2: >>> - No change >>> >>>   Kconfig  | 10 ++++++++++ >>>   Makefile |  4 +++- >>>   2 files changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/Kconfig b/Kconfig >>> index 305b265ed7..7c2b86f1f3 100644 >>> --- a/Kconfig >>> +++ b/Kconfig >>> @@ -224,6 +224,15 @@ config BUILD_ROM >>>         which are not shipped in the U-Boot source tree. >>>         Please, see doc/README.x86 for details. >>> +config SPL_IMAGE >>> +    string "SPL image filename that is generated" >>> +    default "spl/boot.bin" if ARCH_AT91 && SPL_NAND_SUPPORT >>> +    default "spl/u-boot-spl.bin" >>> +    help >>> +      The SPL image filename that is generated by the build process. >>> +      This image might be used to generated a combined image with >>> +      SPL and main U-Boot proper as well. >>> + >> >> Hi Stefan, >> >> If I try to just use menuconfig and change this value to something else, >> build fails. The purpose of this Kconfig is to name the SPL filename as >> per the config's desire ? >> >> Or in fact is "which binary file to use to make the Combined SPL+U-BOOT >> mega image" ? > > Ok, the commit message explains it pretty well, but the Kconfig help is > totally different... hence the confusion sorry. > So we need to either make a choice submenu in this Kconfig : either this > or that; or, do exactly what the Kconfig says: rename the output binary > into the value of this Kconfig. > > Does this make sense ? You are suggesting to add this SPL_IMAGE as choice instead of its current implementation? That might be better, yes. Let me look into this... Thanks, Stefan