From: "cron2 (Code Review)" Date: Tue, 27 Jan 2026 14:42:00 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9ba74cea2adf8d06e598f0a187ce226cd3dcc4c1-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="MRrASMwE9to="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: manage: Do not trigger actions on management disconnect if not authen... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld , plaisthos Cc: openvpn-devel --MRrASMwE9to= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#2) to the change originally created by= flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1484?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: manage: Do not trigger actions on management disconnect if = not authenticated ...................................................................... manage: Do not trigger actions on management disconnect if not authenticated If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#5 Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484 Message-Id: <20260122125707.108048-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 390.html Signed-off-by: Gert Doering --- M src/openvpn/manage.c 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/84/1484/2 diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 8fa8784..37ae6b3 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -2073,13 +2073,14 @@ } if (!exiting) { - if (man->settings.flags & MF_FORGET_DISCONNECT) + if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_ne= eded(man)) { + msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconn= ect"); ssl_purge_auth(false); (void)ssl_clean_auth_token(); } - if (man->settings.flags & MF_SIGNAL) + if (man->settings.flags & MF_SIGNAL && !man_password_needed(man)) { int mysig =3D man_mod_signal(man, SIGUSR1); if (mysig >=3D 0) --=20 To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Gerrit-Change-Number: 1484 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --MRrASMwE9to= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #2 to the change originally created by flichtenhel= d.

View Change

The following approvals got outdated and were remove= d: Code-Review+2 by plaisthos

manage: Do not trigger actions =
on management disconnect if not authenticated

If the management inte= rface requires authentication via password
and the remote did not specif= y it, do not do trigger actions
requested by --management-forget-disconn= ect and --management-signal
on disconnect.

Reported-By: Joshua Ro= gers <contact@...2949...>
Found-By: ZeroPath (https://zeropath.com= )
Github: openvpn-private-issues#5
Change-Id: I575d65912ce9065a0b0868= e73998b4a9aece62af
Signed-off-by: Frank Lichtenheld <frank@...2641...= >
Acked-by: Arne Schwabe <arne-openvpn@...1227...>
Gerrit UR= L: https://gerrit.openvpn.net/c/openvpn/+/1484
Message-Id: <202601221= 25707.108048-1-frank@...2641...>
URL: https://www.mail-archive.com/op= envpn-devel@lists.sourceforge.net/msg35390.html
Signed-off-by: Gert Doer= ing <gert@...1296...>
---
M src/openvpn/manage.c
1 file chan= ged, 3 insertions(+), 2 deletions(-)

git pull ss=
h://gerrit.openvpn.net:29418/openvpn refs/changes/84/1484/2
diff --=
git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 8fa= 8784..37ae6b3 100644
--- a/src/openvpn/manage.c
<= span>+++ b/src/openvpn/manage.c
@@ -2073,13 +2073,14 @@
}
if (!exiting)
= {
- if (man->= ;settings.flags & MF_FORGET_DISCONNECT)
+ if (man->settings.flags & MF_FORGET_= DISCONNECT && !man_password_needed(man))
{=
+ msg(D_M= ANAGEMENT, "MANAGEMENT: Reset authentication on disconnect");
ssl_purge_auth(false);
= (void)ssl_clean_auth_token();
}

- if (man->= ;settings.flags & MF_SIGNAL)
+ if (man->settings.flags & MF_SIGNAL && = !man_password_needed(man))
{
= int mysig =3D man_mod_signal(man, SIGUSR1);
= if (mysig >=3D 0)

To view, vis= it chang= e 1484. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e7399= 8b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --MRrASMwE9to=--