From: "cron2 (Code Review)" Date: Tue, 27 Jan 2026 14:42:04 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9ba74cea2adf8d06e598f0a187ce226cd3dcc4c1-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="YhKBcLxMYhw="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: manage: Do not trigger actions on management disconnect if not authen... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --YhKBcLxMYhw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/14= 84?usp=3Demail ) Change subject: manage: Do not trigger actions on management disconnect if = not authenticated ...................................................................... manage: Do not trigger actions on management disconnect if not authenticated If the management interface requires authentication via password and the remote did not specify it, do not do trigger actions requested by --management-forget-disconnect and --management-signal on disconnect. Reported-By: Joshua Rogers Found-By: ZeroPath (https://zeropath.com) Github: openvpn-private-issues#5 Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Signed-off-by: Frank Lichtenheld Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1484 Message-Id: <20260122125707.108048-1-frank@...2641...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg35= 390.html Signed-off-by: Gert Doering --- M src/openvpn/manage.c 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index 8fa8784..37ae6b3 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -2073,13 +2073,14 @@ } if (!exiting) { - if (man->settings.flags & MF_FORGET_DISCONNECT) + if (man->settings.flags & MF_FORGET_DISCONNECT && !man_password_ne= eded(man)) { + msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconn= ect"); ssl_purge_auth(false); (void)ssl_clean_auth_token(); } - if (man->settings.flags & MF_SIGNAL) + if (man->settings.flags & MF_SIGNAL && !man_password_needed(man)) { int mysig =3D man_mod_signal(man, SIGUSR1); if (mysig >=3D 0) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1484?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62af Gerrit-Change-Number: 1484 Gerrit-PatchSet: 2 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --YhKBcLxMYhw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 sub= mitted this change.

View Change

manage: Do not trigger actions on management dis=
connect if not authenticated

If the management interface requires au= thentication via password
and the remote did not specify it, do not do t= rigger actions
requested by --management-forget-disconnect and --managem= ent-signal
on disconnect.

Reported-By: Joshua Rogers <contact@= ...2949...>
Found-By: ZeroPath (https://zeropath.com)
Github: open= vpn-private-issues#5
Change-Id: I575d65912ce9065a0b0868e73998b4a9aece62a= f
Signed-off-by: Frank Lichtenheld <frank@...2641...>
Acked-by:= Arne Schwabe <arne-openvpn@...1227...>
Gerrit URL: https://gerrit= .openvpn.net/c/openvpn/+/1484
Message-Id: <20260122125707.108048-1-fr= ank@...2641...>
URL: https://www.mail-archive.com/openvpn-devel@...1697...= .sourceforge.net/msg35390.html
Signed-off-by: Gert Doering <gert@...1386...= 296...>
---
M src/openvpn/manage.c
1 file changed, 3 insertions= (+), 2 deletions(-)

diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c
index 8fa8784..37ae6b3 100644
--- a/src/openvpn/manage.c
+++ b/src/openvpn/manage.c
@@ -2073,13 +2073= ,14 @@
}
if (!exiting)
= {
- i= f (man->settings.flags & MF_FORGET_DISCONNECT)
+ if (man->settings.flags & = MF_FORGET_DISCONNECT && !man_password_needed(man))
= {
+ = msg(D_MANAGEMENT, "MANAGEMENT: Reset authentication on disconnect&q= uot;);
ssl_purge_auth(false);
= (void)ssl_clean_auth_token();
}


- i= f (man->settings.flags & MF_SIGNAL)
+ if (man->settings.flags & MF_SIGNAL &= amp;& !man_password_needed(man))
{
<= span> int mysig =3D man_mod_signal(man, SIGUSR1);
if (mysig >=3D 0)

To= view, visit change 1484. To unsubscribe, or for help writing mail filters, vis= it settings.=

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I575d65912ce9065a0b0868e7399= 8b4a9aece62af
Gerrit-Change-Number: 1484
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --YhKBcLxMYhw=--