From: "cron2 (Code Review)" Date: Wed, 18 Jun 2025 16:28:34 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., gianmarco@...2726..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9bca6cf5193be45146057d503ab86ff45059cd5f-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="aR4NxjZUBr0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Route: add support for user defined routing table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: its_Giaan Cc: flichtenheld , plaisthos , openvpn-devel --aR4NxjZUBr0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, its_Giaan, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/524?usp=3Demail ) Change subject: Route: add support for user defined routing table ...................................................................... Patch Set 8: Code-Review-1 (3 comments) Patchset: PS8: Got left out in the sun too long, so now it needs polish... (sorry) File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/524/comment/5ca01c93_caaa3aa2 : PS8, Line 7020: options->route_default_table_id =3D positive_atoi(p= [1]); Unfortunately, `positive_atoi()` now wants 2 arguments... (`msglevel`). So= this needs a rebase & fixup. File src/openvpn/route.c: http://gerrit.openvpn.net/c/openvpn/+/524/comment/2f114621_8e4ffe35 : PS8, Line 332: /* network */ spurious blank line removal... if you want to remove one, I think removing = the one after the `/* network */` comment makes more sense, and maybe one o= f the 2 blank lines further down (337). But removing this one does no good. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/524?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede5617ee98bf218a7 Gerrit-Change-Number: 524 Gerrit-PatchSet: 8 Gerrit-Owner: its_Giaan Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: its_Giaan Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Wed, 18 Jun 2025 16:28:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --aR4NxjZUBr0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, its_Giaan, plaistho= s.

Patch set 8:Code-Review -1=

Vi= ew Change

3 comments:

  • Patchset:

    • Patch Set #8:

      Got left out in the sun too long, so now it n= eeds polish... (sorry)

  • File src/openvpn/options.c:

    • Patch Set #8, Line 7020: options->route_default_table_id =3D positive_at= oi(p[1]);

      Unfortunately, `positive_atoi()` now wants 2 arguments... (`msglevel`).= So this needs a rebase & fixup.

  • File src/openvpn/route.c:

    • Patch Set #8, Line 332: /* network */

      spurious blank line removal... i= f you want to remove one, I think removing the one after the `/* network */= ` comment makes more sense, and maybe one of the 2 blank lines further down= (337). But removing this one does no good.

To v= iew, visit change 524. To unsubscribe, or for help writing mail filters, visit <= a href=3D"http://gerrit.openvpn.net/settings">settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3e4ebef484d2a04a383a65ede56= 17ee98bf218a7
Gerrit-Change-Number: 524
Gerrit-PatchSet: 8
Gerrit-Owner: its_Giaan <gianmarco@...2786...= ..>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: its_Giaan <gianmarco@...1665...= 726...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Wed, 18 Jun 2025 16:28:34= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--aR4NxjZUBr0=--