From: "cron2 (Code Review)" Date: Fri, 18 Jul 2025 19:16:48 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, ralf@...2726..., frank@...2641... Message-ID: <9c1481d7f5c27b18805a3dd4f1b6af645f58f1e8-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="kVy/ACUsamg="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: improve float collision logging List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ralf_lici Cc: plaisthos , flichtenheld , openvpn-devel --kVy/ACUsamg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos, ralf_lici. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1091?usp=3Demail ) Change subject: improve float collision logging ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: works! Disabled the "goto done" part from the "same peer-id" check, and played wit= h the LAN cable :-) - resulting in ``` 2025-07-18 21:14:25 us=3D793140 cron2-freebsd-tc-amd64/udp6:193.149.48.173:= 49409 peer-id=3D0 disallowing peer 0 (cron2-freebsd-tc-amd64) from floating= to its own address (udp6:193.149.48.173:49409) 2025-07-18 21:14:25 us=3D793175 cron2-freebsd-tc-amd64/udp6:193.149.48.173:= 49409 peer-id=3D0 closing instance cron2-freebsd-tc-amd64/udp6:193.149.48.1= 73:49409 peer-id=3D0 due to float collision with cron2-freebsd-tc-amd64/udp= 6:193.149.48.173:49409 peer-id=3D0 using the same certificate ``` (and then, of course, it SIGSEGVs, but that's expected - so the extra loggi= ng makes this a much clearer picture. Could not reproduce with two differe= nt clients, but I don't think this will add extra testing coverage) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1091?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I217cfb319b85fd75a88f7d4d50c374d28771df28 Gerrit-Change-Number: 1091 Gerrit-PatchSet: 1 Gerrit-Owner: ralf_lici Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Attention: ralf_lici Gerrit-Comment-Date: Fri, 18 Jul 2025 19:16:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --kVy/ACUsamg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos, ralf_lic= i.

Patch set 1:Code-Review +2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #1:

      works!

      Disabled the "goto done" part from the &= quot;same peer-id" check, and played with the LAN cable :-) - resultin= g in

      ```
      2= 025-07-18 21:14:25 us=3D793140 cron2-freebsd-tc-amd64/udp6:193.149.48.173:4= 9409 peer-id=3D0 disallowing peer 0 (cron2-freebsd-tc-amd64) from floating = to its own address (udp6:193.149.48.173:49409)
      2025-07-18 21:14:25 us=3D= 793175 cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=3D0 closing= instance cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 peer-id=3D0 due = to float collision with cron2-freebsd-tc-amd64/udp6:193.149.48.173:49409 pe= er-id=3D0 using the same certificate
      ```

      (and then, of course, it SIGSEGVs, but that&= #39;s expected - so the extra logging makes this a much clearer picture. C= ould not reproduce with two different clients, but I don't think this w= ill add extra testing coverage)

To view, visit change 109= 1. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I217cfb319b85fd75a88f7d4d50c= 374d28771df28
Gerrit-Change-Number: 1091
Gerrit-PatchSet: 1
Gerrit-Owner: ralf_lici <ralf@...2726...>= ;
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Attention: ralf_lici <ralf@...2804...= .>
Gerrit-Comment-Date: Fri, 18 Jul 2025 19:16:48= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--kVy/ACUsamg=--