From: "flichtenheld (Code Review)" Date: Fri, 10 Jan 2025 13:11:20 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., heiko@...515..., openvpn-devel@lists.sourceforge.net Message-ID: <9c8cfb6d42ff083d85887acf05e367634aac4ac9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Fzn7zHtUpyw="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: win: implement --dns option support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: d12fk Cc: plaisthos , openvpn-devel --Fzn7zHtUpyw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/837?usp=3Demail ) Change subject: win: implement --dns option support ...................................................................... Patch Set 6: (1 comment) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/837/comment/29071d80_c92d5c0a : PS5, Line 2265: MsgToEventLog(M_SYSERR, TEXT("IsInterfaceConnected:= " > How did you get to this conclusion? Works for me, and Compiler Explorer a= lso shows that the string i [=E2=80=A6] Yeah, it seems to work even though I'm not exactly sure what the logic is t= hat makes it work. Maybe when you have multiple string literals the L just = gets applied from left to right? Either way I decided to instead get TEXT()= removed completely from our code base, see my separate patch series. I wil= l leave it to you whether you want to use it here and have it converted in = my series or use L"" here directly. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/837?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5adbebaaf209cc Gerrit-Change-Number: 837 Gerrit-PatchSet: 6 Gerrit-Owner: d12fk Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: d12fk Gerrit-Comment-Date: Fri, 10 Jan 2025 13:11:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld Comment-In-Reply-To: d12fk Gerrit-MessageType: comment --Fzn7zHtUpyw= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: d12fk, plaisthos.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    File src/openvpnserv/interactive.c:<= /p>

    • Patch Set #5, Line = 2265: MsgToEven= tLog(M_SYSERR, TEXT("IsInterfaceConnected: "

      Yeah, it seems to work even though = I'm not exactly sure what the logic is that makes it work. Maybe when y= ou have multiple string literals the L just gets applied from left to right= ? Either way I decided to instead get TEXT() removed completely from our co= de base, see my separate patch series. I will leave it to you whether you w= ant to use it here and have it converted in my series or use L"" = here directly.

To view, visit change 837. To unsubscri= be, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I576e74f3276362606e9cbd50bb5= adbebaaf209cc
Gerrit-Change-Number: 837
Gerrit-PatchSet: 6
Gerrit-Owner: d12fk <heiko@...515...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: d12fk <heiko@...515...>= ;
Gerrit-Comment-Date: Fri, 10 Jan 2025 13:11:20= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Comment-In-Reply-To: d12fk <heiko@...515...= >
Gerrit-MessageType: comment
--Fzn7zHtUpyw=--