From: "flichtenheld (Code Review)" Date: Wed, 14 Jan 2026 16:56:40 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, steffan@...1856..., max@...2606... Message-ID: <9c9e7554f0f1d2b55067dcaeea8386bcf95b8ae9-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="W5ML2X7OtQM="; charset=UTF-8 Subject: [Openvpn-devel] [XL] Change in openvpn[master]: Add support for Mbed TLS 4 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: MaxF Cc: syzzer , plaisthos , openvpn-devel --W5ML2X7OtQM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: MaxF, plaisthos, syzzer. flichtenheld has posted comments on this change by MaxF. ( http://gerrit.op= envpn.net/c/openvpn/+/1441?usp=3Demail ) Change subject: Add support for Mbed TLS 4 ...................................................................... Patch Set 5: Code-Review-2 (1 comment) Patchset: PS5: I have added http://gerrit.openvpn.net/c/openvpn/+/1474 that updates the GH= A definition to use mbedtls 4. But it has multiple failures (see https://gi= thub.com/flichtenheld/openvpn/actions/runs/21002319306/job/60375385060) On Ubuntu 22.04 it builds but then fails in t_server_null.sh with 2026-01-14 16:50:43 Mbed TLS 4 only supports pre-defined Diffie-Hellman= groups. 2026-01-14 16:50:43 Exiting due to fatal error On Ubuntu 24.04 it doesn't build ``` CC ssl_mbedtls.o ssl_mbedtls.c:607:1: error: unused function 'external_pkcs1_sign' [-Werror,= -Wunused-function] external_pkcs1_sign(void *ctx_voidptr, int (*f_rng)(void *, unsigned char *= , size_t), void *p_rng, ^ ssl_mbedtls.c:703:1: error: unused function 'external_key_len' [-Werror,-Wu= nused-function] external_key_len(void *vctx) ^ 2 errors generated. ``` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1441?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111bcc627cdb0fae Gerrit-Change-Number: 1441 Gerrit-PatchSet: 5 Gerrit-Owner: MaxF Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-CC: syzzer Gerrit-Attention: syzzer Gerrit-Attention: plaisthos Gerrit-Attention: MaxF Gerrit-Comment-Date: Wed, 14 Jan 2026 16:56:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes --W5ML2X7OtQM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is cur= rently required from: MaxF, plaisthos, syzzer.

Patch set 5:Code-Review -2=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #5:

      I have adde= d http://gerrit.openvpn.net/c/openvpn/+/1474 that updates the GHA definitio= n to use mbedtls 4. But it has multiple failures (see https://github.com/fl= ichtenheld/openvpn/actions/runs/21002319306/job/60375385060)

      On Ubuntu = 22.04 it builds but then fails in t_server_null.sh with

        =
        2026-01-14 16:50:43 Mbed TLS 4 only supports pre-defined Diffie-Hellman g=
      roups.
      2026-01-14 16:50:43 Exiting due to fatal error

      On Ubun= tu 24.04 it doesn't build

      ```
      CC ssl_mbedtl= s.o
      ssl_mbedtls.c:607:1: error: unused function 'external_pkcs1_sign= ' [-Werror,-Wunused-function]
      external_pkcs1_sign(void *ctx_voidptr,= int (*f_rng)(void *, unsigned char *, size_t), void *p_rng,
      ^
      ssl_mb= edtls.c:703:1: error: unused function 'external_key_len' [-Werror,-= Wunused-function]
      external_key_len(void *vctx)
      ^
      2 errors generate= d.
      ```

To view, visit change 1441. To unsubscrib= e, or for help writing mail filters, visit settings.

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Ib251d546d993b96ed3bd8cb9111= bcc627cdb0fae
Gerrit-Change-Number: 1441
Gerrit-PatchSet: 5
Gerrit-Owner: MaxF <max@...2606...>
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-CC: syzzer <steffan@...1856...> <= /div>
Gerrit-Attention: syzzer <steffan@...2115...= .>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: MaxF <max@...2606...> =
Gerrit-Comment-Date: Wed, 14 Jan 2026 16:56:40= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
= --W5ML2X7OtQM=--