From: "stipa (Code Review)" Date: Tue, 15 Apr 2025 11:33:32 +0000 References: Reply-To: lstipakov@...277..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9cc1439ea605cde4f66995e3f85adc416b0204c8-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="SzCsZ7w9HIM="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: Remove UINT8_MAX definition List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos , flichtenheld Cc: openvpn-devel --SzCsZ7w9HIM= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. Hello plaisthos, flichtenheld, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=3Demail to review the following change. Change subject: Remove UINT8_MAX definition ...................................................................... Remove UINT8_MAX definition Because this is a part of C99 if uint8_t is available. Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09 Signed-off-by: Lev Stipakov --- M src/openvpn/socket.c 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/40/940/1 diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c index bd7a449..a0c22b1 100644 --- a/src/openvpn/socket.c +++ b/src/openvpn/socket.c @@ -3036,10 +3036,6 @@ return BSTR(&buffer); } -#ifndef UINT8_MAX -#define UINT8_MAX 0xff -#endif - /* add some offset to an ipv6 address * (add in steps of 8 bits, taking overflow into next round) */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/940?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I37482a8c322680add00bab52272f9945fbb3bd09 Gerrit-Change-Number: 940 Gerrit-PatchSet: 1 Gerrit-Owner: stipa Gerrit-Reviewer: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-MessageType: newchange --SzCsZ7w9HIM= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

stipa would like plaisthos and flichtenheld to review t= his change.

Vi= ew Change

Remove UINT8_MAX definition

Because this is a part of = C99 if uint8_t is available.

Change-Id: I37482a8c322680add00bab52272= f9945fbb3bd09
Signed-off-by: Lev Stipakov <lev@...515...>
---M src/openvpn/socket.c
1 file changed, 0 insertions(+), 4 deletions(-)=

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/40/=
940/1
diff --git a/src/openvpn/socket.c b/src/openvpn/socket.c
index bd7a449..a0c22b1 100644
--- a/src/openvpn= /socket.c
+++ b/src/openvpn/socket.c
@@ -30= 36,10 +3036,6 @@
return BSTR(&buffer);
<= span> }


-#ifndef UINT8_MAX
-= #define UINT8_MAX 0xff
= -#endif
-
/* add some offset to an ipv6 address
* (add in steps= of 8 bits, taking overflow into next round)
*/

To view, visit change 940. To unsubscribe, or for hel= p writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I37482a8c322680add00bab52272= f9945fbb3bd09
Gerrit-Change-Number: 940
Gerrit-PatchSet: 1
Gerrit-Owner: stipa <lstipakov@...277...>= ;
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-MessageType: newchange
--SzCsZ7w9HIM=--