From: Jens Axboe Subject: Re: [PATCH v4 0/29] block: Make blkdev_get_by_*() return handle Date: Wed, 27 Sep 2023 08:19:36 -0600 Message-ID: <9cc59d88-4b77-4e56-ae54-737baca1d435@kernel.dk> References: <20230818123232.2269-1-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1695824379; x=1696429179; darn=lists.linbit.com; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:from:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=Wwk46okUDVQfnnelgDDAXJI2PyNHcNwKe3ka13udWbU=; b=a1si7fPns95bpiUo9XfsJtEbETggjkQ7yp94gQuYfBwml/OwxDYlogbSHjoh0v6f9A GRMZzaTtFg1pyWvMLY0OG/Xo1G84F7wyXipsdc9wI7i8vTww064XVcczd+VdD/HX/Sdb OWeR2Y2+cGHCUGhRyqjcyaPQX9T9hRdhtWXUdTIskndf7Ts/OjJtvox5sbSE6mZP1L9F JgE+DoL8TaZT9WYvxZf4NU7TWTzcNRX2cn/L8arKQSQkelkxjZp2L3Wz1Qir0IPJ9xaF v12rg6PfDw5LtTXg0LHif2NBTy60MO+m0Z7xzNs2aIvGfRgDBtHcJFkrROBcrJHCl5S7 8r6A== Content-Language: en-US In-Reply-To: <20230818123232.2269-1-jack-AlSwsSmVLrQ@public.gmane.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org Errors-To: drbd-dev-bounces-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org To: Jan Kara Cc: Dave Kleikamp , jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jan Kara , "Darrick J. Wong" , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Joseph Qi , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jack Wang , Alasdair Kergon , drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nilfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergey Senozhatsky , Christoph Hellwig , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, Gao Xiang , Christian Borntraeger , Kent Overstreet , Sven Schnelle , linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Snitzer , Chao Yu , Joern Engel , lin On Wed, Sep 27, 2023 at 3:34?AM Jan Kara wrote: > > Hello, > > this is a v3 of the patch series which implements the idea of blkdev_get_by_*() v4? > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > makes the get and put calls for bdevs more obviously matching and allows us to > propagate context from get to put without having to modify all the users > (again!). In particular I need to propagate used open flags to blkdev_put() to > be able count writeable opens and add support for blocking writes to mounted > block devices. I'll send that series separately. > > The series is based on Btrfs tree's for-next branch [2] as of today as the > series depends on Christoph's changes to btrfs device handling. Patches have > passed some reasonable testing - I've tested block changes, md, dm, bcache, > xfs, btrfs, ext4, swap. More testing or review is always welcome. Thanks! I've > pushed out the full branch to: > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle > > to ease review / testing. Christian, can you pull the patches to your tree > to get some exposure in linux-next as well? Thanks! For the block bits: Acked-by: Jens Axboe -- Jens Axboe