From: Sagar Arun Kamble Subject: Re: [PATCH v6 2/2] drm/i915: Consolidate checks for engine stats availability Date: Wed, 29 Nov 2017 15:03:01 +0530 Message-ID: <9d852785-5b1b-b2bd-e66a-534c697ecfd8@intel.com> References: <20171129082450.18278-1-tvrtko.ursulin@linux.intel.com> <20171129092756.22010-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id F33976E84E for ; Wed, 29 Nov 2017 09:33:03 +0000 (UTC) In-Reply-To: <20171129092756.22010-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAxMS8yOS8yMDE3IDI6NTcgUE0sIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2 cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4KPiBTYWdhciBub3RpY2Vk IHRoZSBjaGVjayBjYW4gYmUgY29uc29saWRhdGVkIGJldHdlZW4gdGhlIGVuZ2luZSBzdGF0cwo+ IGltcGxlbWVudGF0aW9uIGFuZCB0aGUgUE1VLgo+Cj4gTXkgZmlyc3QgY2hvaWNlIHdhcyBhIHN0 YXRpYyBpbmxpbmUgaGVscGVyIGJ1dCB0aGF0IGdvdCBpbnRvIGluY2x1ZGUKPiBvcmRlcmluZyBt ZXNzIHF1aWNrbHkgZmFzdCBzbyBJIHdlbnQgd2l0aCBhIG1hY3JvIGluc3RlYWQuIEF0IHNvbWUg cG9pbnQKPiB3ZSBzaG91bGQgcGVyaGFwcyBsb29raW5nIGludG8gdGFraW5nIG91dCB0aGUgbm9u LXJpbmd1YmZmZXIgYml0cyBmcm9tCj4gaW50ZWxfcmluZ2J1ZmZlci5oIGludG8gYSBuZXcgaW50 ZWxfZW5naW5lLmggb3Igc29tZXRoaW5nLgo+Cj4gdjI6IFVzZSBlbmdpbmUtPmZsYWdzLiAoQ2hy aXMgV2lsc29uKQo+IHYzOiBSZWJhc2UgYW5kIG1hcmsgR3VDIGFzIG5vdCB5ZXQgc3VwcG9ydGVk LiAoQ2hyaXMgV2lsc29uKQo+IHY0OiBNb3ZlIGZsYWcgc2V0dGluZyB0byBpbnRlbF9lbmdpbmVz X3Jlc2V0X2RlZmF1bHRfc3VibWlzc2lvbi4KPiAgICAgIChDaHJpcyBXaWxzb24pCj4gdjU6IE1v dmUgZmxhZyBzZXR0aW5nIHRvIGxvZ2ljYWxfcmluZ19zZXR1cC4KPiB2NjogaW50ZWxfZW5naW5l c19yZXNldF9kZWZhdWx0X3N1Ym1pc3Npb24gaXMgdGhlIHdyb25nIHBsYWNlIHRvIHNldCB0aGUK PiAgICAgIGZsYWcgLSBpdCBuZWVkcyB0byBiZSBpbiBleGVjbGlzdHNfc2V0X2RlZmF1bHRfc3Vi bWlzc2lvbi4gKFNhZ2FyKQo+Cj4gU2lnbmVkLW9mZi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRr by51cnN1bGluQGludGVsLmNvbT4KPiBTdWdnZXN0ZWQtYnk6IFNhZ2FyIEFydW4gS2FtYmxlIDxz YWdhci5hLmthbWJsZUBpbnRlbC5jb20+Cj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5h LmthbWJsZUBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPiAodjIpCgpSZXZpZXdlZC1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNh Z2FyLmEua2FtYmxlQGludGVsLmNvbT4KCj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3BtdS5jICAgICAgICAgICAgIHwgMTEgKysrKy0tLS0tLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jICAgICAgfCAgNCArKy0tCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jIHwgIDIgKysKPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jICAgICAgICAgICAgfCAgNCArKysrCj4gICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmggICAgIHwgIDYgKysrKysrCj4gICA1IGZpbGVzIGNo YW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9wbXUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfcG11LmMKPiBpbmRleCAxYzBlZTlkNjhiMDQuLmU4ZTJmYWY0OTgyZiAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3BtdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9wbXUuYwo+IEBAIC05MCwxMSArOTAsNiBAQCBzdGF0aWMgdW5zaWduZWQgaW50 IGV2ZW50X2VuYWJsZWRfYml0KHN0cnVjdCBwZXJmX2V2ZW50ICpldmVudCkKPiAgIAlyZXR1cm4g Y29uZmlnX2VuYWJsZWRfYml0KGV2ZW50LT5hdHRyLmNvbmZpZyk7Cj4gICB9Cj4gICAKPiAtc3Rh dGljIGJvb2wgc3VwcG9ydHNfYnVzeV9zdGF0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkx NSkKPiAtewo+IC0JcmV0dXJuIElOVEVMX0dFTihpOTE1KSA+PSA4Owo+IC19Cj4gLQo+ICAgc3Rh dGljIGJvb2wgcG11X25lZWRzX3RpbWVyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LCBi b29sIGdwdV9hY3RpdmUpCj4gICB7Cj4gICAJdTY0IGVuYWJsZTsKPiBAQCAtMTIzLDggKzExOCwx MCBAQCBzdGF0aWMgYm9vbCBwbXVfbmVlZHNfdGltZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg Kmk5MTUsIGJvb2wgZ3B1X2FjdGl2ZSkKPiAgIAkvKgo+ICAgCSAqIEFsc28gdGhlcmUgaXMgc29m dHdhcmUgYnVzeW5lc3MgdHJhY2tpbmcgYXZhaWxhYmxlIHdlIGRvIG5vdAo+ICAgCSAqIG5lZWQg dGhlIHRpbWVyIGZvciBJOTE1X1NBTVBMRV9CVVNZIGNvdW50ZXIuCj4gKwkgKgo+ICsJICogVXNl IFJDUyBhcyBwcm94eSBmb3IgYWxsIGVuZ2luZXMuCj4gICAJICovCj4gLQllbHNlIGlmIChzdXBw b3J0c19idXN5X3N0YXRzKGk5MTUpKQo+ICsJZWxzZSBpZiAoaW50ZWxfZW5naW5lX3N1cHBvcnRz X3N0YXRzKGk5MTUtPmVuZ2luZVtSQ1NdKSkKPiAgIAkJZW5hYmxlICY9IH5CSVQoSTkxNV9TQU1Q TEVfQlVTWSk7Cj4gICAKPiAgIAkvKgo+IEBAIC00NDcsNyArNDQ0LDcgQEAgc3RhdGljIHZvaWQg aTkxNV9wbXVfZXZlbnRfcmVhZChzdHJ1Y3QgcGVyZl9ldmVudCAqZXZlbnQpCj4gICAKPiAgIHN0 YXRpYyBib29sIGVuZ2luZV9uZWVkc19idXN5X3N0YXRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiAgIHsKPiAtCXJldHVybiBzdXBwb3J0c19idXN5X3N0YXRzKGVuZ2luZS0+aTkx NSkgJiYKPiArCXJldHVybiBpbnRlbF9lbmdpbmVfc3VwcG9ydHNfc3RhdHMoZW5naW5lKSAmJgo+ ICAgCSAgICAgICAoZW5naW5lLT5wbXUuZW5hYmxlICYgQklUKEk5MTVfU0FNUExFX0JVU1kpKTsK PiAgIH0KPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdp bmVfY3MuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jCj4gaW5kZXgg ZmVkZTYyZGFmM2UxLi5jZmZkMGM4MTJiN2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9lbmdpbmVfY3MuYwo+IEBAIC0xODYzLDcgKzE4NjMsNyBAQCBpbnQgaW50ZWxfZW5hYmxlX2Vu Z2luZV9zdGF0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICB7Cj4gICAJdW5z aWduZWQgbG9uZyBmbGFnczsKPiAgIAo+IC0JaWYgKElOVEVMX0dFTihlbmdpbmUtPmk5MTUpIDwg OCkKPiArCWlmICghaW50ZWxfZW5naW5lX3N1cHBvcnRzX3N0YXRzKGVuZ2luZSkpCj4gICAJCXJl dHVybiAtRU5PREVWOwo+ICAgCj4gICAJc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2luZS0+c3RhdHMu bG9jaywgZmxhZ3MpOwo+IEBAIC0xOTI0LDcgKzE5MjQsNyBAQCB2b2lkIGludGVsX2Rpc2FibGVf ZW5naW5lX3N0YXRzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAl1 bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAgCj4gLQlpZiAoSU5URUxfR0VOKGVuZ2luZS0+aTkxNSkg PCA4KQo+ICsJaWYgKCFpbnRlbF9lbmdpbmVfc3VwcG9ydHNfc3RhdHMoZW5naW5lKSkKPiAgIAkJ cmV0dXJuOwo+ICAgCj4gICAJc3Bpbl9sb2NrX2lycXNhdmUoJmVuZ2luZS0+c3RhdHMubG9jaywg ZmxhZ3MpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfc3Vi bWlzc2lvbi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3N1Ym1pc3Npb24uYwo+ IGluZGV4IGNmMWNjMmNiNjcyMi4uOTEyZmYxNDNkNTMxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Y19zdWJtaXNzaW9uLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWNfc3VibWlzc2lvbi5jCj4gQEAgLTE0NTMsNiArMTQ1Myw4IEBAIGlu dCBpbnRlbF9ndWNfc3VibWlzc2lvbl9lbmFibGUoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICAg CQlleGVjbGlzdHMtPnRhc2tsZXQuZnVuYyA9IGd1Y19zdWJtaXNzaW9uX3Rhc2tsZXQ7Cj4gICAJ CWVuZ2luZS0+cGFyayA9IGd1Y19zdWJtaXNzaW9uX3Bhcms7Cj4gICAJCWVuZ2luZS0+dW5wYXJr ID0gZ3VjX3N1Ym1pc3Npb25fdW5wYXJrOwo+ICsKPiArCQllbmdpbmUtPmZsYWdzICY9IH5JOTE1 X0VOR0lORV9TVVBQT1JUU19TVEFUUzsKPiAgIAl9Cj4gICAKPiAgIAlyZXR1cm4gMDsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9scmMuYwo+IGluZGV4IDU3MDg2NDU4M2UyOC4uZWY1MTNlMWMxMGYzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiBAQCAtMTkxOSw2ICsxOTE5LDggQEAgc3Rh dGljIHZvaWQgZXhlY2xpc3RzX3NldF9kZWZhdWx0X3N1Ym1pc3Npb24oc3RydWN0IGludGVsX2Vu Z2luZV9jcyAqZW5naW5lKQo+ICAgCj4gICAJZW5naW5lLT5wYXJrID0gTlVMTDsKPiAgIAllbmdp bmUtPnVucGFyayA9IE5VTEw7Cj4gKwo+ICsJZW5naW5lLT5mbGFncyB8PSBJOTE1X0VOR0lORV9T VVBQT1JUU19TVEFUUzsKPiAgIH0KPiAgIAo+ICAgc3RhdGljIHZvaWQKPiBAQCAtMTk2Myw2ICsx OTY1LDggQEAgbG9naWNhbF9yaW5nX3NldHVwKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZSkKPiAgIAkvKiBJbnRlbnRpb25hbGx5IGxlZnQgYmxhbmsuICovCj4gICAJZW5naW5lLT5idWZm ZXIgPSBOVUxMOwo+ICAgCj4gKwllbmdpbmUtPmZsYWdzIHw9IEk5MTVfRU5HSU5FX1NVUFBPUlRT X1NUQVRTOwo+ICsKPiAgIAlmd19kb21haW5zID0gaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9mb3Jf cmVnKGRldl9wcml2LAo+ICAgCQkJCQkJICAgIFJJTkdfRUxTUChlbmdpbmUpLAo+ICAgCQkJCQkJ ICAgIEZXX1JFR19XUklURSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3JpbmdidWZmZXIuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIu aAo+IGluZGV4IGE5MWNlNjNiODhiNi4uYzY4YWIzZWFkODNjIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3JpbmdidWZmZXIuaAo+IEBAIC01NDAsNiArNTQwLDcgQEAgc3RydWN0IGlu dGVsX2VuZ2luZV9jcyB7Cj4gICAJc3RydWN0IGludGVsX2VuZ2luZV9oYW5nY2hlY2sgaGFuZ2No ZWNrOwo+ICAgCj4gICAjZGVmaW5lIEk5MTVfRU5HSU5FX05FRURTX0NNRF9QQVJTRVIgQklUKDAp Cj4gKyNkZWZpbmUgSTkxNV9FTkdJTkVfU1VQUE9SVFNfU1RBVFMgICBCSVQoMSkKPiAgIAl1bnNp Z25lZCBpbnQgZmxhZ3M7Cj4gICAKPiAgIAkvKgo+IEBAIC02MDQsNiArNjA1LDExIEBAIHN0YXRp YyBpbmxpbmUgYm9vbCBpbnRlbF9lbmdpbmVfbmVlZHNfY21kX3BhcnNlcihzdHJ1Y3QgaW50ZWxf ZW5naW5lX2NzICplbmdpbmUpCj4gICAJcmV0dXJuIGVuZ2luZS0+ZmxhZ3MgJiBJOTE1X0VOR0lO RV9ORUVEU19DTURfUEFSU0VSOwo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgYm9vbCBpbnRl bF9lbmdpbmVfc3VwcG9ydHNfc3RhdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ ICt7Cj4gKwlyZXR1cm4gZW5naW5lLT5mbGFncyAmIEk5MTVfRU5HSU5FX1NVUFBPUlRTX1NUQVRT Owo+ICt9Cj4gKwo+ICAgc3RhdGljIGlubGluZSB2b2lkCj4gICBleGVjbGlzdHNfc2V0X2FjdGl2 ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzLAo+ICAgCQkgICAgIHVu c2lnbmVkIGludCBiaXQpCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK