From: Leo Li Subject: Re: [PATCH] drm: Get ref on CRTC commit object when waiting for flip_done Date: Fri, 12 Oct 2018 17:28:04 -0400 Message-ID: <9d922ba0-80ca-873c-a5dd-07da61bd9988@amd.com> References: <1539304063-9518-1-git-send-email-sunpeng.li@amd.com> <20181012073403.GM31561@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-eopbgr730062.outbound.protection.outlook.com [40.107.73.62]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2D2526E001 for ; Fri, 12 Oct 2018 21:28:11 +0000 (UTC) In-Reply-To: <20181012073403.GM31561@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org CgpPbiAyMDE4LTEwLTEyIDAzOjM0IEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIFRodSwg T2N0IDExLCAyMDE4IGF0IDA4OjI3OjQzUE0gLTA0MDAsIHN1bnBlbmcubGlAYW1kLmNvbSB3cm90 ZToKPj4gRnJvbTogTGVvIExpIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4+Cj4+IFRoaXMgZml4ZXMg YSBnZW5lcmFsIHByb3RlY3Rpb24gZmF1bHQsIGNhdXNlZCBieSBhY2Nlc3NpbmcgdGhlIGNvbnRl bnRzCj4+IG9mIGEgZmxpcF9kb25lIGNvbXBsZXRpb24gb2JqZWN0IHRoYXQgaGFzIGFscmVhZHkg YmVlbiBmcmVlZC4gSXQgb2NjdXJzCj4+IGR1ZSB0byB0aGUgcHJlZW1wdGlvbiBvZiBhIG5vbi1i bG9ja2luZyBjb21taXQgd29ya2VyIHRocmVhZCBXIGJ5Cj4+IGFub3RoZXIgY29tbWl0IHRocmVh ZCBYLiBYIGNvbnRpbnVlcyB0byBjbGVhciBpdHMgYXRvbWljIHN0YXRlIGF0IHRoZQo+PiBlbmQs IGRlc3Ryb3lpbmcgdGhlIENSVEMgY29tbWl0IG9iamVjdCB0aGF0IFcgc3RpbGwgbmVlZHMuIFN3 aXRjaGluZwo+PiBiYWNrIHRvIFcgYW5kIGFjY2Vzc2luZyB0aGUgY29tbWl0IG9iamVjdHMgdGhl biBsZWFkcyB0byBiYWQgcmVzdWx0cy4KPj4KPj4gV29ya2VyIFcgYmVjb21lcyBwcmVlbXB0YWJs ZSB3aGVuIHdhaXRpbmcgZm9yIGZsaXBfZG9uZSB0byBjb21wbGV0ZS4gQXQKPj4gdGhpcyBwb2lu dCwgYSBmcmVxdWVudGx5IG9jY3VycmluZyBjb21taXQgdGhyZWFkIFggY2FuIHRha2Ugb3Zlci4g SGVyZSdzCj4+IGFuIGV4YW1wbGUgd2hlcmUgVyBpcyBhIHdvcmtlciB0aHJlYWQgdGhhdCBmbGlw cyBvbiBib3RoIENSVENzLCBhbmQgWAo+PiBkb2VzIGEgbGVnYWN5IGN1cnNvciB1cGRhdGUgb24g Ym90aCBDUlRDczoKPj4KPj4gICAgICAgICAgLi4uCj4+ICAgICAgIDEuIFcgZG9lcyBmbGlwIHdv cmsKPj4gICAgICAgMi4gVyBydW5zIGNvbW1pdF9od19kb25lKCkKPj4gICAgICAgMy4gVyB3YWl0 cyBmb3IgZmxpcF9kb25lIG9uIENSVEMgMQo+PiAgICAgICA0LiA+IGZsaXBfZG9uZSBmb3IgQ1JU QyAxIGNvbXBsZXRlcwo+PiAgICAgICA1LiBXIGZpbmlzaGVzIHdhaXRpbmcgZm9yIENSVEMgMQo+ PiAgICAgICA2LiBXIHdhaXRzIGZvciBmbGlwX2RvbmUgb24gQ1JUQyAyCj4+Cj4+ICAgICAgIDcu ID4gUHJlZW1wdGVkIGJ5IFgKPj4gICAgICAgOC4gPiBmbGlwX2RvbmUgZm9yIENSVEMgMiBjb21w bGV0ZXMKPj4gICAgICAgOS4gWCBhdG9taWNfY2hlY2s6IGh3X2RvbmUgYW5kIGZsaXBfZG9uZSBh cmUgY29tcGxldGUgb24gYWxsIENSVENzCj4+ICAgICAgMTAuIFggdXBkYXRlcyBjdXJzb3Igb24g Ym90aCBDUlRDcwo+PiAgICAgIDExLiBYIGRlc3Ryb3lzIGF0b21pYyBzdGF0ZQo+PiAgICAgIDEy LiBYIGRvbmUKPj4KPj4gICAgICAxMy4gPiBTd2l0Y2ggYmFjayB0byBXCj4+ICAgICAgMTQuIFcg d2FpdHMgZm9yIGZsaXBfZG9uZSBvbiBDUlRDIDIKPj4gICAgICAxNS4gVyByYWlzZXMgZ2VuZXJh bCBwcm90ZWN0aW9uIGZhdWx0Cj4+Cj4+IFRoZSBlcnJvciBsb29rcyBsaWtlIHNvOgo+Pgo+PiAg ICAgIGdlbmVyYWwgcHJvdGVjdGlvbiBmYXVsdDogMDAwMCBbIzFdIFBSRUVNUFQgU01QIFBUSQo+ PiAgICAgICoqc25pcCoqCj4+ICAgICAgQ2FsbCBUcmFjZToKPj4gICAgICAgbG9ja19hY3F1aXJl KzB4YTIvMHgxYjAKPj4gICAgICAgX3Jhd19zcGluX2xvY2tfaXJxKzB4MzkvMHg3MAo+PiAgICAg ICB3YWl0X2Zvcl9jb21wbGV0aW9uX3RpbWVvdXQrMHgzMS8weDEzMAo+PiAgICAgICBkcm1fYXRv bWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUrMHg2NC8weDkwIFtkcm1fa21zX2hlbHBlcl0K Pj4gICAgICAgYW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbCsweGNhZS8weGRkMCBbYW1kZ3B1 XQo+PiAgICAgICBjb21taXRfdGFpbCsweDNkLzB4NzAgW2RybV9rbXNfaGVscGVyXQo+PiAgICAg ICBwcm9jZXNzX29uZV93b3JrKzB4MjEyLzB4NjUwCj4+ICAgICAgIHdvcmtlcl90aHJlYWQrMHg0 OS8weDQyMAo+PiAgICAgICBrdGhyZWFkKzB4ZmIvMHgxMzAKPj4gICAgICAgcmV0X2Zyb21fZm9y aysweDNhLzB4NTAKPj4gICAgICBNb2R1bGVzIGxpbmtlZCBpbjogeDg2X3BrZ190ZW1wX3RoZXJt YWwgYW1kZ3B1KE8pIGNoYXNoKE8pCj4+ICAgICAgZ3B1X3NjaGVkKE8pIGRybV9rbXNfaGVscGVy KE8pIHN5c2NvcHlhcmVhIHN5c2ZpbGxyZWN0IHN5c2ltZ2JsdAo+PiAgICAgIGZiX3N5c19mb3Bz IHR0bShPKSBkcm0oTykKPj4KPj4gTm90ZSB0aGF0IGk5MTUgaGFzIHRoaXMgaXNzdWUgbWFza2Vk LCBzaW5jZSBod19kb25lIGlzIHNpZ25hbGVkIGFmdGVyCj4+IHdhaXRpbmcgZm9yIGZsaXBfZG9u ZS4gRG9pbmcgc28gd2lsbCBibG9jayB0aGUgY3Vyc29yIHVwZGF0ZSBmcm9tCj4+IGhhcHBlbmlu ZyB1bnRpbCBod19kb25lIGlzIHNpZ25hbGVkLCBwcmV2ZW50aW5nIHRoZSBjdXJzb3IgY29tbWl0 IGZyb20KPj4gZGVzdHJveWluZyB0aGUgc3RhdGUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IExlbyBM aSA8c3VucGVuZy5saUBhbWQuY29tPgo+IAo+IEdyZWF0IGFuYWx5c2lzIQo+IAo+IEJ1Z2ZpeCBp dHNlbGYgbmVlZHMgYSBiaXQgbW9yZSB3b3JrIHRob3VnaCwgc2VlIGJlbG93Lgo+IAo+PiAtLS0K Pj4gICBkcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyB8IDMwICsrKysrKysrKysr KysrKysrKysrKysrKysrLS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9h dG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+PiBp bmRleCA4MGJlNzRkLi5lZmRmMDQzIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pY19oZWxwZXIuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxw ZXIuYwo+PiBAQCAtMTQxMCwyMCArMTQxMCw0MiBAQCB2b2lkIGRybV9hdG9taWNfaGVscGVyX3dh aXRfZm9yX2ZsaXBfZG9uZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgIHsKPj4gICAJc3Ry dWN0IGRybV9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZTsKPj4gICAJc3RydWN0IGRybV9jcnRj ICpjcnRjOwo+PiArCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKipjb21taXRzOwo+PiAgIAlpbnQg aTsKPj4gKwlpbnQgbnVtX2NydGMgPSBkZXYtPm1vZGVfY29uZmlnLm51bV9jcnRjOwo+PiAgIAo+ PiArCWNvbW1pdHMgPSBrY2FsbG9jKG51bV9jcnRjLCBzaXplb2YoKmNvbW1pdHMpLCBHRlBfS0VS TkVMKTsKPj4gKwo+PiArCS8qCj4+ICsJICogQmVjYXVzZSB3ZSBvcGVuIG91cnNlbHZlcyB0byBw cmVlbXB0aW9uIGJ5IGNhbGxpbmcKPj4gKwkgKiB3YWl0X2Zvcl9jb21wbGV0aW9uX3RpbWVvdXQo KSwgd2UgbmVlZCB0byBnZXQgb3VyIG93biByZWZlcmVuY2VzIHRvCj4+ICsJICogdGhlIGNvbW1p dCBvYmplY3RzLiBUaGlzIGlzIHNvIHRoYXQgYSBwcmVlbXB0aW5nIGNvbW1pdCB3b24ndCBmcmVl Cj4+ICsJICogdGhlbS4KPj4gKwkgKi8KPiAKPiBUaGUgc2NoZWR1bGVyIGNhbiBwcmVlbXB0IHlv dSBhdCBhbnkgcG9pbnQgYmVmb3JlIGhlcmUgdG9vLCBpZiB5b3UgZW5hYmxlCj4gQ09ORklHX1BS RUVNUFQuIEl0IGRlZmluaXRlbHkgY2FuIHByZWVtcHQvYmxvY2sgaW4gdGhlIGtjYWxsb2MgYWJv dmUsIGV2ZW4KPiBpZiB5b3UgaGF2ZSBDT05GSUdfUFJFRU1QVCBkaXNhYmxlZC4gVGhlIHNjaGVk dWxpbmcgcG9pbnQgeW91IGlkZW50aWZpZWQKPiBiZWxvdyBpcyBzaW1wbHkgdGhlIG1vc3QgbGlr ZWx5Lgo+IAoKQWgsIGRpZG4ndCB0aGluayBvZiB0aGlzLgoKPiBUaGUgdW5kZXJseWluZyBidWcg aXMgdGhhdCBhZnRlciBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgpIHdlCj4gdW5i bG9jayB0aGUgbmV4dCBjb21taXQgd29ya2VyICh0aHJlYWQgWCBpbiB5b3VyIGV4YW1wbGUpLCBh bmQgY2Fubm90Cj4gYXNzdW1lIGFueW1vcmUgdGhhdCB0aGUgbmV3IHN0YXRlIHdpbGwgc3RheSBh cm91bmQgKHNpbmNlIG5ldyBzdGF0ZSBpcwo+IHJlbGVhc2VkIGJ5IHRoZSBzdWJzZXF1ZW50IGNv bW1pdCB3b3JrIHJ1biBpbiB0aHJlYWQgWCkuCj4gCj4gVGhlcmVmb3JlIHlvdXIgZHJtX2NydGNf Y29tbWl0X2dldCBoZXJlIGFscmVhZHkgY2FuIGFjY2VzcyBmcmVlZCBtZW1vcnkuCj4gVGhlIGNv cnJlY3QgZml4IGhlcmUgaXMgdG8gc3RvcmUgdGhlIHRlbXBvcmFyeSByZWZlcmVuY2UgYmVmb3Jl IHdlIGNhbGwKPiBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZSgpLCBhbmQgdGhlbiB1 c2UgdGhhdCBpbiB0aGlzIGZ1bmN0aW9uCj4gaGVyZS4gVGhlIHByb2JsZW0gaXMgdGhhdCB0aGlz IGlzIHNvbWV3aGF0IHRyaWNreSB0byBwdWxsIG9mZiwgc2luY2Ugc29tZQo+IGRyaXZlcnMgY2Fs bCB3YWl0X2Zvcl9mbGlwX2RvbmUoKSBiZWZvcmUgaHdfZG9uZSgpIChsaWtlIGk5MTUpLgo+IAo+ IEhlcmUncyB3aGF0IEknZCBkbzoKPiAtIEFkZCBhIG5ldyBkcm1fY3J0Y19jb21taXQgcG9pbnRl ciB0byBzdHJ1Y3QgX19kcm1fY3J0Y3Nfc3RhdGUuCj4gCj4gLSBGaWxsIHRoYXQgb3V0IGluIGRy bV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdCwgYW5kIG1ha2Ugc3VyZSB5b3UKPiAgICByZWxl YXNlIHRoZSByZWZlcmVuY2UgZm9yIGl0IGluIGRybV9hdG9taWNfc3RhdGVfZGVmYXVsdF9jbGVh cigpLgo+IAo+IC0gVXNlIHRoYXQgcG9pbnRlciBpbnN0ZWFkIGluIGRybV9hdG9taWNfaGVscGVy X3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGhlcmUuCgpUaGFua3MgZm9yIHRoZSBwb2ludGVycywgcGF0 Y2ggaW5jb21pbmcgOikKCkxlbwoKPiAKPiBDaGVlcnMsIERhbmllbAo+PiAgIAlmb3JfZWFjaF9u ZXdfY3J0Y19pbl9zdGF0ZShvbGRfc3RhdGUsIGNydGMsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4+ IC0JCXN0cnVjdCBkcm1fY3J0Y19jb21taXQgKmNvbW1pdCA9IG5ld19jcnRjX3N0YXRlLT5jb21t aXQ7Cj4+ICsJCWNvbW1pdHNbaV0gPSBuZXdfY3J0Y19zdGF0ZS0+Y29tbWl0Owo+PiArCQlpZiAo Y29tbWl0c1tpXSkKPj4gKwkJCWRybV9jcnRjX2NvbW1pdF9nZXQoY29tbWl0c1tpXSk7Cj4+ICsJ fQo+PiArCj4+ICsJZm9yIChpID0gMDsgaSA8IG51bV9jcnRjOyBpKyspIHsKPj4gICAJCWludCBy ZXQ7Cj4+ICAgCj4+IC0JCWlmICghY29tbWl0KQo+PiArCQlpZiAoIWNvbW1pdHNbaV0pCj4+ICAg CQkJY29udGludWU7Cj4+ICAgCj4+IC0JCXJldCA9IHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91 dCgmY29tbWl0LT5mbGlwX2RvbmUsIDEwICogSFopOwo+PiArCQlyZXQgPSB3YWl0X2Zvcl9jb21w bGV0aW9uX3RpbWVvdXQoJmNvbW1pdHNbaV0tPmZsaXBfZG9uZSwKPj4gKwkJCQkJCSAgMTAgKiBI Wik7Cj4+ICAgCQlpZiAocmV0ID09IDApCj4+ICAgCQkJRFJNX0VSUk9SKCJbQ1JUQzolZDolc10g ZmxpcF9kb25lIHRpbWVkIG91dFxuIiwKPj4gLQkJCQkgIGNydGMtPmJhc2UuaWQsIGNydGMtPm5h bWUpOwo+PiArCQkJCSAgY29tbWl0c1tpXS0+Y3J0Yy0+YmFzZS5pZCwKPj4gKwkJCQkgIGNvbW1p dHNbaV0tPmNydGMtPm5hbWUpOwo+PiAgIAl9Cj4+ICsKPj4gKwlmb3IgKGkgPSAwOyBpIDwgbnVt X2NydGM7IGkrKykKPj4gKwkJaWYgKGNvbW1pdHNbaV0pCj4+ICsJCQlkcm1fY3J0Y19jb21taXRf cHV0KGNvbW1pdHNbaV0pOwo+PiArCWtmcmVlKGNvbW1pdHMpOwo+PiAgIH0KPj4gICBFWFBPUlRf U1lNQk9MKGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSk7Cj4+ICAgCj4+IC0t IAo+PiAyLjcuNAo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==