Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B9DCC77B7A for ; Fri, 26 May 2023 00:34:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5B24384770; Fri, 26 May 2023 02:34:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UmXz6KG8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 035B78600A; Fri, 26 May 2023 02:34:53 +0200 (CEST) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 23DA78474B for ; Fri, 26 May 2023 02:34:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-64d577071a6so468534b3a.1 for ; Thu, 25 May 2023 17:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685061288; x=1687653288; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y6RLPxWWONnP2t7Y3vHdYYSDGwimwEnQezynb4H1HTc=; b=UmXz6KG8UJfR3Rlr2/I61o6lJzNeTLPBXY7d3WcxuJYTnTxbNvsQKU8yk35QtpQi51 XY1sC5lKePg/599jN+jztQl9d1ngJN+PhjGuZJLlEFddxaXUov6NwxoE2Ys422p4hiLZ zNcIRSBAPjhKMG2Chfyx9LePJSbaVvwpCGevpj7NTjB29WUEB9hP44VT5KMS9Eae9ODr 17kEenP6hwM8/o3PBFWdaExj3WiaXXcE/6bKCzPnfH9heR9CFr8CzXGnguyPwc+2Or9x eRT2/TmhxIRh+FUTSXRf9eHBQ6WHvjGpjnHS057B/9d2ObU8J7K8MEP28EXGYswEc63k xpLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685061288; x=1687653288; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y6RLPxWWONnP2t7Y3vHdYYSDGwimwEnQezynb4H1HTc=; b=TnG8xkFEI1bppXzGOJe7O9mv2LIwFkjp8BRPBON6y+PlEFU0St2piJ0A7BZWU/whbi 8D4qh6VtD6jeRfhEIbuXAyQdEB2zoif71Wc6Jc686UiBKjkIGMmPCYGr2Q3WRK5SlLfc HpfooIceVMnVdi3LhiakY6hmwoQSUOGBXwiLscEFBpVE6CaiSPBRNAcQ4u+rn5plOuHv 3ibXjsIZ98OE7slZWUvITIT/+DIemDs92ogyGI0/mvBl8G6pk0rp5R8hyHtq52+d9c1p YdoTk4NuoOUr+kxAASGsHG9tgr/ZxSAETSa5WzDmLN+GOQ4KxQG0/GoVgTYY6mLB0UiT xh5A== X-Gm-Message-State: AC+VfDyALRajG6D5EDU28gjZko9hwpqGpC3kJOLzBESSoUqK0rVZ0j+f WHh77fVoNC+mJsZi/p5mlBe7Z6Wj98C0xQ== X-Google-Smtp-Source: ACHHUZ4EZgIWzTT0Eouf++s0tE7tvvb/DVrtkX+DZ7YEoMm/QGXKqrjT6oyYMeeGbTWecMU6DesC1A== X-Received: by 2002:a05:6a00:1809:b0:643:aa2:4dcd with SMTP id y9-20020a056a00180900b006430aa24dcdmr769297pfa.16.1685061287972; Thu, 25 May 2023 17:34:47 -0700 (PDT) Received: from [10.64.107.252] (static-198-54-134-172.cust.tzulo.com. [198.54.134.172]) by smtp.gmail.com with ESMTPSA id d22-20020aa78156000000b0063d3d776910sm1655215pfn.138.2023.05.25.17.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 17:34:47 -0700 (PDT) Message-ID: <9d95e7f4-4ec2-b025-df11-22e2101b1fc9@gmail.com> Date: Thu, 25 May 2023 18:34:45 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RFC PATCH 10/17] clk: sunxi: Add support for the D1 CCU Content-Language: en-US To: u-boot@lists.denx.de, Andre Przywara References: <20221206004549.29015-1-andre.przywara@arm.com> <20221206004549.29015-11-andre.przywara@arm.com> From: Sam Edwards In-Reply-To: <20221206004549.29015-11-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi again Andre, On 12/5/22 17:45, Andre Przywara wrote: > +static struct ccu_clk_gate d1_gates[] = { > + [CLK_BUS_MMC0] = GATE(0x84c, BIT(0)), > + [CLK_BUS_MMC1] = GATE(0x84c, BIT(1)), > + [CLK_BUS_MMC2] = GATE(0x84c, BIT(2)), > + [CLK_BUS_UART0] = GATE(0x90c, BIT(0)), > + [CLK_BUS_UART1] = GATE(0x90c, BIT(1)), > + [CLK_BUS_UART2] = GATE(0x90c, BIT(2)), > + [CLK_BUS_UART3] = GATE(0x90c, BIT(3)), > + [CLK_BUS_UART4] = GATE(0x90c, BIT(4)), > + [CLK_BUS_UART5] = GATE(0x90c, BIT(5)), > + [CLK_BUS_I2C0] = GATE(0x91c, BIT(0)), > + [CLK_BUS_I2C1] = GATE(0x91c, BIT(1)), > + [CLK_BUS_I2C2] = GATE(0x91c, BIT(2)), > + [CLK_BUS_I2C3] = GATE(0x91c, BIT(3)), > + [CLK_SPI0] = GATE(0x940, BIT(31)), > + [CLK_SPI1] = GATE(0x944, BIT(31)), > + [CLK_BUS_SPI0] = GATE(0x96c, BIT(0)), > + [CLK_BUS_SPI1] = GATE(0x96c, BIT(1)), > + > + [CLK_BUS_EMAC] = GATE(0x97c, BIT(0)), > + > + [CLK_USB_OHCI0] = GATE(0xa70, BIT(31)), > + [CLK_USB_OHCI1] = GATE(0xa74, BIT(31)), > + [CLK_BUS_OHCI0] = GATE(0xa8c, BIT(0)), > + [CLK_BUS_OHCI1] = GATE(0xa8c, BIT(1)), > + [CLK_BUS_EHCI0] = GATE(0xa8c, BIT(4)), > + [CLK_BUS_EHCI1] = GATE(0xa8c, BIT(5)), > + [CLK_BUS_OTG] = GATE(0xa8c, BIT(8)), > + [CLK_BUS_LRADC] = GATE(0xa9c, BIT(0)), > + > + [CLK_RISCV] = GATE(0xd04, BIT(31)), > +}; Would it be reasonable to add (possibly one for APB1 also): [CLK_APB0] = GATE_DUMMY, ...in order to suppress this warning at init: sunxi_set_gate: (CLK#24) unhandled As I understand it, CLK_APB0 is only for speed control and doesn't have a gate, but since the FDT references it, other drivers are asking the clock driver to ungate it, resulting in that (safe-to-ignore) warning. Warm regards, Sam PS: Do you have any plans for PSCI support, so we can get the second core up too? I'd like to patch that in and include it in your series once my available time permits. Just thought I'd check that you/someone wasn't working on it already. :)