From: Sean Anderson Date: Tue, 27 Oct 2020 16:33:10 -0400 Subject: [PATCH v2 21/30] patman: Require tags to be before sign-off In-Reply-To: <20201027060532.GI2645313@google.com> References: <20201026010442.1606893-1-sjg@chromium.org> <20201026010442.1606893-22-sjg@chromium.org> <4efd0586-e31d-6dbe-b8b7-3c17a7c3d888@gmail.com> <20201027060532.GI2645313@google.com> Message-ID: <9d9cb0ec-ee52-b3a9-d3a6-5ce1f25526fa@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 10/27/20 2:05 AM, Jonathan Nieder wrote: > Simon Glass wrote: >> On Sun, 25 Oct 2020 at 19:23, Sean Anderson wrote: > >>> I also like to put SOBs on top because it groups all the commit-specific >>> information before any patman-specific tags. The last commit (the HEAD) >>> usually has several tags (Series-to/cc, Series-process-log, >>> Cover-letter, etc.) which are unrelated to the commit itself. >>> >>> The tool should do what is best for us humans, not what is convenient >>> for the tool. >> >> I suppose it can be done. But we have the same problem with Change-Id. >> Do you use gerit? I have occasionally used gerrit, but not on any projects where I also would like to use patman. I don't care about the Change-Id requirement. Using the following commit as an example, > doc: Update logging documentation > > This updates logging documentation with some examples of the new commands > added in the previous commits. It also removes some items from the to-do > list which have been implemented. > to confirm, you would like to force the next two lines to be placed last? > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass I like them in their current location, because everything above this line will be present in the final commit as it is applied. > Series-changes: 2 > - Clarify wording of filter documentation > - Reorganize log documentation; related sections should now be more proximate > - Include enum definitions instead of re-documenting them > - Add a few informational commands > > Series-changes: 3 > - Fix heading level of Filters section > - Remove a few more already-implemented features from the TODO list > Everything above this line will be present in the patch as it is emailed. > Series-version: 3 > Series-process-log: sort > Series-to: u-boot > Series-cc: sjg > Series-cc: trini > Series-cc: xypron > Cover-letter: > log: Add commands for manipulating filters > This series adds several commands for adding, listing, and removing log filters. > It also adds getopt, since the filter-add command needs to have several > optional arguments to be complete, and positional specification of those > arguments would have been difficult. > END > I assume this is mostly about Commit-Notes, when used without > following the rfc-style format that has subsequent lines indented. Can you elaborate a bit on what you're referring to? > > If so, then this issue isn't specific to Gerrit: it applies when using > Git directly (the "git interpret-trailers" command, "git commit > --amend --signoff", and so on). > > As long as you're following rfc822 syntax, all is fine, so in some > sense the issue here is the Commit-Notes tag. Should it go in the > commit message body instead of the trailer paragraph? > > Thanks, > Jonathan --Sean