From: "plaisthos (Code Review)" Date: Tue, 12 Dec 2023 12:11:27 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641..., gert@...1296... Message-ID: <9da6b25d4a6874f50c6cd682d2cc37ee19aede92-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="nu2sxfu5PgA="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: Check PRF availability on initialisation and add --force-tls-key-mate... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: cron2 , flichtenheld , openvpn-devel --nu2sxfu5PgA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/460?usp=3Demail ) Change subject: Check PRF availability on initialisation and add --force-tl= s-key-material-export ...................................................................... Patch Set 6: (2 comments) File src/openvpn/multi.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/09e5b596_0004b9ee : PS5, Line 1841: return false; > there is whitespace missing at the first and second line wrap ("thisserve= r" and "(RFC 5705)support" Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/460/comment/4bde8b54_2a323d2b : PS5, Line 3661: } > D'oh. Sorry for missing that. whoops sorry for that. My bash history also shows that I still had the opti= on on the command line, so I totally missed that. =F0=9F=98=9E -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/460?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee6ca89c7e86c70 Gerrit-Change-Number: 460 Gerrit-PatchSet: 6 Gerrit-Owner: plaisthos Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Tue, 12 Dec 2023 12:11:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 Comment-In-Reply-To: flichtenheld Gerrit-MessageType: comment --nu2sxfu5PgA= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: cron2, flichtenheld.

View C= hange

2 comments:

    =
  • File src/openvpn/multi.c:

    • Patch Set #5, Line 1841:= return false;

      there is whitespace missing at the first and second line = wrap ("thisserver" and "(RFC 5705)support"
      =

      Done

  • File src/openvpn/options= .c:

    • Patch Set #5, L= ine 3661: }

      D'oh. Sorry for missing that.

      whoops sorry for that.= My bash history also shows that I still had the option on the command line= , so I totally missed that. =F0=9F=98=9E

To view,= visit ch= ange 460. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04f8c7c413e7cb62c726262feee= 6ca89c7e86c70
Gerrit-Change-Number: 460
Gerrit-PatchSet: 6
Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: cron2 <gert@...1296...>= ;
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Tue, 12 Dec 2023 12:11:27= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <gert@...1296...= >
Comment-In-Reply-To: flichtenheld <frank@...1186...= .2641...>
Gerrit-MessageType: comment
--nu2sxfu5PgA=--