Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A12AC2BB55 for ; Thu, 16 Apr 2020 12:27:02 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A1B8206B9 for ; Thu, 16 Apr 2020 12:27:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=web.de header.i=@web.de header.b="m1bhOX/3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A1B8206B9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=web.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 03GCQhlD003893; Thu, 16 Apr 2020 14:26:43 +0200 (CEST) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id EE498781F; Thu, 16 Apr 2020 14:26:42 +0200 (CEST) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id C587B7816 for ; Thu, 16 Apr 2020 14:26:40 +0200 (CEST) Received: from mout.web.de (mout.web.de [212.227.17.11]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTPS id 03GCQdCB022670 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Thu, 16 Apr 2020 14:26:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587039998; bh=XuMU22+yDqMnebELxNATKq9rzGaxSG3+yY62WjZPmMs=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=m1bhOX/3vFE8ZZL/p5F123eVBpuacFle7yavRXrcgzjmt8R2iVtYJjazhr9akTqY2 axtA+L2KrJZtZHLfiAExweecLuDexSntLED+orx9njKIl+v+bbr+DPHamwBY6Oo98l nf9bs+pYroM+h2xmtSLlnXHkVlkm68kjc0BT/pXI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([2.243.109.113]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LkhFg-1ir5lC14Z2-00aYie; Thu, 16 Apr 2020 14:26:38 +0200 To: Julia Lawall References: <25b804fd-0d04-475d-f614-26c03c9fd544@web.de> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <9dd70cfc-71c8-d633-8a76-22cd9be1d7f9@web.de> Date: Thu, 16 Apr 2020 14:26:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:Vu0vgIq0SI+Qypty/1JgiJsvHc3vlldketpZVI00upR4H0KTcK3 qsX6tr5vTHPh1nTPutxciA2CWfxkmrO8tBjoEw6BB2XFOOvYgGqg5dHvvDCDj15HQG8HZgJ mb9IxU+oVJS2PGVSjgAH1akBCehvBTyGIfbfoQNhEAY0g+NSjv3c2ENcUm4METbzz1ocMik Iiy6zsERp/E4ZytDDLbKA== X-UI-Out-Filterresults: notjunk:1;V03:K0:lnjQkrNnX30=:Qei5RGtpKmoFzR4H6KLH1t e9OyUygLVJ2e0z6XTKau+1BzUkEGlZuhXtU8WmNPdyV87AmkW/XO0nyf7Xy9t5sZ20PIVSGXB 9gmRqgve/b7hr5SlQjotDWVRnu3rKZK8OyhUEJpZmWOzOI6X/Pk3Yd9wnX17iZ3XcrF6jX2by UMbYTEaD67AH5HZMMgh1va0yWLqxVsogfR7j5bC+ltLbF5OENlycaPU2EZxXMLY4BBmUSdb9U hIi6rSz3/0k6ruGnIkyK0OZLPAXDnPdBrineDm3kDEwOKOwCyz79QFIfx1SYTNh+QtmAMkGTl Q2HHK7PoQJYjElSGNVFzBXHuQjbkDQo0uCDNzsUdufPVm5+giJor2ZNAM74YYbU1/okr7GCYX bePRowsrpVoxhe6q6swlppeiLegeNtstmzfL4E52JZAeek+SM1g5N6+PJnwuewrb+MNSXBK+i qtCWoK7YkyRQ0pb+iBulFpC6/ZVgt2q7tmqKPYgc9ijEPTWKkBZ5+1XIN0wWKM22cKcBGeXwL 67TF1Zck233c7gHxU9pn9C5s5z/T5mTCGEFIs2OmG1vOKPWDqBTRDOQrTt8rQ+hD80MleWaha DAHb435Y++HdR64hkMqsl5eZJLZMMHGbsEvVUU9UmCpf3AosEj5EItxut1oSjiF/SUAv1j6EX kJDyjpTLmbWqfdUjMIuqawHdE5iGIH6JOz5PBQCk8tzzP47q9rki1Akgbc0VaGjL+N4J5kKIz 4n5W7JkI1Oo2n6w3bVYooV7gwgJR6JzdXMpgZ5xhbVdt/EnXsHp9OY9CKldv9TAYMbYRlXBLA 8FgIH1AR1olm1eGQT55/vGApFhlPgKxYKx6+1Sn474bWOw6N0pUbyf5UYlQIflj8vU6HpZzdE YXbafWS8WNXKLci5lFXvNRAaknPMZt1Rzzu7Qhb4jFyNlM1QMVCeTaiWykbM6+eh4/QffSbk4 ieF3jtV289WPaTX2y3ITQEo1qyNlOg268s5hArnic9gSKQSjYAzGmX0m8Z9O6og3wmFzd7pjJ vieYwbqPd/Gu51n9j8RYno1sYyZvEiepwNwOYktvbf3ePM6wp+DdzMFG2eWnPQdElvxdgETKV 0qNvGknrkJoFJSvAXZa7rjFxJUaFUwnzf//64vawl2QjtF6sjD1gMGk28mvV64X/02FoGDySl CY6I4CkT2oLCeVrMAXOYBH/mg5KFOaNOs1PojzyIqVnWvMAzDCzNdt48K1umYknD6RhhvVhJD tkwP4OJMx1NlE+zIu X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 16 Apr 2020 14:26:43 +0200 (CEST) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Thu, 16 Apr 2020 14:26:39 +0200 (CEST) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: Dejin Zheng , Coccinelle Subject: Re: [Cocci] Checking the replacement of two specific function calls X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr > I don't think that there is any need for the * in the metavariable declaration. I can try another SmPL script variant out also without the specification of an extra asterisk. If I test with the following source file example, a patch is generated by the Coccinelle software in the expected way. // SPDX-License-Identifier: GPL-2.0 static int rcar_i2c_probe(struct platform_device *pdev) { struct rcar_i2c_priv *priv; priv->res = platform_get_resource(pdev, IORESOURCE_MEM, 0); priv->io = devm_ioremap_resource(&pdev->dev, priv->res); if (IS_ERR(priv->io)) return PTR_ERR(priv->io); } Command example: elfring@Sonne:~/Projekte/Coccinelle/janitor> spatch use_devm_platform_get_and_ioremap_resource3.cocci ../Probe/i2c-rcar-variant-20200416.c Implementation details from the original source file trigger some software development challenges. https://elixir.bootlin.com/linux/v5.7-rc1/source/drivers/i2c/busses/i2c-rcar.c#L921 https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/busses/i2c-rcar.c?id=8632e9b5645bbc2331d21d892b0d6961c1a08429#n921 Regards, Markus _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci