From: Markus Elfring Date: Sun, 05 Apr 2020 17:19:34 +0000 Subject: [PATCH] virtio-mmio: Delete an error message in vm_find_vqs() Message-Id: <9e27bc4a-cfa1-7818-dc25-8ad308816b30@web.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: virtualization@lists.linux-foundation.org, Jason Wang , "Michael S. Tsirkin" Cc: LKML , kernel-janitors@vger.kernel.org, Tang Bin From: Markus Elfring Date: Sun, 5 Apr 2020 19:14:10 +0200 The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/virtio/virtio_mmio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c index 97d5725fd9a2..9d16aaffca9d 100644 --- a/drivers/virtio/virtio_mmio.c +++ b/drivers/virtio/virtio_mmio.c @@ -466,10 +466,8 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned nvqs, int irq = platform_get_irq(vm_dev->pdev, 0); int i, err, queue_idx = 0; - if (irq < 0) { - dev_err(&vdev->dev, "Cannot get IRQ resource\n"); + if (irq < 0) return irq; - } err = request_irq(irq, vm_interrupt, IRQF_SHARED, dev_name(&vdev->dev), vm_dev); -- 2.26.0