From: Maarten Lankhorst Subject: Re: [PATCH] drm: fix call_kern.cocci warnings v2 Date: Thu, 25 Oct 2018 11:17:31 +0200 Message-ID: <9e30daec-88ad-fef7-01b8-abc886d0ecb6@linux.intel.com> References: <20181025085301.8217-1-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181025085301.8217-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T3AgMjUtMTAtMTggb20gMTA6NTMgc2NocmVlZiBDaHVubWluZyBaaG91Ogo+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMCj4KPiAgIEZpbmQgZnVuY3Rpb25zIHRoYXQg cmVmZXIgdG8gR0ZQX0tFUk5FTCBidXQgYXJlIGNhbGxlZCB3aXRoIGxvY2tzIGhlbGQuCj4KPiBT ZW1hbnRpYyBwYXRjaCBpbmZvcm1hdGlvbjoKPiAgIFRoZSBwcm9wb3NlZCBjaGFuZ2Ugb2YgY29u dmVydGluZyB0aGUgR0ZQX0tFUk5FTCBpcyBub3QgbmVjZXNzYXJpbHkgdGhlCj4gICBjb3JyZWN0 IG9uZS4gIEl0IG1heSBiZSBkZXNpcmVkIHRvIHVubG9jayB0aGUgbG9jaywgb3IgdG8gbm90IGNh bGwgdGhlCj4gICBmdW5jdGlvbiB1bmRlciB0aGUgbG9jayBpbiB0aGUgZmlyc3QgcGxhY2UuCj4K PiBHZW5lcmF0ZWQgYnk6IHNjcmlwdHMvY29jY2luZWxsZS9sb2Nrcy9jYWxsX2tlcm4uY29jY2kK Pgo+IHYyOgo+IHN5bmNvYmotPnRpbWVsaW5lIHN0aWxsIG5lZWRzIHByb3RlY3QuCj4KPiBTaWdu ZWQtb2ZmLWJ5OiBDaHVubWluZyBaaG91IDxkYXZpZDEuemhvdUBhbWQuY29tPgo+IENjOiBNYWFy dGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBp bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IENocmlzdGlhbiBLw7ZuaWcgPGVh c3kycmVtZW1iZXIuY2hrQGdvb2dsZW1haWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX3N5bmNvYmouYyB8IDI1ICsrKysrKysrKysrKystLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5j b2JqLmMKPiBpbmRleCBiN2VhYTYwM2YzNjguLmI4NDNkNGMyNzc4YyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f c3luY29iai5jCj4gQEAgLTExMSwxNSArMTExLDE2IEBAIHN0YXRpYyBzdHJ1Y3QgZG1hX2ZlbmNl Cj4gIAkJCQkgICAgICB1aW50NjRfdCBwb2ludCkKPiAgewo+ICAJc3RydWN0IGRybV9zeW5jb2Jq X3NpZ25hbF9wdCAqc2lnbmFsX3B0Owo+ICsJc3RydWN0IGRtYV9mZW5jZSAqZiA9IE5VTEw7Cj4g KwlzdHJ1Y3QgZHJtX3N5bmNvYmpfc3R1Yl9mZW5jZSAqZmVuY2UgPQo+ICsJCWt6YWxsb2Moc2l6 ZW9mKHN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlKSwKPiArCQkJR0ZQX0tFUk5FTCk7Cj4g IAo+ICsJaWYgKCFmZW5jZSkKPiArCQlyZXR1cm4gTlVMTDsKPiArCXNwaW5fbG9jaygmc3luY29i ai0+cHRfbG9jayk7Cj4gIAlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9U SU1FTElORSkgJiYKPiAgCSAgICAocG9pbnQgPD0gc3luY29iai0+dGltZWxpbmUpKSB7Cj4gLQkJ c3RydWN0IGRybV9zeW5jb2JqX3N0dWJfZmVuY2UgKmZlbmNlID0KPiAtCQkJa3phbGxvYyhzaXpl b2Yoc3RydWN0IGRybV9zeW5jb2JqX3N0dWJfZmVuY2UpLAo+IC0JCQkJR0ZQX0tFUk5FTCk7Cj4g LQo+IC0JCWlmICghZmVuY2UpCj4gLQkJCXJldHVybiBOVUxMOwo+ICAJCXNwaW5fbG9ja19pbml0 KCZmZW5jZS0+bG9jayk7Cj4gIAkJZG1hX2ZlbmNlX2luaXQoJmZlbmNlLT5iYXNlLAo+ICAJCQkg ICAgICAgJmRybV9zeW5jb2JqX3N0dWJfZmVuY2Vfb3BzLAo+IEBAIC0xMjgsNiArMTI5LDcgQEAg c3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgCQkJICAgICAgIHBvaW50KTsKPiAgCj4gIAkJZG1h X2ZlbmNlX3NpZ25hbCgmZmVuY2UtPmJhc2UpOwo+ICsJCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5w dF9sb2NrKTsKPiAgCQlyZXR1cm4gJmZlbmNlLT5iYXNlOwo+ICAJfQo+ICAKPiBAQCAtMTM3LDkg KzEzOSwxMiBAQCBzdGF0aWMgc3RydWN0IGRtYV9mZW5jZQo+ICAJCWlmICgoc3luY29iai0+dHlw ZSA9PSBEUk1fU1lOQ09CSl9UWVBFX0JJTkFSWSkgJiYKPiAgCQkgICAgKHBvaW50ICE9IHNpZ25h bF9wdC0+dmFsdWUpKQo+ICAJCQljb250aW51ZTsKPiAtCQlyZXR1cm4gZG1hX2ZlbmNlX2dldCgm c2lnbmFsX3B0LT5mZW5jZV9hcnJheS0+YmFzZSk7Cj4gKwkJZiA9IGRtYV9mZW5jZV9nZXQoJnNp Z25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJCWJyZWFrOwo+ICAJfQo+IC0JcmV0dXJu IE5VTEw7Cj4gKwlzcGluX3VubG9jaygmc3luY29iai0+cHRfbG9jayk7Cj4gKwlrZnJlZShmZW5j ZSk7Cj4gKwlyZXR1cm4gZjsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgZHJtX3N5bmNvYmpfYWRk X2NhbGxiYWNrX2xvY2tlZChzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNvYmosCj4gQEAgLTE2Niw5 ICsxNzEsNyBAQCBzdGF0aWMgdm9pZCBkcm1fc3luY29ial9mZW5jZV9nZXRfb3JfYWRkX2NhbGxi YWNrKHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwKPiAgCX0KPiAgCj4gIAltdXRleF9sb2Nr KCZzeW5jb2JqLT5jYl9tdXRleCk7Cj4gLQlzcGluX2xvY2soJnN5bmNvYmotPnB0X2xvY2spOwo+ ICAJKmZlbmNlID0gZHJtX3N5bmNvYmpfZmluZF9zaWduYWxfcHRfZm9yX3BvaW50KHN5bmNvYmos IHB0X3ZhbHVlKTsKPiAtCXNwaW5fdW5sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgCWlmICgh KmZlbmNlKQo+ICAJCWRybV9zeW5jb2JqX2FkZF9jYWxsYmFja19sb2NrZWQoc3luY29iaiwgY2Is IGZ1bmMpOwo+ICAJbXV0ZXhfdW5sb2NrKCZzeW5jb2JqLT5jYl9tdXRleCk7Ck1heWJlIHNsaWdo dGx5IG9mZnRvcGljLCBidXQgc2VlbXMgdGhhdCB0aGlzIGZ1bmN0aW9uIHNob3VsZCByZXR1cm4g YW4gZXJyb3IgaWYgZmVuY2UgPT0gTlVMTCwKYXQgbGVhc3Qgd2hlbiBpdCdzIGEgcmVzdWx0IG9m IC1FTk9NRU0uCkl0IHdvdWxkIGJlIG5pY2UgaWYgdGhpcyB3YXMgc2VudCBhcyBhIHNlcGFyYXRl IHBhdGNoLCBpbnN0ZWFkIG9mIHdhaXRpbmcgaW5kZWZpbml0ZWx5Li4KCgo+IEBAIC0zNzksMTEg KzM4Miw5IEBAIGRybV9zeW5jb2JqX3BvaW50X2dldChzdHJ1Y3QgZHJtX3N5bmNvYmogKnN5bmNv YmosIHU2NCBwb2ludCwgdTY0IGZsYWdzLAo+ICAJCWlmIChyZXQgPCAwKQo+ICAJCQlyZXR1cm4g cmV0Owo+ICAJfQo+IC0Jc3Bpbl9sb2NrKCZzeW5jb2JqLT5wdF9sb2NrKTsKPiAgCSpmZW5jZSA9 IGRybV9zeW5jb2JqX2ZpbmRfc2lnbmFsX3B0X2Zvcl9wb2ludChzeW5jb2JqLCBwb2ludCk7Cj4g IAlpZiAoISpmZW5jZSkKPiAgCQlyZXQgPSAtRUlOVkFMOwpUaGVyZSdzIG5vIHdheSB0byBtYWtl IGEgZGVzdGluY3Rpb24gYmV0d2VlbiAtRU5PTUVNIGFuZCAtRUlOVkFMLCBJIHRoaW5rIGl0IHdv dWxkIGJlIGdvb2QgdG8gdXNlIEVSUl9QVFIsIGFuZCB0aGVuCnJldHVybiBQVFJfRVJSX09SX1pF Uk8oKS4uCgpJIHdvdWxkIGFsc28gY2hhbmdlIHRoZSBzdWJqZWN0IGxpbmUgdG8gc29tZXRoaW5n IG1vcmUgZGVzY3JpcHRpdmUsIHJhdGhlciB0aGFuIHRoZSBnZW5lcmljIG9uZSBpdCdzIG5vdy4g QnV0IG90aGVyd2lzZSBsb29rcyBnb29kIHRvIG1lLiA6KQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK