From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/4] drm/amdgpu: stop all rings before doing gpu recover Date: Wed, 28 Feb 2018 13:20:40 +0100 Message-ID: <9e575c74-c6ce-76ef-a09c-1dec5a4807a3@gmail.com> References: <1519802463-9090-1-git-send-email-Monk.Liu@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1519802463-9090-1-git-send-email-Monk.Liu-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Monk Liu , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, "Grodzovsky, Andrey" QW5kcmV5IHBsZWFzZSBnaXZlIHRoaXMgc2V0IGEgZ29vZCB0ZXN0aW5nIGFzIHdlbGwuCgpBbSAy OC4wMi4yMDE4IHVtIDA4OjIxIHNjaHJpZWIgTW9uayBMaXU6Cj4gZm91bmQgcmVjb3Zlcl92cmFt X2Zyb21fc2hhZG93IHNvbWV0aW1lcyBnZXQgZXhlY3V0ZWQKPiBpbiBwYXJhbGxlIHdpdGggU0RN QSBzY2hlZHVsZXIsIHNob3VsZCBzdG9wIGFsbAo+IHNjaGVkdWxlcnMgYmVmb3JlIGRvaW5nIGdw dSByZXNldC9yZWNvdmVyCj4KPiBDaGFuZ2UtSWQ6IEliYWVmM2UzYzAxNWYzY2Y4OGY4NGIyZWFm OTVjZGE5NWFlMWE2NGUzCj4gU2lnbmVkLW9mZi1ieTogTW9uayBMaXUgPE1vbmsuTGl1QGFtZC5j b20+CgpGb3Igbm93IHRoaXMgcGF0Y2ggaXMgUmV2aWV3ZWQtYnk6IENocmlzdGlhbiBLw7ZuaWcg CjxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+LgoKUmVnYXJkcywKQ2hyaXN0aWFuLgoKPiAtLS0K PiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8IDQwICsrKysr KysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlv bnMoKyksIDI1IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9kZXZpY2UuYwo+IGluZGV4IDc1ZDE3MzMuLmU5ZDgxYTggMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4gQEAgLTI2NDksMjIgKzI2NDksMjMg QEAgaW50IGFtZGdwdV9kZXZpY2VfZ3B1X3JlY292ZXIoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFk ZXYsCj4gICAKPiAgIAkvKiBibG9jayBUVE0gKi8KPiAgIAlyZXNjaGVkID0gdHRtX2JvX2xvY2tf ZGVsYXllZF93b3JrcXVldWUoJmFkZXYtPm1tYW4uYmRldik7Cj4gKwo+ICAgCS8qIHN0b3JlIG1v ZGVzZXR0aW5nICovCj4gICAJaWYgKGFtZGdwdV9kZXZpY2VfaGFzX2RjX3N1cHBvcnQoYWRldikp Cj4gICAJCXN0YXRlID0gZHJtX2F0b21pY19oZWxwZXJfc3VzcGVuZChhZGV2LT5kZGV2KTsKPiAg IAo+IC0JLyogYmxvY2sgc2NoZWR1bGVyICovCj4gKwkvKiBibG9jayBhbGwgc2NoZWR1bGVycyBh bmQgcmVzZXQgZ2l2ZW4gam9iJ3MgcmluZyAqLwo+ICAgCWZvciAoaSA9IDA7IGkgPCBBTURHUFVf TUFYX1JJTkdTOyArK2kpIHsKPiAgIAkJc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nID0gYWRldi0+ cmluZ3NbaV07Cj4gICAKPiAgIAkJaWYgKCFyaW5nIHx8ICFyaW5nLT5zY2hlZC50aHJlYWQpCj4g ICAJCQljb250aW51ZTsKPiAgIAo+IC0JCS8qIG9ubHkgZm9jdXMgb24gdGhlIHJpbmcgaGl0IHRp bWVvdXQgaWYgJmpvYiBub3QgTlVMTCAqLwo+ICsJCWt0aHJlYWRfcGFyayhyaW5nLT5zY2hlZC50 aHJlYWQpOwo+ICsKPiAgIAkJaWYgKGpvYiAmJiBqb2ItPnJpbmctPmlkeCAhPSBpKQo+ICAgCQkJ Y29udGludWU7Cj4gICAKPiAtCQlrdGhyZWFkX3BhcmsocmluZy0+c2NoZWQudGhyZWFkKTsKPiAg IAkJZHJtX3NjaGVkX2h3X2pvYl9yZXNldCgmcmluZy0+c2NoZWQsICZqb2ItPmJhc2UpOwo+ICAg Cj4gICAJCS8qIGFmdGVyIGFsbCBodyBqb2JzIGFyZSByZXNldCwgaHcgZmVuY2UgaXMgbWVhbmlu Z2xlc3MsIHNvIGZvcmNlX2NvbXBsZXRpb24gKi8KPiBAQCAtMjcwNywzMyArMjcwOCwyMiBAQCBp bnQgYW1kZ3B1X2RldmljZV9ncHVfcmVjb3ZlcihzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwK PiAgIAkJCX0KPiAgIAkJCWRtYV9mZW5jZV9wdXQoZmVuY2UpOwo+ICAgCQl9Cj4gKwl9Cj4gICAK PiAtCQlmb3IgKGkgPSAwOyBpIDwgQU1ER1BVX01BWF9SSU5HUzsgKytpKSB7Cj4gLQkJCXN0cnVj dCBhbWRncHVfcmluZyAqcmluZyA9IGFkZXYtPnJpbmdzW2ldOwo+IC0KPiAtCQkJaWYgKCFyaW5n IHx8ICFyaW5nLT5zY2hlZC50aHJlYWQpCj4gLQkJCQljb250aW51ZTsKPiArCWZvciAoaSA9IDA7 IGkgPCBBTURHUFVfTUFYX1JJTkdTOyArK2kpIHsKPiArCQlzdHJ1Y3QgYW1kZ3B1X3JpbmcgKnJp bmcgPSBhZGV2LT5yaW5nc1tpXTsKPiAgIAo+IC0JCQkvKiBvbmx5IGZvY3VzIG9uIHRoZSByaW5n IGhpdCB0aW1lb3V0IGlmICZqb2Igbm90IE5VTEwgKi8KPiAtCQkJaWYgKGpvYiAmJiBqb2ItPnJp bmctPmlkeCAhPSBpKQo+IC0JCQkJY29udGludWU7Cj4gKwkJaWYgKCFyaW5nIHx8ICFyaW5nLT5z Y2hlZC50aHJlYWQpCj4gKwkJCWNvbnRpbnVlOwo+ICAgCj4gKwkJLyogb25seSBuZWVkIHJlY292 ZXJ5IHNjaGVkIG9mIHRoZSBnaXZlbiBqb2IncyByaW5nCj4gKwkJICogb3IgYWxsIHJpbmdzIChp biB0aGUgY2FzZSBAam9iIGlzIE5VTEwpCj4gKwkJICogYWZ0ZXIgYWJvdmUgYW1kZ3B1X3Jlc2V0 IGFjY29tcGxpc2hlZAo+ICsJCSAqLwo+ICsJCWlmICgoIWpvYiB8fCBqb2ItPnJpbmctPmlkeCA9 PSBpKSAmJiAhcikKPiAgIAkJCWRybV9zY2hlZF9qb2JfcmVjb3ZlcnkoJnJpbmctPnNjaGVkKTsK PiAtCQkJa3RocmVhZF91bnBhcmsocmluZy0+c2NoZWQudGhyZWFkKTsKPiAtCQl9Cj4gLQl9IGVs c2Ugewo+IC0JCWZvciAoaSA9IDA7IGkgPCBBTURHUFVfTUFYX1JJTkdTOyArK2kpIHsKPiAtCQkJ c3RydWN0IGFtZGdwdV9yaW5nICpyaW5nID0gYWRldi0+cmluZ3NbaV07Cj4gICAKPiAtCQkJaWYg KCFyaW5nIHx8ICFyaW5nLT5zY2hlZC50aHJlYWQpCj4gLQkJCQljb250aW51ZTsKPiAtCj4gLQkJ CS8qIG9ubHkgZm9jdXMgb24gdGhlIHJpbmcgaGl0IHRpbWVvdXQgaWYgJmpvYiBub3QgTlVMTCAq Lwo+IC0JCQlpZiAoam9iICYmIGpvYi0+cmluZy0+aWR4ICE9IGkpCj4gLQkJCQljb250aW51ZTsK PiAtCj4gLQkJCWt0aHJlYWRfdW5wYXJrKGFkZXYtPnJpbmdzW2ldLT5zY2hlZC50aHJlYWQpOwo+ IC0JCX0KPiArCQlrdGhyZWFkX3VucGFyayhyaW5nLT5zY2hlZC50aHJlYWQpOwo+ICAgCX0KPiAg IAo+ICAgCWlmIChhbWRncHVfZGV2aWNlX2hhc19kY19zdXBwb3J0KGFkZXYpKSB7CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK