From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/amdgpu: Report firmware versions with sysfs v2 Date: Tue, 14 May 2019 12:32:53 +0200 Message-ID: <9e6bd0ac-6972-2bf1-2c4d-9784bd4db149@gmail.com> References: <20190509203441.7731-1-Ori.Messinger@amd.com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Russell, Kent" , "Messinger, Ori" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" SSBkb24ndCBjbGFpbSB0aGF0IEkgdW5kZXJzdGFuZCBhbGwgb2YgdGhlIGludGVybmFscyBvZiBm dyB2ZXJzaW9uIApoYW5kbGluZywgYnV0IHRoaXMgbG9va3MgcmVhbGx5IG5pY2UgdG8gbWUgZnJv bSBhIGtlcm5lbCBwZXJzcGVjdGl2ZS4KCkZlZWwgZnJlZSB0byBhZGQgbXkgUmV2aWV3ZWQtYnk6 IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4uCgpSZWdhcmRzLApD aHJpc3RpYW4uCgpBbSAxNC4wNS4xOSB1bSAxMjoxOSBzY2hyaWViIFJ1c3NlbGwsIEtlbnQ6Cj4g TG9va3MgZmluZSB0byBtZSwgYnV0IGhvcGluZyB0byBnZXQgYW4gUkIgZnJvbSBDaHJpc3RpYW4g bm93IHRoYXQgd2UncmUgbW92aW5nIHRoZW0gaW50byBhIHN1YmZvbGRlci4KPgo+ICAgS2VudAo+ Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBhbWQtZ2Z4IDxhbWQtZ2Z4LWJv dW5jZXNAbGlzdHMuZnJlZWRlc2t0b3Aub3JnPiBPbiBCZWhhbGYgT2YgTWVzc2luZ2VyLCBPcmkK PiBTZW50OiBUaHVyc2RheSwgTWF5IDksIDIwMTkgNDozNSBQTQo+IFRvOiBhbWQtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IENjOiBNZXNzaW5nZXIsIE9yaSA8T3JpLk1lc3NpbmdlckBhbWQu Y29tPgo+IFN1YmplY3Q6IFtQQVRDSF0gZHJtL2FtZGdwdTogUmVwb3J0IGZpcm13YXJlIHZlcnNp b25zIHdpdGggc3lzZnMgdjIKPgo+IFtDQVVUSU9OOiBFeHRlcm5hbCBFbWFpbF0KPgo+IEZpcm13 YXJlIHZlcnNpb25zIGNhbiBiZSBmb3VuZCBhcyBzZXBhcmF0ZSBzeXNmcyBmaWxlcyBhdDoKPiAv c3lzL2NsYXNzL2RybS9jYXJkWC9kZXZpY2UvZndfdmVyc2lvbiAod2hlcmUgWCBpcyB0aGUgY2Fy ZCBudW1iZXIpIFRoZSBmaXJtd2FyZSB2ZXJzaW9ucyBhcmUgZGlzcGxheWVkIGluIGhleGFkZWNp bWFsLgo+IHYyOiBNb3ZlZCBzeXNmcyBmaWxlcyB0byBzdWJmb2xkZXIKPgo+IENoYW5nZS1JZDog STEwY2FlNGMwY2E2ZjFiNmE5Y2VkMDdkYTE0MzQyNmUxZDAxMWUyMDMKPiBTaWduZWQtb2ZmLWJ5 OiBPcmkgTWVzc2luZ2VyIDxvcmkubWVzc2luZ2VyQGFtZC5jb20+Cj4gLS0tCj4gICBkcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCAgNSArKyAgZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmMgIHwgNjMgKysrKysrKysrKysrKysrKysrKysr KyAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmggIHwgIDIgKwo+ICAg MyBmaWxlcyBjaGFuZ2VkLCA3MCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4gaW5kZXggZWM4NjQ3NDBlZmI1Li44YzU2YzQ5Yzhk ZmMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2Rldmlj ZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jCj4g QEAgLTI3MDUsNiArMjcwNSwxMCBAQCBpbnQgYW1kZ3B1X2RldmljZV9pbml0KHN0cnVjdCBhbWRn cHVfZGV2aWNlICphZGV2LAo+ICAgICAgICAgIGlmIChyKQo+ICAgICAgICAgICAgICAgICAgRFJN X0VSUk9SKCJyZWdpc3RlcmluZyBwbSBkZWJ1Z2ZzIGZhaWxlZCAoJWQpLlxuIiwgcik7Cj4KPiAr ICAgICAgIHIgPSBhbWRncHVfdWNvZGVfc3lzZnNfaW5pdChhZGV2KTsKPiArICAgICAgIGlmIChy KQo+ICsgICAgICAgICAgICAgICBEUk1fRVJST1IoIkNyZWF0aW5nIGZpcm13YXJlIHN5c2ZzIGZh aWxlZCAoJWQpLlxuIiwgcik7Cj4gKwo+ICAgICAgICAgIHIgPSBhbWRncHVfZGVidWdmc19nZW1f aW5pdChhZGV2KTsKPiAgICAgICAgICBpZiAocikKPiAgICAgICAgICAgICAgICAgIERSTV9FUlJP UigicmVnaXN0ZXJpbmcgZ2VtIGRlYnVnZnMgZmFpbGVkICglZCkuXG4iLCByKTsgQEAgLTI4MTcs NiArMjgyMSw3IEBAIHZvaWQgYW1kZ3B1X2RldmljZV9maW5pKHN0cnVjdCBhbWRncHVfZGV2aWNl ICphZGV2KQo+ICAgICAgICAgIGFtZGdwdV9kZXZpY2VfZG9vcmJlbGxfZmluaShhZGV2KTsKPiAg ICAgICAgICBhbWRncHVfZGVidWdmc19yZWdzX2NsZWFudXAoYWRldik7Cj4gICAgICAgICAgZGV2 aWNlX3JlbW92ZV9maWxlKGFkZXYtPmRldiwgJmRldl9hdHRyX3BjaWVfcmVwbGF5X2NvdW50KTsK PiArICAgICAgIGFtZGdwdV91Y29kZV9zeXNmc19maW5pKGFkZXYpOwo+ICAgfQo+Cj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmMgYi9kcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYwo+IGluZGV4IDdiMzM4NjcwMzZl Ny4uMzNjMWViNzZjMDc2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV91Y29kZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3Vjb2RlLmMKPiBAQCAtMzEzLDYgKzMxMyw2OSBAQCBhbWRncHVfdWNvZGVfZ2V0X2xvYWRfdHlw ZShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgaW50IGxvYWRfdHlwZSkKPiAgICAgICAgICBy ZXR1cm4gQU1ER1BVX0ZXX0xPQURfRElSRUNUOwo+ICAgfQo+Cj4gKyNkZWZpbmUgRldfVkVSU0lP Tl9BVFRSKG5hbWUsIG1vZGUsIGZpZWxkKSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ ICtzdGF0aWMgc3NpemVfdCBzaG93XyMjbmFtZShzdHJ1Y3QgZGV2aWNlICpkZXYsICAgICAgICAg ICAgICAgICAgICAgICAgIFwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIHN0cnVjdCBkZXZp Y2VfYXR0cmlidXRlICphdHRyLCAgICAgICAgICAgICAgICBcCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICBjaGFyICpidWYpICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ ICt7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFwKPiArICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZGV2ID0gZGV2 X2dldF9kcnZkYXRhKGRldik7ICAgICAgICAgICAgICAgICBcCj4gKyAgICAgICBzdHJ1Y3QgYW1k Z3B1X2RldmljZSAqYWRldiA9IGRkZXYtPmRldl9wcml2YXRlOyAgICAgICAgICAgICAgICAgXAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIFwKPiArICAgICAgIHJldHVybiBzbnByaW50ZihidWYsIFBBR0VfU0la RSwgIjB4JTA4eFxuIiwgYWRldi0+ZmllbGQpOyAgICAgICBcCj4gK30gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAo+ ICtzdGF0aWMgREVWSUNFX0FUVFIobmFtZSwgbW9kZSwgc2hvd18jI25hbWUsIE5VTEwpCj4gKwo+ ICtGV19WRVJTSU9OX0FUVFIodmNlX2Z3X3ZlcnNpb24sIDA0NDQsIHZjZS5md192ZXJzaW9uKTsK PiArRldfVkVSU0lPTl9BVFRSKHV2ZF9md192ZXJzaW9uLCAwNDQ0LCB1dmQuZndfdmVyc2lvbik7 Cj4gK0ZXX1ZFUlNJT05fQVRUUihtY19md192ZXJzaW9uLCAwNDQ0LCBnbWMuZndfdmVyc2lvbik7 Cj4gK0ZXX1ZFUlNJT05fQVRUUihtZV9md192ZXJzaW9uLCAwNDQ0LCBnZngubWVfZndfdmVyc2lv bik7Cj4gK0ZXX1ZFUlNJT05fQVRUUihwZnBfZndfdmVyc2lvbiwgMDQ0NCwgZ2Z4LnBmcF9md192 ZXJzaW9uKTsKPiArRldfVkVSU0lPTl9BVFRSKGNlX2Z3X3ZlcnNpb24sIDA0NDQsIGdmeC5jZV9m d192ZXJzaW9uKTsKPiArRldfVkVSU0lPTl9BVFRSKHJsY19md192ZXJzaW9uLCAwNDQ0LCBnZngu cmxjX2Z3X3ZlcnNpb24pOwo+ICtGV19WRVJTSU9OX0FUVFIocmxjX3NybGNfZndfdmVyc2lvbiwg MDQ0NCwgZ2Z4LnJsY19zcmxjX2Z3X3ZlcnNpb24pOwo+ICtGV19WRVJTSU9OX0FUVFIocmxjX3Ny bGdfZndfdmVyc2lvbiwgMDQ0NCwgZ2Z4LnJsY19zcmxnX2Z3X3ZlcnNpb24pOwo+ICtGV19WRVJT SU9OX0FUVFIocmxjX3NybHNfZndfdmVyc2lvbiwgMDQ0NCwgZ2Z4LnJsY19zcmxzX2Z3X3ZlcnNp b24pOwo+ICtGV19WRVJTSU9OX0FUVFIobWVjX2Z3X3ZlcnNpb24sIDA0NDQsIGdmeC5tZWNfZndf dmVyc2lvbik7Cj4gK0ZXX1ZFUlNJT05fQVRUUihtZWMyX2Z3X3ZlcnNpb24sIDA0NDQsIGdmeC5t ZWMyX2Z3X3ZlcnNpb24pOwo+ICtGV19WRVJTSU9OX0FUVFIoc29zX2Z3X3ZlcnNpb24sIDA0NDQs IHBzcC5zb3NfZndfdmVyc2lvbik7Cj4gK0ZXX1ZFUlNJT05fQVRUUihhc2RfZndfdmVyc2lvbiwg MDQ0NCwgcHNwLmFzZF9md192ZXJzaW9uKTsKPiArRldfVkVSU0lPTl9BVFRSKHRhX3Jhc19md192 ZXJzaW9uLCAwNDQ0LCBwc3AudGFfZndfdmVyc2lvbik7Cj4gK0ZXX1ZFUlNJT05fQVRUUih0YV94 Z21pX2Z3X3ZlcnNpb24sIDA0NDQsIHBzcC50YV9md192ZXJzaW9uKTsKPiArRldfVkVSU0lPTl9B VFRSKHNtY19md192ZXJzaW9uLCAwNDQ0LCBwbS5md192ZXJzaW9uKTsKPiArRldfVkVSU0lPTl9B VFRSKHNkbWFfZndfdmVyc2lvbiwgMDQ0NCwgc2RtYS5pbnN0YW5jZVswXS5md192ZXJzaW9uKTsK PiArRldfVkVSU0lPTl9BVFRSKHNkbWEyX2Z3X3ZlcnNpb24sIDA0NDQsIHNkbWEuaW5zdGFuY2Vb MV0uZndfdmVyc2lvbik7Cj4gK0ZXX1ZFUlNJT05fQVRUUih2Y25fZndfdmVyc2lvbiwgMDQ0NCwg dmNuLmZ3X3ZlcnNpb24pOwo+ICtGV19WRVJTSU9OX0FUVFIoZG1jdV9md192ZXJzaW9uLCAwNDQ0 LCBkbS5kbWN1X2Z3X3ZlcnNpb24pOwo+ICsKPiArc3RhdGljIHN0cnVjdCBhdHRyaWJ1dGUgKmZ3 X2F0dHJzW10gPSB7Cj4gKyAgICAgICAmZGV2X2F0dHJfdmNlX2Z3X3ZlcnNpb24uYXR0ciwgJmRl dl9hdHRyX3V2ZF9md192ZXJzaW9uLmF0dHIsCj4gKyAgICAgICAmZGV2X2F0dHJfbWNfZndfdmVy c2lvbi5hdHRyLCAmZGV2X2F0dHJfbWVfZndfdmVyc2lvbi5hdHRyLAo+ICsgICAgICAgJmRldl9h dHRyX3BmcF9md192ZXJzaW9uLmF0dHIsICZkZXZfYXR0cl9jZV9md192ZXJzaW9uLmF0dHIsCj4g KyAgICAgICAmZGV2X2F0dHJfcmxjX2Z3X3ZlcnNpb24uYXR0ciwgJmRldl9hdHRyX3JsY19zcmxj X2Z3X3ZlcnNpb24uYXR0ciwKPiArICAgICAgICZkZXZfYXR0cl9ybGNfc3JsZ19md192ZXJzaW9u LmF0dHIsICZkZXZfYXR0cl9ybGNfc3Jsc19md192ZXJzaW9uLmF0dHIsCj4gKyAgICAgICAmZGV2 X2F0dHJfbWVjX2Z3X3ZlcnNpb24uYXR0ciwgJmRldl9hdHRyX21lYzJfZndfdmVyc2lvbi5hdHRy LAo+ICsgICAgICAgJmRldl9hdHRyX3Nvc19md192ZXJzaW9uLmF0dHIsICZkZXZfYXR0cl9hc2Rf ZndfdmVyc2lvbi5hdHRyLAo+ICsgICAgICAgJmRldl9hdHRyX3RhX3Jhc19md192ZXJzaW9uLmF0 dHIsICZkZXZfYXR0cl90YV94Z21pX2Z3X3ZlcnNpb24uYXR0ciwKPiArICAgICAgICZkZXZfYXR0 cl9zbWNfZndfdmVyc2lvbi5hdHRyLCAmZGV2X2F0dHJfc2RtYV9md192ZXJzaW9uLmF0dHIsCj4g KyAgICAgICAmZGV2X2F0dHJfc2RtYTJfZndfdmVyc2lvbi5hdHRyLCAmZGV2X2F0dHJfdmNuX2Z3 X3ZlcnNpb24uYXR0ciwKPiArICAgICAgICZkZXZfYXR0cl9kbWN1X2Z3X3ZlcnNpb24uYXR0ciwg TlVMTCB9Owo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBhdHRyaWJ1dGVfZ3JvdXAgZndfYXR0 cl9ncm91cCA9IHsKPiArICAgICAgIC5uYW1lID0gImZ3X3ZlcnNpb24iLAo+ICsgICAgICAgLmF0 dHJzID0gZndfYXR0cnMKPiArfTsKPiArCj4gK2ludCBhbWRncHVfdWNvZGVfc3lzZnNfaW5pdChz dHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldikgewo+ICsgICAgICAgcmV0dXJuIHN5c2ZzX2NyZWF0 ZV9ncm91cCgmYWRldi0+ZGV2LT5rb2JqLCAmZndfYXR0cl9ncm91cCk7IH0KPiArCj4gK3ZvaWQg YW1kZ3B1X3Vjb2RlX3N5c2ZzX2Zpbmkoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYpIHsKPiAr ICAgICAgIHN5c2ZzX3JlbW92ZV9ncm91cCgmYWRldi0+ZGV2LT5rb2JqLCAmZndfYXR0cl9ncm91 cCk7IH0KPiArCj4gICBzdGF0aWMgaW50IGFtZGdwdV91Y29kZV9pbml0X3NpbmdsZV9mdyhzdHJ1 Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc3RydWN0IGFtZGdwdV9maXJtd2FyZV9pbmZvICp1Y29kZSwKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdWludDY0X3QgbWNfYWRkciwgdm9pZCAqa3B0 cikgZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5o IGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Vjb2RlLmgKPiBpbmRleCA3YWMy NWExYzc4NTMuLmVjNGMyZWExZjA1YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYW1k L2FtZGdwdS9hbWRncHVfdWNvZGUuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1 L2FtZGdwdV91Y29kZS5oCj4gQEAgLTI5MSw3ICsyOTEsOSBAQCBib29sIGFtZGdwdV91Y29kZV9o ZHJfdmVyc2lvbih1bmlvbiBhbWRncHVfZmlybXdhcmVfaGVhZGVyICpoZHIsCj4KPiAgIGludCBh bWRncHVfdWNvZGVfaW5pdF9ibyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldik7ICBpbnQgYW1k Z3B1X3Vjb2RlX2NyZWF0ZV9ibyhzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldik7Cj4gK2ludCBh bWRncHVfdWNvZGVfc3lzZnNfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldik7Cj4gICB2 b2lkIGFtZGdwdV91Y29kZV9mcmVlX2JvKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KTsKPiAr dm9pZCBhbWRncHVfdWNvZGVfc3lzZnNfZmluaShzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldik7 Cj4KPiAgIGVudW0gYW1kZ3B1X2Zpcm13YXJlX2xvYWRfdHlwZQo+ICAgYW1kZ3B1X3Vjb2RlX2dl dF9sb2FkX3R5cGUoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIGludCBsb2FkX3R5cGUpOwo+ IC0tCj4gMi4xNy4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ft ZC1nZngKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFp bGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==