Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B5C4C49EA5 for ; Fri, 22 Apr 2022 16:52:01 +0000 (UTC) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.groups.io with SMTP id smtpd.web09.7344.1650628024411983582 for ; Fri, 22 Apr 2022 04:47:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linuxfoundation.org header.s=google header.b=ZSSqQlLX; spf=pass (domain: linuxfoundation.org, ip: 209.85.221.50, mailfrom: richard.purdie@linuxfoundation.org) Received: by mail-wr1-f50.google.com with SMTP id t6so7249381wra.4 for ; Fri, 22 Apr 2022 04:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=L439noBzi9E1vi0wnuZNTHuSq9NBynkiAPs6o7zsTGI=; b=ZSSqQlLXRvbw61HhDIlRUfV6wGBmasSAxgiRctQqAzdXrDS8f9Ry5nd78rMASspLe9 JVJPyht5/d7VzstyYSlpw4BtjwjHDv2T+zb7E+YCpEBpqDA75KiFyKMeOO1T6mlhCwJy 4TIb7GsXg9WjUwyr78l8NwkzZQJ+ZjgwdkE5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=L439noBzi9E1vi0wnuZNTHuSq9NBynkiAPs6o7zsTGI=; b=B904UCqnqLz0UfUnXyDT0BknwtGmRgpfOngA8buFOfpKooQVgTLme8nCyoSrhgJvsY P/7+Y65/y5BNXTOupj4yecizh4TXRzxe1bt2DsBlBTXj1WecBDM0McXS9/dX2+lDxPxc N+N+2D5e6BnB5+dKWiqJw3Cnx7pYWeuH2vAVlo7SkH9ICulLE/5WbwWy4UeesGwGiwps 1PbauZE7JOPDOB4uuxQiXnPhyedPfGXQOEN3l5hRX3iC40G+n1k+tiLdDhxtCEVb9YIb Xh4bnha97RjogAywKvXjB7HROqL5YHPtDcdboiU9AjWxwUfk2uWXiVa8NjX7H/BpR8Gq 5I5w== X-Gm-Message-State: AOAM5301Tlxmb6xdkZDnq9Nami922+PasKOK1EHFaGvgh9avZsq1rNTl ccWR3zk+VM/ZImCrn02qdeqNaoxraQ6uDg== X-Google-Smtp-Source: ABdhPJzXWO3A4Y6nzWUX54hHReymh5JJ1M9vESveZcB5R3Q1Q/ySppo546qHItobSF5yHvktobmbyQ== X-Received: by 2002:a5d:4747:0:b0:20a:c40b:1189 with SMTP id o7-20020a5d4747000000b0020ac40b1189mr3339972wrs.509.1650628022962; Fri, 22 Apr 2022 04:47:02 -0700 (PDT) Received: from ?IPv6:2001:8b0:aba:5f3c:9788:6d00:bfe8:c84e? ([2001:8b0:aba:5f3c:9788:6d00:bfe8:c84e]) by smtp.gmail.com with ESMTPSA id t2-20020a1c4602000000b003917d43d339sm4488672wma.4.2022.04.22.04.46.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 04:47:01 -0700 (PDT) Message-ID: <9e8203a32b436c8c279727658bef00ec626f1da9.camel@linuxfoundation.org> Subject: Re: [docs] [PATCH 6/9] ref-manual: add XZ_THREADS and ZSTD_THREADS From: Richard Purdie To: Quentin Schulz , Paul Eggleton , docs@lists.yoctoproject.org Date: Fri, 22 Apr 2022 12:46:57 +0100 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4-1ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Fri, 22 Apr 2022 16:52:01 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/docs/message/2843 On Fri, 2022-04-22 at 12:40 +0200, Quentin Schulz wrote: > Hi Paul, > > On 4/22/22 03:40, Paul Eggleton wrote: > > ZSTD_THREADS is new for kirkstone, XZ_THREADS was introduced in dunfell. > > > > Separate patch please so XZ_THREADS can be backported to all branches up > to dunfell. > > > Signed-off-by: Paul Eggleton > > --- > > documentation/ref-manual/variables.rst | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst > > index b9448b8..4803578 100644 > > --- a/documentation/ref-manual/variables.rst > > +++ b/documentation/ref-manual/variables.rst > > @@ -8737,4 +8737,15 @@ system and gives an overview of their function and contents. > > > > The default value of :term:`XSERVER`, if not specified in the machine > > configuration, is "xserver-xorg xf86-video-fbdev xf86-input-evdev". > > - > > + > > + :term:`XZ_THREADS` > > + Specifies the number of parallel threads that should be used when > > + using xz compression. By default this scales with core count, but > > + is never set less than 2 to ensure that multi-threaded mode is > > + always used (so that the output file contents are deterministic). > > + > > I don't see how having it set to 1 breaks deterministic builds, do you > mind explaining? > > Also, this feels like explanation of the implementation more than what > the user should do with this variable. I think having a cautionary note here about reproducible builds is important. > If the variable should never be <2, then it needs to be explicitly > stated here (and eventually the reason). You can set it, you just won't have reproducible builds. > Maybe it'd make sense to explain why would anyone want to modify this > variable (which IIRC, is for when you have a nproc/ram too high and it > OOMs when creating packages). That would be nice, yes. I've gone ahead and tried a new version of this patch split into two and adding XZ_MEMLIMIT too (ZSTD doesn't have that). Cheers, Richard