From: Tvrtko Ursulin Subject: Re: [PATCH v2] drm/i915: Handle RC6 counter wrap Date: Thu, 8 Feb 2018 08:50:58 +0000 Message-ID: <9e8613da-ee90-5925-4f34-5ef8e6a1204e@linux.intel.com> References: <151802228768.8135.10996890556441843332@mail.alporthouse.com> <20180208070437.2692-1-tvrtko.ursulin@linux.intel.com> <151807682017.28809.17040553218386245341@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4E656E10F for ; Thu, 8 Feb 2018 08:51:01 +0000 (UTC) In-Reply-To: <151807682017.28809.17040553218386245341@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Tvrtko Ursulin , Intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDA4LzAyLzIwMTggMDg6MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTAyLTA4IDA3OjA0OjM3KQo+PiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+Pgo+PiBXZSBjYW4gaW1wbGVtZW50IGxpbWl0ZWQg UkM2IGNvdW50ZXIgd3JhcC1hcm91bmQgcHJvdGVjdGlvbiB1bmRlciB0aGUKPj4gYXNzdW1wdGlv biB0aGF0IGNsaWVudHMgd2lsbCBiZSByZWFkaW5nIHRoaXMgdmFsdWUgbW9yZSBmcmVxdWVudGx5 IHRoYW4KPj4gdGhlIHdyYXAgcGVyaW9kIG9uIGEgZ2l2ZW4gcGxhdGZvcm0uCj4+Cj4+IFdpdGgg dGhlIHR5cGljYWwgd3JhcC1hcm91bmQgcGVyaW9kIGJlaW5nIH45MCBtaW51dGVzLCBldmVuIHdp dGggdGhlCj4+IGV4Y2VwdGlvbiBvZiBCYXl0cmFpbCB3aGljaCB3cmFwcyBldmVyeSAxMyBzZWNv bmRzLCB0aGlzIHNvdW5kcyBsaWtlIGEKPj4gcmVhc29uYWJsZSBhc3N1bXB0aW9uLgo+Pgo+PiBJ bXBsZW1lbnRhdGlvbiB3b3JrcyBieSBzdG9yaW5nIGEgNjQtYml0IHNvZnR3YXJlIGNvcHkgb2Yg YSBoYXJkd2FyZSBSQzYKPj4gY291bnRlciwgYWxvbmcgd2l0aCB0aGUgcHJldmlvdXMgSFcgY291 bnRlciBzbmFwc2hvdC4gVGhpcyBlbmFibGVzIGl0IHRvCj4+IGRldGVjdCB3cmFwIGlzIHBvbGxl ZCBmcmVxdWVudGx5IGVub3VnaCBhbmQga2VlcCB0aGUgc29mdHdhcmUgY29weQo+PiBtb25vdG9u aWNhbGx5IGluY3JlbWVudGluZy4KPj4KPj4gdjI6Cj4+ICAgKiBNaXNzZWQgR0VONl9HVF9HRlhf UkM2X0xPQ0tFRCB3aGVuIGNvbnNpZGVyaW5nIHNsb3Qgc2l6aW5nIGFuZAo+PiAgICAgaW5kZXhp bmcuCj4+ICAgKiBGaXhlZCBvZmYtYnktb25lIGluIHdyYXAtYXJvdW5kIGhhbmRsaW5nLiAoQ2hy aXMgV2lsc29uKQo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVy c3VsaW5AaW50ZWwuY29tPgo+PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTQ4NTIKPj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o IHwgIDIgKysKPj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIHwgNTcgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPj4gICAyIGZpbGVzIGNoYW5nZWQs IDUwIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuaAo+PiBpbmRleCBhZDFmYzg0NWNkMWIuLjI4YTI2NzFhMjZjNyAxMDA2NDQKPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2Rydi5oCj4+IEBAIC05NDYsNiArOTQ2LDggQEAgc3RydWN0IGludGVsX3JwcyB7 Cj4+ICAgCj4+ICAgc3RydWN0IGludGVsX3JjNiB7Cj4+ICAgICAgICAgIGJvb2wgZW5hYmxlZDsK Pj4gKyAgICAgICB1NjQgcHJldl9od19yZXNpZGVuY3lbNF07Cj4+ICsgICAgICAgdTY0IGN1cl9y ZXNpZGVuY3lbNF07Cj4+ICAgfTsKPj4gICAKPj4gICBzdHJ1Y3QgaW50ZWxfbGxjX3BzdGF0ZSB7 Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiBpbmRleCA0MWYyNmFiNDY1MDEuLjZiMDE3MDAz MzRhOSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+PiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4+IEBAIC05NDE3LDE1ICs5NDE3 LDE2IEBAIHN0YXRpYyB1NjQgdmx2X3Jlc2lkZW5jeV9yYXcoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBpOTE1 X3JlZ190IHJlZykKPj4gICB7Cj4+ICAgICAgICAgIHUzMiBsb3dlciwgdXBwZXIsIHRtcDsKPj4g LSAgICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+PiAgICAgICAgICBpbnQgbG9vcCA9IDI7Cj4+ ICAgCj4+IC0gICAgICAgLyogVGhlIHJlZ2lzdGVyIGFjY2Vzc2VkIGRvIG5vdCBuZWVkIGZvcmNl d2FrZS4gV2UgYm9ycm93Cj4+ICsgICAgICAgLyoKPj4gKyAgICAgICAgKiBUaGUgcmVnaXN0ZXIg YWNjZXNzZWQgZG8gbm90IG5lZWQgZm9yY2V3YWtlLiBXZSBib3Jyb3cKPj4gICAgICAgICAgICog dW5jb3JlIGxvY2sgdG8gcHJldmVudCBjb25jdXJyZW50IGFjY2VzcyB0byByYW5nZSByZWcuCj4+ ICAgICAgICAgICAqLwo+PiAtICAgICAgIHNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+dW5j b3JlLmxvY2ssIGZsYWdzKTsKPj4gKyAgICAgICBsb2NrZGVwX2Fzc2VydF9oZWxkKCZkZXZfcHJp di0+dW5jb3JlLmxvY2spOwo+PiAgIAo+PiAtICAgICAgIC8qIHZsdiBhbmQgY2h2IHJlc2lkZW5j eSBjb3VudGVycyBhcmUgNDAgYml0cyBpbiB3aWR0aC4KPj4gKyAgICAgICAvKgo+PiArICAgICAg ICAqIHZsdiBhbmQgY2h2IHJlc2lkZW5jeSBjb3VudGVycyBhcmUgNDAgYml0cyBpbiB3aWR0aC4K Pj4gICAgICAgICAgICogV2l0aCBhIGNvbnRyb2wgYml0LCB3ZSBjYW4gY2hvb3NlIGJldHdlZW4g dXBwZXIgb3IgbG93ZXIKPj4gICAgICAgICAgICogMzJiaXQgd2luZG93IGludG8gdGhpcyBjb3Vu dGVyLgo+PiAgICAgICAgICAgKgo+PiBAQCAtOTQ0OSwyOSArOTQ1MCw0NCBAQCBzdGF0aWMgdTY0 IHZsdl9yZXNpZGVuY3lfcmF3KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4g ICAgICAgICAgICAgICAgICB1cHBlciA9IEk5MTVfUkVBRF9GVyhyZWcpOwo+PiAgICAgICAgICB9 IHdoaWxlICh1cHBlciAhPSB0bXAgJiYgLS1sb29wKTsKPj4gICAKPj4gLSAgICAgICAvKiBFdmVy eXdoZXJlIGVsc2Ugd2UgYWx3YXlzIHVzZSBWTFZfQ09VTlRFUl9DT05UUk9MIHdpdGggdGhlCj4+ ICsgICAgICAgLyoKPj4gKyAgICAgICAgKiBFdmVyeXdoZXJlIGVsc2Ugd2UgYWx3YXlzIHVzZSBW TFZfQ09VTlRFUl9DT05UUk9MIHdpdGggdGhlCj4+ICAgICAgICAgICAqIFZMVl9DT1VOVF9SQU5H RV9ISUdIIGJpdCBzZXQgLSBzbyBpdCBpcyBzYWZlIHRvIGxlYXZlIGl0IHNldAo+PiAgICAgICAg ICAgKiBub3cuCj4+ICAgICAgICAgICAqLwo+PiAgIAo+PiAtICAgICAgIHNwaW5fdW5sb2NrX2ly cXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgZmxhZ3MpOwo+PiAtCj4+ICAgICAgICAg IHJldHVybiBsb3dlciB8ICh1NjQpdXBwZXIgPDwgODsKPj4gICB9Cj4+ICAgCj4+ICAgdTY0IGlu dGVsX3JjNl9yZXNpZGVuY3lfbnMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgaTkxNV9yZWdfdCByZWcpCj4+ICAg ewo+PiAtICAgICAgIHU2NCB0aW1lX2h3Owo+PiArICAgICAgIHU2NCB0aW1lX2h3LCBwcmV2X2h3 LCBvdmVyZmxvd19odzsKPj4gKyAgICAgICB1bnNpZ25lZCBpbnQgZndfZG9tYWluczsKPj4gKyAg ICAgICB1bnNpZ25lZCBsb25nIGZsYWdzOwo+PiAgICAgICAgICB1MzIgbXVsLCBkaXY7Cj4+ICsg ICAgICAgaW50IGk7Cj4+ICAgCj4+ICAgICAgICAgIGlmICghSEFTX1JDNihkZXZfcHJpdikpCj4+ ICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4+ICAgCj4+ICsgICAgICAgLyogQ291bnRlciB3 cmFwIGhhbmRsaW5nIHN0b3JlcyBwcmV2aW91cyBodyBjb3VudGVyIHZhbHVlcy4gKi8KPj4gKyAg ICAgICBpID0gKGk5MTVfbW1pb19yZWdfb2Zmc2V0KHJlZykgLQo+PiArICAgICAgICAgICAgaTkx NV9tbWlvX3JlZ19vZmZzZXQoR0VONl9HVF9HRlhfUkM2X0xPQ0tFRCkpIC8gc2l6ZW9mKHUzMik7 Cj4+ICsgICAgICAgaWYgKFdBUk5fT05fT05DRShpIDwgMCB8fAo+PiArICAgICAgICAgICAgICAg ICAgICAgICAgaSA+PSBBUlJBWV9TSVpFKGRldl9wcml2LT5ndF9wbS5yYzYuY3VyX3Jlc2lkZW5j eSkpKQo+IAo+IGludCBpLCBidXQgQVJSQVlfU0laRSBpcyB1bnNpZ25lZCwgc28ganVzdAo+IAo+ IGlmIChXQVJOX09OX09OQ0UoaSA+PSBBUlJBWV9TSVpFKGRldl9wcml2LT5ndF9wbS5yYzYuY3Vy X3Jlc2lkZW5jeSkpKQo+IAo+IHdvdWxkIHN1ZmZpY2UuCj4gCj4gSSByZW1haW4gc3VycHJpc2Vk IHRoYXQgdGhleSBhcmUgaW4gYSBuZWF0IGJsb2NrIGFjcm9zcyBhdG9tL2JpZy1jb3JlCj4gCj4g I2RlZmluZSBWTFZfR1RfUkVOREVSX1JDNiAgICAgICAgICAgICAgICAgICAgICAgX01NSU8oMHgx MzgxMDgpCj4gI2RlZmluZSBWTFZfR1RfTUVESUFfUkM2ICAgICAgICAgICAgICAgICAgICAgICAg X01NSU8oMHgxMzgxMEMpCj4gCj4gI2RlZmluZSBHRU42X0dUX0dGWF9SQzZfTE9DS0VEICAgICAg ICAgICAgICAgICAgX01NSU8oMHgxMzgxMDQpCj4gI2RlZmluZSBHRU42X0dUX0dGWF9SQzYgICAg ICAgICAgICAgICAgICAgICAgICAgX01NSU8oMHgxMzgxMDgpCj4gI2RlZmluZSBHRU42X0dUX0dG WF9SQzZwICAgICAgICAgICAgICAgICAgICAgICAgX01NSU8oMHgxMzgxMEMpCj4gI2RlZmluZSBH RU42X0dUX0dGWF9SQzZwcCAgICAgICAgICAgICAgICAgICAgICAgX01NSU8oMHgxMzgxMTApCj4g Cj4gYXJlIGluZGVlZCBqdXN0IHRoZSA0IHJlZ2lzdGVycyBpbiB1c2UuCj4gCj4+ICsgICAgICAg ZndfZG9tYWlucyA9IGludGVsX3VuY29yZV9mb3JjZXdha2VfZm9yX3JlZyhkZXZfcHJpdiwgcmVn LCBGV19SRUdfUkVBRCk7Cj4+ICsKPj4gKyAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3By aXYtPnVuY29yZS5sb2NrLCBmbGFncyk7Cj4+ICsgICAgICAgaW50ZWxfdW5jb3JlX2ZvcmNld2Fr ZV9nZXRfX2xvY2tlZChkZXZfcHJpdiwgZndfZG9tYWlucyk7Cj4+ICsKPj4gICAgICAgICAgLyog T24gVkxWIGFuZCBDSFYsIHJlc2lkZW5jeSB0aW1lIGlzIGluIENaIHVuaXRzIHJhdGhlciB0aGFu IDEuMjh1cyAqLwo+PiAgICAgICAgICBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNf Q0hFUlJZVklFVyhkZXZfcHJpdikpIHsKPj4gICAgICAgICAgICAgICAgICBtdWwgPSAxMDAwMDAw Owo+PiAgICAgICAgICAgICAgICAgIGRpdiA9IGRldl9wcml2LT5jemNsa19mcmVxOwo+PiArICAg ICAgICAgICAgICAgb3ZlcmZsb3dfaHcgPSBCSVRfVUxMKDQwKTsKPj4gICAgICAgICAgICAgICAg ICB0aW1lX2h3ID0gdmx2X3Jlc2lkZW5jeV9yYXcoZGV2X3ByaXYsIHJlZyk7Cj4+ICAgICAgICAg IH0gZWxzZSB7Cj4+ICAgICAgICAgICAgICAgICAgLyogODMzLjMzbnMgdW5pdHMgb24gR2VuOUxQ LCAxLjI4dXMgZWxzZXdoZXJlLiAqLwo+PiBAQCAtOTQ4Myw5ICs5NDk5LDMyIEBAIHU2NCBpbnRl bF9yYzZfcmVzaWRlbmN5X25zKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4g ICAgICAgICAgICAgICAgICAgICAgICAgIGRpdiA9IDE7Cj4+ICAgICAgICAgICAgICAgICAgfQo+ PiAgIAo+PiAtICAgICAgICAgICAgICAgdGltZV9odyA9IEk5MTVfUkVBRChyZWcpOwo+PiArICAg ICAgICAgICAgICAgb3ZlcmZsb3dfaHcgPSBCSVRfVUxMKDMyKTsKPj4gKyAgICAgICAgICAgICAg IHRpbWVfaHcgPSBJOTE1X1JFQURfRlcocmVnKTsKPj4gICAgICAgICAgfQo+PiAgIAo+PiArICAg ICAgIC8qCj4+ICsgICAgICAgICogQ291bnRlciB3cmFwIGhhbmRsaW5nLgo+PiArICAgICAgICAq Cj4+ICsgICAgICAgICogQnV0IHJlbHlpbmcgb24gYSBzdWZmaWNpZW50IGZyZXF1ZW5jeSBvZiBx dWVyaWVzIG90aGVyd2lzZSBjb3VudGVycwo+PiArICAgICAgICAqIGNhbiBzdGlsbCB3cmFwLgo+ PiArICAgICAgICAqLwo+PiArICAgICAgIHByZXZfaHcgPSBkZXZfcHJpdi0+Z3RfcG0ucmM2LnBy ZXZfaHdfcmVzaWRlbmN5W2ldOwo+PiArICAgICAgIGRldl9wcml2LT5ndF9wbS5yYzYucHJldl9o d19yZXNpZGVuY3lbaV0gPSB0aW1lX2h3Owo+PiArCj4+ICsgICAgICAgLyogUkM2IGRlbHRhIGZy b20gbGFzdCBzYW1wbGUuICovCj4+ICsgICAgICAgaWYgKHRpbWVfaHcgPj0gcHJldl9odykKPj4g KyAgICAgICAgICAgICAgIHRpbWVfaHcgLT0gcHJldl9odzsKPj4gKyAgICAgICBlbHNlCj4+ICsg ICAgICAgICAgICAgICB0aW1lX2h3ICs9IG92ZXJmbG93X2h3IC0gcHJldl9odzsKPj4gKwo+PiAr ICAgICAgIC8qIEFkZCBkZWx0YSB0byBSQzYgZXh0ZW5kZWQgcmF3IGRyaXZlciBjb3B5LiAqLwo+ PiArICAgICAgIHRpbWVfaHcgKz0gZGV2X3ByaXYtPmd0X3BtLnJjNi5jdXJfcmVzaWRlbmN5W2ld Owo+PiArICAgICAgIGRldl9wcml2LT5ndF9wbS5yYzYuY3VyX3Jlc2lkZW5jeVtpXSA9IHRpbWVf aHc7Cj4gCj4gT2suCj4gCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMt d2lsc29uLmNvLnVrPgo+IAo+IFRoZSBvdGhlciBwYXJ0IG9mIHRoZSBwdXp6bGUgd2FzIHBlcmhh cHMganVzdCB1c2luZyBhIHRpbWVyIHRvIHJlYWQgdGhlCj4gcmVnaXN0ZXJzIGV2ZXJ5IDEvMiB3 cmFwIHBlcmlvZCwgYnV0IHRoZXJlIHdhcyBubyBjbGVhciBwaWN0dXJlIG9uIHdoZW4KPiB0byBz dGFydCBhbmQgc3RvcCB0aGF0IHRpbWVyIGZvciBzeXNmcy4gSG93ZXZlciwgd2l0aCBwZXJmIHdl IGNhbiBjcmVhdGUKPiBhbmQgZGVzdHJveSBhIGJhY2tncm91bmQgdGltZXIgb24gUE1VIG9wZW4v ZGVzdHJveS4KPiAKPiBGYW5jeSBob29raW5nIHVwIGEgYmFja2dyb3VuZCB0aW1lcj8KCkNvdWxk IGRvLCB3YXNuJ3Qgc3VyZSB0aGF0IHRoZSBjb21wbGljYXRpb24gaXMgd29ydGggaXQuCgpJZGVh IHdvdWxkIGJlIHRvIHNjaGVkdWxlIGEgdGltZXIgZm9yIGluc3RhbmNlLCBhcyB5b3Ugc2F5LCAx LzIgd3JhcCAKcGVyaW9kLCBhbmQga2VlcCBwdXNoaW5nIGl0IGZvcndhcmQgb24gbWFudWFsIHJl YWRzLgoKQnV0IHRoZW4gcXVlc3Rpb24gb2YgcnVudGltZSBzdXNwZW5kIGFyaXNlcyBhZ2Fpbi4g SWYgd2UgZGVjaWRlIHRvIAplc3RpbWF0ZSB0aGUgY291bnRlciwgYXMgaW4gdGhlIGNhc2Ugb2Yg UE1VLCB0aGVuIEkgbmVlZCB0byBtb3ZlIHRoYXQgCmNvZGUgb3V0IG9mIFBNVSBhbmQgbWFrZSBp bnRlbF9wbS5jIHRoZSBvbmUgYW5kIG9ubHkgYXV0aG9yaXRhdGl2ZSAKc291cmNlIG9mIFJDNiBk YXRhLgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK