Return-Path: References: <20180328182948.27494-1-tvrtko.ursulin@linux.intel.com> From: Lionel Landwerlin Message-ID: <9e8af992-2edf-6d79-1cb5-1b64e95fea17@intel.com> Date: Wed, 28 Mar 2018 19:56:41 +0100 MIME-Version: 1.0 In-Reply-To: <20180328182948.27494-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-US Subject: Re: [igt-dev] [RFC i-g-t] intel-gpu-top: Rewrite the tool to be safe to use List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1800405733==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Tvrtko Ursulin , igt-dev@lists.freedesktop.org Cc: Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin List-ID: This is a multi-part message in MIME format. --===============1800405733== Content-Type: multipart/alternative; boundary="------------C72E59B823207781AF374560" Content-Language: en-US This is a multi-part message in MIME format. --------------C72E59B823207781AF374560 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 28/03/18 19:29, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio > register access. This patch rewrites it to use only PMU. > > Only overall command streamer busyness and GPU global data such as power > and frequencies are included in this new version. > > For access to more GPU functional unit level data, an OA metric based tool > like gpu-top should be used instead. > > Signed-off-by: Tvrtko Ursulin > Cc: Chris Wilson > Cc: Lionel Landwerlin > Cc: Petri Latvala Looks good to me too. Sorry, this isn't a detailed review, but since it's a lot safer : Reviewed-by: Lionel Landwerlin --------------C72E59B823207781AF374560 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 28/03/18 19:29, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

intel-gpu-top is a dangerous tool which can hang machines due unsafe mmio
register access. This patch rewrites it to use only PMU.

Only overall command streamer busyness and GPU global data such as power
and frequencies are included in this new version.

For access to more GPU functional unit level data, an OA metric based tool
like gpu-top should be used instead.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>

Looks good to me too. Sorry, this isn't a detailed review, but since it's a lot safer :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
--------------C72E59B823207781AF374560-- --===============1800405733== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg== --===============1800405733==--