Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8851CC7EE24 for ; Fri, 12 May 2023 11:53:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2AAE8624B; Fri, 12 May 2023 13:53:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="J4Z87QAM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 14F2C8624B; Fri, 12 May 2023 13:53:17 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 41C9C86240 for ; Fri, 12 May 2023 13:53:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7620563DCD; Fri, 12 May 2023 11:53:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD7E9C433EF; Fri, 12 May 2023 11:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683892391; bh=0VWPKNxK22ms0D2ymzijPKz1Ey4wf6UQ5H673YwQGO0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=J4Z87QAMY8mMbKmWiR3F3uAZT+MzlHCN4LUGtJPQ8p6B/AmTJqiDhSpk/3gcTBpGS CjQHR4sgY34G/BTV6/qixcINaI8bJqPhkCF3BfKIWaYbyCK+4WY7+gZncXXtwv3vPW KWs9Pq6ZrxRwg2RoIFAWYiKOPTO048daYs+0rrV1ck8vvEzPPgi8WesbaVjYSAtvxj FYExSAaqbdmhlpQKnFVfOsmryOCsfzpf//1QNsHmcAtHk+yvL9nnGZkJr3ncVv0I+h XWuhyZZJM6RVqXT2VC/RqTphX5Wn2Nz4mBbLTSx2f1qRhqXFdS3Kzh/GcwtF3FNUvN Ftb4afRJXeM2Q== Message-ID: <9ec2a385-a991-c3c1-4bfe-18b79793688d@kernel.org> Date: Fri, 12 May 2023 14:53:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: U-Boot OMAP GPMC ECC change Content-Language: en-US To: Colin Foster Cc: Michael Trimarchi , Dario Binacchi , u-boot@lists.denx.de References: <1944d1d1-399d-dfde-16ae-21a00ff7fbe3@kernel.org> From: Roger Quadros In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10/05/2023 18:38, Colin Foster wrote: > Hi Roger, > > On Wed, May 10, 2023 at 12:42:43PM +0300, Roger Quadros wrote: >> Hi Colin, >> >> On 09/05/2023 18:31, Colin Foster wrote: >>> Hi Roger, >>> >>> I was looking to test my system against U-Boot 2023.04. I'm running an >>> OMAP 4460 SOM (I've been waiting to get kernel acceptance before U-Boot, >>> but that has slipped) and it boots from NAND. >>> >>> When I jumped from 2023.01 to 2023.04, I noticed I get spammed in the >>> SPL by "omap-elm: uncorrectable ECC errors". I bisected, and this seems >>> to be the result of commit 04fcd25873 ("mtd: rawnand: omap_gpmc: Fix >>> BCH6/16 HW based correction"). >> >> oops. Sorry about that. > > No worries! > >>> >>> Is the multi-sector ECC generation something that should work in a >>> backward-compatible way? Do you know of anything that might be going >>> wrong here? >> >> The patch wasn't supposed to break anything. >> I do not yet know what could be wrong. Most likely a wrong ECC >> configuration is being used. >> >> Could you please share what ECC configuration you are using on your board? > > This is still out-of-U-Boot. I have an include/configs/our_product.h > file with this: > > """ > #define CFG_SYS_NAND_ECCPOS {2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, \ > 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, \ > 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, \ > 33, 34, 35, 36, 37, 38, 39, 40, 41, \ > 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, \ > 52, 53, 54, 55, 56, 57} > > #define CFG_SYS_NAND_ECCBYTES 14 > #define CFG_SYS_NAND_MAX_ECCPOS 57 This should be 56 i.e. (57 - 2 + 1) But it won't fix the issue you are facing. :P > #define CFG_SYS_NAND_ECCSIZE 512 > #define CFG_SYS_NAND_MAX_OOBFREE 2 > """ > > >> Can you please point me to the Linux device tree file if it exists? > > This is the latest submission. Still not accepted - I need to find time > to button everything up and resubmit. My plan of attack was Kernel > Acceptance, then U-Boot. Unfortunately my company lets the pesky > "Shipping products" step get in the way :-) > > https://lkml.org/lkml/2023/2/22/939 > > Or if you just want the ECC part: > > + nandflash: nand@0,0 { > + compatible = "ti,omap2-nand"; > + reg = <0 0 4>; > + interrupt-parent = <&gpmc>; > + > + nand-bus-width = <16>; > + ti,nand-ecc-opt = "bch8"; > + ti,elm-id=<&elm>; > + linux,mtd-name = "micron,nand"; > > > I think that's all the info you're looking for. Let me know if I missed > something. Yes this is all I was looking for. Is CONFIG_NAND_OMAP_ECCSCHEME_BCH8_CODE_HW set in your u-boot config? -- cheers, -roger