Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99286C433F5 for ; Sat, 28 May 2022 02:20:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7EE958434D; Sat, 28 May 2022 04:20:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=yo2urs.ro Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1EB1984348; Sat, 28 May 2022 02:11:00 +0200 (CEST) Received: from mail.yo2urs.ro (yo2urs.ro [86.126.81.149]) by phobos.denx.de (Postfix) with ESMTP id BAC0D84322 for ; Sat, 28 May 2022 02:10:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=yo2urs.ro Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=ghojda@yo2urs.ro Received: by mail.yo2urs.ro (Postfix, from userid 124) id 57DD53874; Sat, 28 May 2022 03:10:56 +0300 (EEST) Received: from www.yo2urs.ro (localhost [127.0.0.1]) by mail.yo2urs.ro (Postfix) with ESMTP id A459636E0; Sat, 28 May 2022 03:10:51 +0300 (EEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 28 May 2022 03:10:51 +0300 From: Gabriel Hojda To: Tom Rini Cc: u-boot@lists.denx.de Subject: BUG in u-boot for ODROID-XU3/XU4/HC1/HC2 User-Agent: Roundcube Webmail/1.4.13 Message-ID: <9f0e091322de234ea331e498ecea1f1f@yo2urs.ro> X-Sender: ghojda@yo2urs.ro X-Mailman-Approved-At: Sat, 28 May 2022 04:20:22 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean hi, i've recently tried u-boot 2022.04 (u-boot-v2022.04.tar.bz2) and my odroid-hc2 didn't boot with uefi (default since Fedora 35) but worked when i used exlinux.conf trying to track down the problem, i've found that in the default u-boot environment the "board" and "boardname" variables were "smdk5420" and not "odroid" (like before) ... and thus the "fdtfile" variable was "exynos5422-smdk5420hc1.dtb" and not "exynos5422-odroidhc1.dtb". continuing i've made a diff between the u-boot-v2021.10.tar.bz2 and u-boot-v2022.04.tar.bz2 ... and long story short, i've found the culprit in commit f76750d1 "Convert CONFIG_CONS_INDEX et al to Kconfig" : ------------------------------------------------------------------------------------------------- --- u-boot-v2021.10/include/configs/odroid_xu3.h 2021-10-04 18:09:26.000000000 +0300 +++ u-boot-v2022.04/include/configs/odroid_xu3.h 2022-04-04 17:31:32.000000000 +0300 @@ -75,14 +75,11 @@ /* Set soc_rev, soc_id, board_rev, board_name, fdtfile */ #define CONFIG_ODROID_REV_AIN 9 -#define CONFIG_REVISION_TAG /* * Need to override existing one (smdk5420) with odroid so set_board_info will * use proper prefix when creating full board_name (SYS_BOARD + type) */ -#undef CONFIG_SYS_BOARD -#define CONFIG_SYS_BOARD "odroid" /* Define new extra env settings, including DFU settings */ #undef CONFIG_EXTRA_ENV_SETTINGS ------------------------------------------------------------------------------------------------- and following part needs a revert ------------------------------------------------------------------------------------------------- -#undef CONFIG_SYS_BOARD -#define CONFIG_SYS_BOARD "odroid" ------------------------------------------------------------------------------------------------- or, as an (untested) alternative, define CONFIG_SYS_BOARD correctly in board/samsung/smdk5420/Kconfig as follows: ------------------------------------------------------------------------------------------------- --- Kconfig 2022-04-04 17:31:32.000000000 +0300 +++ Kconfig.new 2022-05-28 02:57:19.867518057 +0300 @@ -1,7 +1,7 @@ if TARGET_ODROID_XU3 config SYS_BOARD - default "smdk5420" + default "odroid" config SYS_VENDOR default "samsung" ------------------------------------------------------------------------------------------------- Gabriel