Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA74DC43331 for ; Tue, 31 Mar 2020 10:29:38 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 392CE20838 for ; Tue, 31 Mar 2020 10:29:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="V+22+jqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 392CE20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 20BFB82B; Tue, 31 Mar 2020 12:28:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 20BFB82B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1585650576; bh=5c6ldzLoJGoZ64/+nadWQXKpxw1tkIs+ygHRGhk/dnc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=V+22+jqwFBXvr4RLcRgiWZ9jEDrbfsfHzxtnu9AAeTL6OVn0TdRNy00z22GbL8jSV Qo7mpBDE4vux441kMj+HZv+Ilu1qjSrHs2QXw/Y4sZVApPGphn/64RzKQEUMBKYVdc lqE0zdP29S53CDCY90g6NijsCrtxqOl4P403sKm0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 912DFF80140; Tue, 31 Mar 2020 12:28:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 75C17F80146; Tue, 31 Mar 2020 12:28:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 25638F8010D for ; Tue, 31 Mar 2020 12:28:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 25638F8010D IronPort-SDR: j27oW6BXUcSKBfRbs7OdDkvkJVO6NYtolUf/BCFzm45EyR7Y/W9JXZCkDVucBoVwf4S6Z9/0e0 PEx3uiYRJdQQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 03:28:28 -0700 IronPort-SDR: 0oYkq1L8SC0Jmf42og5EgfZTQVJsys6By+Rpr9rSzokV2sjPtNt89HevlkWrvzgQ8Fbsl8s76+ 4qNEBo1Cm7RQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="272698098" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.17.105]) ([10.213.17.105]) by fmsmga004.fm.intel.com with ESMTP; 31 Mar 2020 03:28:24 -0700 Subject: Re: [PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link To: Hans de Goede , Pierre-Louis Bossart , alsa-devel@alsa-project.org References: <20200319204947.18963-1-cezary.rojewski@intel.com> <20200319204947.18963-4-cezary.rojewski@intel.com> <259cbb60-9e59-1132-8371-83f837577f86@redhat.com> From: Cezary Rojewski Message-ID: <9f1884b4-e356-9a8f-6912-0d55c4bcbf06@intel.com> Date: Tue, 31 Mar 2020 12:28:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <259cbb60-9e59-1132-8371-83f837577f86@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: Kuninori Morimoto , Curtis Malainey , tiwai@suse.com, Dominik Brodowski , lgirdwood@gmail.com, vkoul@kernel.org, broonie@kernel.org, Ben Zhang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2020-03-30 23:39, Hans de Goede wrote: > Hi, > >> On 3/19/20 11:14 PM, Pierre-Louis Bossart wrote: >> >> we should ask Ben and Curtis @ Google if the changes related to >> suspend interfere with the wake-on-voice support? >> >> Btw the .ignore_suspend is also set in bytcr_rt5640/51 drivers, so >> wondering if additional devices are broken, or if there's something >> off about Broadwell in general. Hans, have you heard of any >> regressions on Baytrail devices? > > I've just tested 5.6.0 on Bay Trail + a rt5651 codec, > using the bytcr_rt5651 machine driver which sets > ignore_suspend, as well as on a Cherry Trail + rt5645 > device using the chtrt5645 machine driver which does > _not_ set ignore suspend. > > Suspend/resume work fine on both and music playing > before suspend continues playing after suspend. > > Note that the bytcr_rt5651 machine driver also does: > >         snd_soc_dapm_ignore_suspend(&card->dapm, "Headphone"); >         snd_soc_dapm_ignore_suspend(&card->dapm, "Speaker"); > > Which the bdw-rt5677 seems to not do... > > Regards, > > Hans > Thanks for your report Hans! As all streams (whether that's playback routed through Headphones or Speaker, or capture) were connected to SSP0 dai link, there is a question to be raised: Is Capture path needed to be up during suspend for broadwell solutions? Guess these two lines you mentioned above have the exact same impact on playback as complete .ignore_suspend flag removal from SSP0 dai link. Don't believe WoV for WPT has been added for SST linux so .ignore_suspend=1 achieves nothing. The offload part is probably just limited to bigger buffer size compared to system pin than anything else. So, nothing prevents from removing .ignore_suspend for SST solutions until WoV is verified. Don't know about SOF side. Pierre, what's your take on this? Czarek