From: "cron2 (Code Review)" Date: Wed, 15 Apr 2026 09:52:38 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., selva.nair@...277..., openvpn-devel@lists.sourceforge.net Message-ID: <9f85736e3379c945a268272fa8c25e5771aa4198-EmailReplacePatchSet-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="4kNjO4s5Xdg="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Add unit tests for 'auth-user-pass username-only' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: selvanair , plaisthos Cc: openvpn-devel --4kNjO4s5Xdg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable cron2 has uploaded a new patch set (#3) to the change originally created by= selvanair. ( http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail ) The following approvals got outdated and were removed: Code-Review+2 by plaisthos Change subject: Add unit tests for 'auth-user-pass username-only' ...................................................................... Add unit tests for 'auth-user-pass username-only' Input from stdin is tested. Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Signed-off-by: Selva Nair Acked-by: Arne Schwabe Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1602 Message-Id: <20260414055805.16974-1-gert@...1296...> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36= 605.html Signed-off-by: Gert Doering --- M tests/unit_tests/openvpn/test_user_pass.c 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/02/1602/3 diff --git a/tests/unit_tests/openvpn/test_user_pass.c b/tests/unit_tests/o= penvpn/test_user_pass.c index 16e0535..c0a0866 100644 --- a/tests/unit_tests/openvpn/test_user_pass.c +++ b/tests/unit_tests/openvpn/test_user_pass.c @@ -282,6 +282,17 @@ assert_true(up.defined); assert_string_equal(up.username, "user"); assert_string_equal(up.password, ""); + + reset_user_pass(&up); + + flags =3D GET_USER_PASS_USERNAME_ONLY; + expect_string(query_user_exec_builtin, query_user[i].prompt, "Enter UT= Username:"); + will_return(query_user_exec_builtin, "cuser"); + will_return(query_user_exec_builtin, true); + assert_true(get_user_pass_cr(&up, "stdin", "UT", flags, NULL)); + assert_true(up.defined); + assert_string_equal(up.username, "cuser"); + assert_string_equal(up.password, "[[BLANK]]"); } /* NOTE: expect_assert_failure does not seem to work with MSVC */ -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1602?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings?usp=3Demail Gerrit-MessageType: newpatchset Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d Gerrit-Change-Number: 1602 Gerrit-PatchSet: 3 Gerrit-Owner: selvanair Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel --4kNjO4s5Xdg= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

cron2 upl= oaded patch set #3 to the change originally created by selvanair.<= /p>

Vi= ew Change

The following approvals got outdated and were removed: Code-Review+2 by plaisthos

Add unit tests for 'auth-us=
er-pass username-only'

Input from stdin is tested.

Change= -Id: I1c18b3cf4a454444a61941d88a702a140b0ac23d
Signed-off-by: Selva Nair= <selva.nair@...277...>
Acked-by: Arne Schwabe <arne-openvpn@...1186...= .1227...>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1602
= Message-Id: <20260414055805.16974-1-gert@...1296...>
URL: https://= www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg36605.html
S= igned-off-by: Gert Doering <gert@...1296...>
---
M tests/unit_t= ests/openvpn/test_user_pass.c
1 file changed, 11 insertions(+), 0 deleti= ons(-)

git pull ssh://gerrit.openvpn.net:29418/o=
penvpn refs/changes/02/1602/3
diff --git a/tests/unit_tests/openvpn=
/test_user_pass.c b/tests/unit_tests/openvpn/test_user_pass.c
index 16e0535..c0a0866 100644
--- a/tests/unit_tests/ope= nvpn/test_user_pass.c
+++ b/tests/unit_tests/openvpn/test_u= ser_pass.c
@@ -282,6 +282,17 @@
assert= _true(up.defined);
assert_string_equal(up.username, &q= uot;user");
assert_string_equal(up.password, &quo= t;");
++ reset_user_pass(&up)= ;
+
+ flags =3D GET_USER_PASS_USERNAME_= ONLY;
+ expect_str= ing(query_user_exec_builtin, query_user[i].prompt, "Enter UT Username:= ");
+ will_re= turn(query_user_exec_builtin, "cuser");
+ will_return(query_user_exec_builtin, true= );
+ assert_true(g= et_user_pass_cr(&up, "stdin", "UT", flags, NULL));<= /span>
+ assert_true(up.d= efined);
+ assert_= string_equal(up.username, "cuser");
+ assert_string_equal(up.password, "[[BLAN= K]]");
}

/* NOTE: = expect_assert_failure does not seem to work with MSVC */

To view, visit change 1602. To unsubscribe, or for help writi= ng mail filters, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1c18b3cf4a454444a61941d88a7= 02a140b0ac23d
Gerrit-Change-Number: 1602
Gerrit-PatchSet: 3
Gerrit-Owner: selvanair <selva.nair@...1354...= ..>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
= --4kNjO4s5Xdg=--