From: "plaisthos (Code Review)" Date: Fri, 19 Jan 2024 11:58:07 +0000 In-Reply-To: References: Reply-To: arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <9fd6373a3f13c5569bed92f0a67d5b6366069870-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="tQgGyHA+4fQ="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: buf_string_match_head_str: Fix Coverity issue "Unsigned compared agai... List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: openvpn-devel --tQgGyHA+4fQ= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c= /openvpn/+/491?usp=3Demail ) Change subject: buf_string_match_head_str: Fix Coverity issue "Unsigned com= pared against 0" ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This looks like it might have been written with strcmp in mind or something= like that but for the current code the < 0 makes indeed no sense. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/491?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I64f094eeb0ca8c3953a94d742adf468faf27dab3 Gerrit-Change-Number: 491 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Fri, 19 Jan 2024 11:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment --tQgGyHA+4fQ= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld.

View C= hange

1 comment:

    <= li style=3D"margin: 0; padding: 0;">

    Patchset:

    • Patch Set #1:

      This looks like it might have been written with st= rcmp in mind or something like that but for the current code the < 0 mak= es indeed no sense.

To view, visit change 491. To unsu= bscribe, or for help writing mail filters, visit settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I64f094eeb0ca8c3953a94d742ad= f468faf27dab3
Gerrit-Change-Number: 491
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Fri, 19 Jan 2024 11:58:07= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
--tQgGyHA+4fQ=--