From: Akio Takebe <takebe_akio@jp.fujitsu.com>
Subject: Re: [PATCH] kexec: framework and i386 (Take XIV)
Date: Fri, 01 Sep 2006 17:41:32 +0900
Message-ID: <A5C6CDA26D3151takebe_akio@jp.fujitsu.com>
References: <20060811074839.GA21317@verge.net.au>
	<20060831074259.GB23148@verge.net.au>
	<88C6CCDB437DC3takebe_akio@jp.fujitsu.com>
	<20060901025610.GE31034@verge.net.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
In-Reply-To: <20060901025610.GE31034@verge.net.au>
Sender: xen-ia64-devel-bounces@lists.xensource.com
Errors-To: xen-ia64-devel-bounces@lists.xensource.com
To: Horms <horms@verge.net.au>
Cc: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>, Kazuo Moriwaka <moriwaka@valinux.co.jp>, xen-devel@lists.xensource.com, "Zou, Nanhai" <nanhai.zou@intel.com>, Magnus Damm <magnus@valinux.co.jp>, Isaku Yamahata <yamahata@valinux.co.jp>, Keir Fraser <Keir.Fraser@cl.cam.ac.uk>, xen-ia64-devel@lists.xensource.com

Hi, Horms

>That seems like a good idea to me. Though I think you are missing { }.
>Can you test to see if this works?
Oops, You're right. But I think unknown_nmi_error() is not called,
because crash_kexec() is called before that.

Yes, I'll test it. :-)

>
>--- a/xen/arch/x86/traps.c	2006-09-01 11:53:44.000000000 +0900
>+++ b/xen/arch/x86/traps.c	2006-09-01 11:53:56.000000000 +0900
>@@ -1611,8 +1611,10 @@
>             mem_parity_error(regs);
>         else if ( reason & 0x40 )
>             io_check_error(regs);
>-        else if ( !nmi_watchdog )
>+        else if ( !nmi_watchdog ) {
>+	    crash_kexec(NULL);
>             unknown_nmi_error((unsigned char)(reason&0xff));
>+	}
>     }
> }
> 

Best Regards,

Akio Takebe